[Bug 39313] New: OpacTrustedCheckout self-checkout modal not checking out valid barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Bug ID: 39313 Summary: OpacTrustedCheckout self-checkout modal not checking out valid barcode Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Entering a valid barcode into the self-checkout modal returns an error "Message code 'UNKNOWN_BARCODE' with data '1'" Requires OpacTrustedCheckout to be enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38505 Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This is due to a change introduced in Bug 38505 kohadev-koha@kohadevbox:koha((v24.11.02-1))$ git checkout origin/main Previous HEAD position was 7707a62f91f Update release notes for 24.11.02 release HEAD is now at cb89b42f817 Bug 38663: DBIC schema update kohadev-koha@kohadevbox:koha((cb89b42f817...))$ git bisect start status: waiting for both good and bad commits kohadev-koha@kohadevbox:koha((cb89b42f817...)|BISECTING)$ git bisect bad status: waiting for good commit(s), bad commit known kohadev-koha@kohadevbox:koha((cb89b42f817...)|BISECTING)$ git bisect good v24.11.02-1 Bisecting: a merge base must be tested [9bbb73fa2682d9065f42ffde5fa4548dc8592d43] Koha 24.11 is here! kohadev-koha@kohadevbox:koha((v24.11.00)|BISECTING)$ git bisect good Bisecting: 553 revisions left to test after this (roughly 9 steps) [c57cd77bd29e7da7f27333e7abb546f23421908b] Bug 38714: biblio-title-head.inc kohadev-koha@kohadevbox:koha((c57cd77bd29...)|BISECTING)$ git bisect bad Bisecting: 276 revisions left to test after this (roughly 8 steps) [143220d0c6d2d82bc007be029221ee3ede676f2f] Bug 37832: Fix Rental discount to be decimal like other similar fields kohadev-koha@kohadevbox:koha((143220d0c6d...)|BISECTING)$ git bisect bad Bisecting: 138 revisions left to test after this (roughly 7 steps) [4fb4b7527ef80519a6ff9c794505fc128d62c534] Bug 37761: Add focus on patron search when on the tab kohadev-koha@kohadevbox:koha((4fb4b7527ef...)|BISECTING)$ git bisect good Bisecting: 69 revisions left to test after this (roughly 6 steps) [04c095c4734e6851637382e5c50081fd0933183c] Bug 34068: Add tests kohadev-koha@kohadevbox:koha((04c095c4734...)|BISECTING)$ git bisect good Bisecting: 34 revisions left to test after this (roughly 5 steps) [9f5f4aa1d63f24c7aa84e2428f67825e6feba0b3] Bug 38503: Do not list the objects kohadev-koha@kohadevbox:koha((9f5f4aa1d63...)|BISECTING)$ git bisect bad Bisecting: 17 revisions left to test after this (roughly 4 steps) [ecd0604a8ded12803846de6d3e7dac5e9eed2765] Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message kohadev-koha@kohadevbox:koha((ecd0604a8de...)|BISECTING)$ git bisect bad Bisecting: 8 revisions left to test after this (roughly 3 steps) [2a6bc075f6c7c7eadda044dda892d36997884f50] Bug 38751: Add tests kohadev-koha@kohadevbox:koha((2a6bc075f6c...)|BISECTING)$ git bisect good Bisecting: 4 revisions left to test after this (roughly 2 steps) [c42cfecd43b36048414615622f7121c7de31e657] Bug 37448: Add build_sample_ill_request kohadev-koha@kohadevbox:koha((c42cfecd43b...)|BISECTING)$ git bisect good Bisecting: 2 revisions left to test after this (roughly 1 step) [45626c75c4d83075892015233634106814f26942] Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode kohadev-koha@kohadevbox:koha((45626c75c4d...)|BISECTING)$ git bisect good Bisecting: 0 revisions left to test after this (roughly 1 step) [90304e7632547fcb275d93a88afc88e4a52dd1ed] Bug 38505: ill-requests.tt: Use .alert-warning when .alert exists kohadev-koha@kohadevbox:koha((90304e76325...)|BISECTING)$ git bisect bad Bisecting: 0 revisions left to test after this (roughly 0 steps) [89b7f160a75e063582793a30636c137ddacdc96d] Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy kohadev-koha@kohadevbox:koha((89b7f160a75...)|BISECTING)$ git bisect bad 89b7f160a75e063582793a30636c137ddacdc96d is the first bad commit commit 89b7f160a75e063582793a30636c137ddacdc96d Author: Pedro Amorim <pedro.amorim@ptfs-europe.com> Date: Thu Nov 21 14:23:19 2024 -0100 Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy Before applying this patch, apply the CanBookBeIssued preparation: tests patch and run that, Verify it fails, apply this patch. Run that same tests file again. ----- About this change ----- CanBookBeIssued wants to find one item given a barcode. If a falsy (undef, empty) barcode is supplied, UNKNOWN_BARCODE should be returned. Ensure this change does not introduce any regressions: prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 [Bug 38505] CirculateILL checkout broken if item does not have a barcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 179191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179191&action=edit Bug 39313: Make OpacTrustedCheckout self-checkout modal accept valid barcode This patch fixes a regression introduced by Bug 38505. To test: 1. Enabled OpacTrustedCheckout system preference 2. Search for an item and get the barcode 3. Go to the OPAC 4. Click the Self-checkout button at the top 5. Enter the barcode and submit 6. Notice you are given an error UNKNOWN_BARCODE and the item is not checked out 7. Apply the patch and restart services 8. Repeat steps 4-6 and confirm you are able to successfully check out the item 9. Test submitting the modal with no barcode entered - confirm you are shown an appropriate error 10. Test with a fake barcode that does not exist - confirm you are shown an appropriate error 11. Run tests to confirm no regressions prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t prove t/db_dependent/Koha/ILL/Requests.t Sponsored-by: Reserve Bank of New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179191|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179192&action=edit Bug 39313: Make OpacTrustedCheckout self-checkout modal accept valid barcode This patch fixes a regression introduced by Bug 38505. To test: 1. Enabled OpacTrustedCheckout system preference 2. Search for an item and get the barcode 3. Go to the OPAC 4. Click the Self-checkout button at the top 5. Enter the barcode and submit 6. Notice you are given an error UNKNOWN_BARCODE and the item is not checked out 7. Apply the patch and restart services 8. Repeat steps 4-6 and confirm you are able to successfully check out the item 9. Test submitting the modal with no barcode entered - confirm you are shown an appropriate error 10. Test with a fake barcode that does not exist - confirm you are shown an appropriate error 11. Run tests to confirm no regressions prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t prove t/db_dependent/Koha/ILL/Requests.t Sponsored-by: Reserve Bank of New Zealand Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised, including the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179192|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179196&action=edit Bug 39313: Make OpacTrustedCheckout self-checkout modal accept valid barcode This patch fixes a regression introduced by Bug 38505. To test: 1. Enabled OpacTrustedCheckout system preference 2. Search for an item and get the barcode 3. Go to the OPAC 4. Click the Self-checkout button at the top 5. Enter the barcode and submit 6. Notice you are given an error UNKNOWN_BARCODE and the item is not checked out 7. Apply the patch and restart services 8. Repeat steps 4-6 and confirm you are able to successfully check out the item 9. Test submitting the modal with no barcode entered - confirm you are shown an appropriate error 10. Test with a fake barcode that does not exist - confirm you are shown an appropriate error 11. Run tests to confirm no regressions prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t prove t/db_dependent/Koha/ILL/Requests.t Sponsored-by: Reserve Bank of New Zealand Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised, including the tests. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- We should add a unit test for this to prevent a future regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38184 [Bug 38184] OpacTrustedCheckout module does not show due date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 179296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179296&action=edit Bug 39313: Unit test for passing valid item object to CanBookBeIssued rather than a barcode. Will be tested within previous test plan. Sponsored-by: Reserve Bank of New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179296|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179324&action=edit Bug 39313: Unit test for passing valid item object to CanBookBeIssued rather than a barcode. Will be tested within previous test plan. Sponsored-by: Reserve Bank of New Zealand Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179196|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179327&action=edit Bug 39313: Make OpacTrustedCheckout self-checkout modal accept valid barcode This patch fixes a regression introduced by Bug 38505. To test: 1. Enabled OpacTrustedCheckout system preference 2. Search for an item and get the barcode 3. Go to the OPAC 4. Click the Self-checkout button at the top 5. Enter the barcode and submit 6. Notice you are given an error UNKNOWN_BARCODE and the item is not checked out 7. Apply the patch and restart services 8. Repeat steps 4-6 and confirm you are able to successfully check out the item 9. Test submitting the modal with no barcode entered - confirm you are shown an appropriate error 10. Test with a fake barcode that does not exist - confirm you are shown an appropriate error 11. Run tests to confirm no regressions prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t prove t/db_dependent/Koha/ILL/Requests.t Sponsored-by: Reserve Bank of New Zealand Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised, including the tests. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179324|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179328&action=edit Bug 39313: Unit test for passing valid item object to CanBookBeIssued rather than a barcode. Will be tested within previous test plan. Sponsored-by: Reserve Bank of New Zealand Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thankyou :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #13 from Jesse Maseto <jesse@bywatersolutions.com> --- Don't believe this is needed in 24.05.x. Please let me know if I'm wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #15 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Bug 39313 depends on bug 38505, which changed state. Bug 38505 Summary: CirculateILL checkout broken if item does not have a barcode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org