[Bug 14607] New: Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Bug ID: 14607 Summary: Baker & Taylor cover images should be accessible by UPC as well as ISBN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 41393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41393&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41393|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 41633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 41633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633 Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Review of attachment 41633: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14607&attachment=41633) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc @@ +58,4 @@
<div title="[% item.biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail-preview-[% coce_id %]"></div> [% END %] [% IF ( BakerTaylorEnabled ) %] + [% bt_id = ( item.browser_normalized_upc || item.browser_normalized_upc ) %]
This does not make any sense :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 42253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42253&action=edit Bug 14607: (QA followup) Fix typo in shelfbrowser.inc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Jesse, I cannot test this patch, I don't have a B&T account. But looking at the code I am wondering if there is not another occurrence to update: opac-user.tt l.414 <a href="https://[% BakerTaylorBookstoreURL |html %][% OVERDUE.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% OVERDUE.normalized_isbn %]" /></a> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #6 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 42547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42547&action=edit Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Jesse, since I cannot test the patch, I would like to get a signoff on the 2 last patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42253|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 43018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43018&action=edit Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42547|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 43019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43019&action=edit Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41633|0 |1 is obsolete| | Attachment #43018|0 |1 is obsolete| | Attachment #43019|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43157&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43158&action=edit Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43159&action=edit Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jesse! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Baker & Taylor cover images |Make Baker & Taylor cover |should be accessible by UPC |images accessible by UPC as |as well as ISBN |well as ISBN -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org