[Bug 11881] New: Small improvements in OPAC results list.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Bug ID: 11881 Summary: Small improvements in OPAC results list. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org Created attachment 25747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25747&action=edit Small improvements for the availability informations in the search results list on the OPAC. This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test this patch, simply do a search on the OPAC and check the format of availability informations for each search result. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- There's a merge problem. I'll let the original author rebase before I sign off, rather than me sign off on my rebase of it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this change could be something not everyone will agree to as it sounds like the items line will take up a lot more space for bigger consortia with lots of libraries. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Yes, the substitution of a comma for a line break does increase vertical spacing. However, I personally find it more visually appealing and less of a giant blur from one into another. The vertical spacing increases *IF* there are multiple branches with the same biblio. A single branch would not experience any visual difference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This sounds like the kind of change that could be better handled by using a custom XSL stylesheet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- You're probably right, Owen. Though, you'd have to keep re-patching, if the default templates shifted for security reasons. Which is probably why they want it in the default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are system preferences for defining your own custom XSLT paths to be used for OPAC and staff, so repatching won't be needed. Of course, you will have to add new features to your custom files or add your changes to a copy of the default again, but updates won't overwrite your changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25747|0 |1 is obsolete| | --- Comment #7 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25921&action=edit New version of the patch. Rebase on current master. Here is a new version of the patch. In the end, we think this new view is easier to read and understand for patrons, and this is why we are sharing this patch. Also, I won't hide updates would be a lot easier for us if we didn't have to reapply our patch everytime we want to update Koha. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Changes to koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl 2008: 13 2009: 14 2010: 14 2011: 10 2012: 9 2013: 6 2014: 1 It would seem to me that the amount the template is changing is going down, but with it changing every 1-2 months, I can understand why the change is desired in master. Is there a way to system preference the line break vs. comma in XSLT? Perhaps that would be more acceptable, and default to comma given that is the current behaviour. I changed this to in discussion, because as far as I can tell this patch won't make it past QA, because of the comma vs. line break difference and because perhaps a system preference thought may save this desired line break functionality. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- QA issues: - The patch only changes prog, not bootstrap - "Call Number" is incorrectly capitalized. If we want to avoid custom XSLT the compromise would be to add markup and classes to the XSL so that the these snippets of text can be styled and/or hidden as desired: - Wrap the individual library lines in a span which can be made "display:block" in custom CSS. - Wrap the "cal number" text in a span which is hidden by default in the CSS. Use custom CSS to show it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25921|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 29681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29681&action=edit Small improvements for the availability informations in the search results list on the OPAC. * Add linebreaks to each location via CSS spans. * Add the text "Call number:" before call numbers hidden by default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 29682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29682&action=edit Bug 11881 - Follow-up: Add CSS entries to opac.css (prog) This adds the two classes in the spans into opac.css, and it can be overridden in a custom style sheet as needed. Only for the prog theme. To test, apply both prog patches and simply do a search on the OPAC and check the format of availability informations for each search result. By default it should be unchanged. Override the defaults by adding the following into a custom CSS file: .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .LabelCallNumber { display: inline; # inline - display, none - don't display } The call number will be labelled, and items will have line breaks added in the listing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com --- Comment #12 from Eric Bégin <eric.begin@inLibro.com> --- Mark, did you forget to set this bugs as « Needs Signoff » ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- No, because of comment 9 requiring a bootstrap portion of the patch. I just fixed the prog side. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #14 from Eric Bégin <eric.begin@inLibro.com> --- Created attachment 29873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29873&action=edit Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29873|0 |1 is obsolete| | --- Comment #15 from Eric Bégin <eric.begin@inLibro.com> --- Comment on attachment 29873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29873 Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo Another patch will follow with all required files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #16 from Eric Bégin <eric.begin@inLibro.com> --- Created attachment 29874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29874&action=edit Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Eric Bégin <eric.begin@inLibro.com> --- Bootstrap is now supported -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29874|0 |1 is obsolete| | --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 29875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29875&action=edit Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo rebased to apply cleanly -- Mark Tompsett -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@quecheelibrary.org --- Comment #19 from Nick Clemens <nick@quecheelibrary.org> --- Patch doesn't apply Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/less/opac.less Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Failed to merge in the changes. Patch failed at 0001 Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11881-Follow-up-Add-the-CommasWithLinebreaks-a-aaGWGn.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com | |, | |simith.doliveira@inlibro.co | |m Assignee|eric.begin@inLibro.com |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29681|0 |1 is obsolete| | --- Comment #20 from simith.doliveira@inlibro.com --- Created attachment 34004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34004&action=edit Small improvements for the availability informations in the search results list on the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29682|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #21 from simith.doliveira@inlibro.com --- To test: I) Apply the patch validate: no breakline nor "Call Number:" text. II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } validate: Breakline or "Call Number:" text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #22 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36470&action=edit [SIGNED-OFF] Small improvements for the availability informations in the search results list on the OPAC. http://bugs.koha-community.org/show_bug.cgi?id=11881 Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Simith, The css file is generated from the less file (less/opac.less). You need to attach to the patch the change you have done to this file too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #24 from simith.doliveira@inlibro.com --- Created attachment 36496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36496&action=edit Add changes to opac.less -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from simith.doliveira@inlibro.com --- opac.less file added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to simith.doliveira from comment #25)
opac.less file added
Ok thanks. No signoff needed for this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- The opac.css does not look good. With your patch: -rw-r--r-- 1 koha koha 42132 Mar 4 16:25 bootstrap/css/opac.css $lessc --compress bootstrap/less/opac.less > bootstrap/css/opac.css -rw-r--r-- 1 koha koha 42946 Mar 4 16:25 bootstrap/css/opac.css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #28 from simith.doliveira@inlibro.com --- Created attachment 36510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36510&action=edit Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #29 from simith.doliveira@inlibro.com --- I created a new patch with just MARC21slim2OPACResults.xsl file because reading the comments #2, #4, #9 and #21 we don't need .css ou .less files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #30 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #27)
The opac.css does not look good. With your patch: -rw-r--r-- 1 koha koha 42132 Mar 4 16:25 bootstrap/css/opac.css
$lessc --compress bootstrap/less/opac.less > bootstrap/css/opac.css -rw-r--r-- 1 koha koha 42946 Mar 4 16:25 bootstrap/css/opac.css
mtompset@ubuntu:~/kohaclone$ git reset --hard origin/master HEAD is now at 45e5afb Bug 13731: Suggestions reason does not save on updating the status mtompset@ubuntu:~/kohaclone$ ls -la koha-tmpl/opac-tmpl/bootstrap/css/opac.css -rw-rw-r-- 1 mtompset mtompset 42879 Mar 5 00:01 koha-tmpl/opac-tmpl/bootstrap/css/opac.css mtompset@ubuntu:~/kohaclone$ lessc --compress koha-tmpl/opac-tmpl/bootstrap/less/opac.less > koha-tmpl/opac-tmpl/bootstrap/css/opac.css mtompset@ubuntu:~/kohaclone$ ls -la koha-tmpl/opac-tmpl/bootstrap/css/opac.css -rw-rw-r-- 1 mtompset mtompset 43371 Mar 5 00:01 koha-tmpl/opac-tmpl/bootstrap/css/opac.css mtompset@ubuntu:~/kohaclone$ I don't think it is this patch per say. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have stared at this for a while, there are some things I am not completely happy with: 1) There is a visible change on the result list with this patch - the added 'Call number: ' in front of every entry. This can be hidden with CSS, so I think it's probably ok. Example: Availability: Items available for loan: Fairfield [Call number: 320] (1), Franklin [Call number: 320] (1), Riverside [Call number: 320] (1), Union [Call number: 320] (1). 2) I am stumbling a bit over 'CommasWithLinebreaks' as a class name. I'd like something that describes the content better. 3) The 'Call number: ' change is not consistent. If you have an item whose item type is marked as not for loan, it will show up separately: Example: Availability: Items available for loan: Franklin [Call number: 320] (1), Riverside [Call number: 320] (1), Union [Call number: 320] (1). Items available for reference: Fairfield [320] (1 ). Failing for 3) - would be good to get another opinion on 1) and 2). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #32 from M. Tompsett <mtompset@hotmail.com> --- Katrin, you'll note the obsoleted "Add changes to opac.less" file which an be used to build tweaks to the opac.css file which would hide the label. So, I don't think (1) is an issue, except that perhaps the less and corresponding css change shouldn't be obsoleted? CommasWithLinebreaks is EXACTLY what it can be used for. With the appropriate CSS, Linebreaks between the items can be forced. I don't think the name is so far off what it actually is intended to do. So, I don't see an issue with (2). However, you rightly point out (3) is inconsistent. I agree that should be fixed before signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Genevieve Plantin <genevieve.plantin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36510|0 |1 is obsolete| | --- Comment #33 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 42487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42487&action=edit Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #34 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 42488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42488&action=edit Bug 11881 - Small improvements for Items available for reference As said on comment #31, Items available for reference weren't displayed like Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks class and LabelCallNumber class -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Genevieve Plantin <genevieve.plantin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |genevieve.plantin@inlibro.c | |om Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42487|0 |1 is obsolete| | --- Comment #35 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 42489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42489&action=edit Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) http://bugs.koha-community.org/show_bug.cgi?id=11881 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42488|0 |1 is obsolete| | --- Comment #36 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 42490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42490&action=edit Bug 11881 - Small improvements for Items available for reference As said on comment #31, Items available for reference weren't displayed like Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks class and LabelCallNumber class Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #37 from Nick Clemens <nick@quecheelibrary.org> --- One small thing I noticed was an extra line between the available items list and the Checked Out(1) line after I had applied the CSS snippet -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #38 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- (In reply to Nick Clemens from comment #37)
One small thing I noticed was an extra line between the available items list and the Checked Out(1) line after I had applied the CSS snippet
Is 'Checked out' supposed to be on the same line as an [Call number : 320] ? I just want to be sure I correct it the good way. I was thinking about it because there's other unavailable classes like Withdrawn, Lost, Damaged, etc. Are they supposed to be on the same line too ? Wouldn't it weird if it was only in the same line as one Call Number even if there is three Call Number ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42489|0 |1 is obsolete| | Attachment #42490|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42807&action=edit Bug 11881: Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42808&action=edit Bug 11881 - Small improvements for Items available for reference As said on comment #31, Items available for reference weren't displayed like Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks class and LabelCallNumber class Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks fine by me. I am waiting for a confirmation from Katrin before passing QA on it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No problem with the patch itself, but I am not a fan of the name of the class: CommasWithLinebreaks A good rule is not to name classes on appearance, as appearance can change with CSS, but according to what they contain - something that describes that it's the item information for one branch maybe. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42807|0 |1 is obsolete| | Attachment #42808|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43946&action=edit [PASSED QA] Bug 11881: Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43947&action=edit [OPTIONAL] Bug 11881: QA follow-up - rename class A suggestion for renaming the class to be a bit more "content" then "appearance". Strictly optional. .ItemSummary { display: block; # block - line breaks, inline - all one line } .LabelCallNumber { display: inline; # inline - display, none - don't display } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43946|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43948&action=edit [PASSED QA] Bug 11881: Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43949&action=edit [PASSED QA] Bug 11881 - Small improvements for Items available for reference As said on comment #31, Items available for reference weren't displayed like Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks class and LabelCallNumber class Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43947|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43950&action=edit [OPTIONAL] Bug 11881: QA follow-up - rename class A suggestion for renaming the class to be a bit more "content" then "appearance". Strictly optional. .ItemSummary { display: block; # block - line breaks, inline - all one line } .LabelCallNumber { display: inline; # inline - display, none - don't display } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Simith and Genevieve! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Small improvements in OPAC |Small improvements in OPAC |results list. |results list -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org