[Bug 21784] New: Clean up js_includes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Bug ID: 21784 Summary: Clean up js_includes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Script type attributes should be removed from js_includes. CDATA markers can also be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clean up js_includes |Clean up js_includes.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82044&action=edit Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82044|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88528&action=edit Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88528|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88568&action=edit Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00 released in| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported into 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org