[Bug 22674] New: Change wording of payments in the GUI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Bug ID: 22674 Summary: Change wording of payments in the GUI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- For payments we currently have: [%- CASE 'Pay' -%]<span>Payment, thanks</span> [%- CASE 'Pay00' -%]<span>Payment, thanks (cash via SIP2)</span> [%- CASE 'Pay01' -%]<span>Payment, thanks (VISA via SIP2)</span> [%- CASE 'Pay02' -%]<span>Payment, thanks (credit card via SIP2)</span> After a quick survey on IRC I Propose to remove ", thanks". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87688&action=edit Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87688|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87707&action=edit Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Do we also need a database update to fix existing entries? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I checked my database and couldn't find any entries with 'Payment, thanks', my descriptions on payments were empty. I imagine maybe some old databases might have them still, but I don't have an example line to test with - it would be many versions ago. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87707|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88191&action=edit Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Needs a minor rebase please -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88191|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88469&action=edit Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Nick Clemens from comment #6)
Needs a minor rebase please
Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Josef Moravec from comment #8)
(In reply to Nick Clemens from comment #6)
Needs a minor rebase please
Done
Thank you, Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org