[Bug 8781] New: Access to Transfer page while "independent branches" is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Priority: P5 - low Change sponsored?: --- Bug ID: 8781 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: adrien.saurat@biblibre.com Summary: Access to Transfer page while "independent branches" is on Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha With the system preference "IndependantBranches" set to On, only a superlibrarian can make transfers. The page is still displayed for others librarians with circulation rights, but they can only chose their own library as a destination, making the page useless for them. The link to this page could be hidden in such cases. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 12298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12298&action=edit proposed patch TEST PLAN : It's about testing the display of the "Transfer" link on "circulation-home.pl". The link needs to appear if IndependantBranches is off or if the user is a superlibrarian. 1) IndependantBranches = Off, user is superlibrarian : link appears 2) IndependantBranches = Off, user is not superlibrarian : link appears 3) IndependantBranches = On, user is superlibrarian : link appears 4) IndependantBranches = On, user is not superlibrarian : link does not appear -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #2 from Melia Meggs <melia@bywatersolutions.com> --- Thanks for the test plan! I followed steps #1-4, and everything behaves as you described. I am signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12298|0 |1 is obsolete| | --- Comment #3 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13321&action=edit [Signed off] Bug 8781: hiding of transfer page when it's useless The transfer page is only useful when the system preference "IndependantBranches" is Off of when the user is a superlibrarian. Otherwise it can be hidden. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13321|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13820&action=edit [SIGNED-OFF] Bug 8781: hiding of transfer page when it's useless The transfer page is only useful when the system preference "IndependantBranches" is Off of when the user is a superlibrarian. Otherwise it can be hidden. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. TEST PLAN : It's about testing the display of the "Transfer" link on "circulation-home.pl". The link needs to appear if IndependantBranches is off or if the user is a superlibrarian. 1) IndependantBranches = Off, user is superlibrarian : link appears 2) IndependantBranches = Off, user is not superlibrarian : link appears 3) IndependantBranches = On, user is superlibrarian : link appears 4) IndependantBranches = On, user is not superlibrarian : link does not appear -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Trivial patch QA Contact| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Passed QA. Note: The page is still accessible (and not useful) when indybranches is ON and user is not superlibrarian. But this is an improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|master |3.8 Severity|enhancement |minor --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Bug fix really, pushed to 3.10.x and 3.8.x, will be in 3.10.1 and 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org