[Bug 9123] New: Authorities search ordered by authid does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Bug ID: 9123 Summary: Authorities search ordered by authid does not work Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com CC: m.de.rooy@rijksmuseum.nl In C4::AuthoritiesMarc::SearchAuthorities : Search can be sorted by authid ascending or descending. This sort is integrated in PQF query with attribute 7. The bug is that default sorting with attribute 7 is alphabetic. To use a numerical sort, attribute 7 must be combined with attribute 4=109. See http://www.indexdata.com/zebra/doc/querymodel-zebra.html (doc of attribute 7). The sort by authid is use by Linker, but i provide a test plan on authorities search page, it is more easy : Test plan : ----------- - perform an authority search sorted by "Heading A-Z", for example on "Paul". - you get and URL ending with : cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=mainentry&and_or=and&operator=contains&value=paul&orderby=HeadingAsc - edit this URL to replace "HeadingAsc" by "AuthidAsc" or "AuthidDsc" - refresh page - you get a table of authorities - look at "Details" of each line, it is a hyperlink ending with authid of authority Without patch, you get an odd order (order does not depend on authid length). With patch, you get a correct numerical order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13572&action=edit Proposed patch Proposed patch. Also adds numerical indexing (:n) of Local-Number in Zebra config. To test : - apply patch - reindex all Zebra authorities database - test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Will be testing this further. Came across some funny effects while paging through a larger result set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #2)
Came across some funny effects while paging through a larger result set. Submitted this under bug 9132.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13572|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13633&action=edit Signed patch for 9123 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with Zebra, marc21, grs1. Discovered that paging through auth search results does no longer work, but that is not related to these changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Should you also provide the ability to sort on this authid on the auth search form? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Suggest that QA is done by someone that can also test behavior with dom indexing. Just to make sure .. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #5)
Should you also provide the ability to sort on this authid on the auth search form?
I think so, do you think it can be usefull. Do we create a new enhancement ? -- You are receiving this mail because: You are watching all bug changes.
I think so, do you think it can be usefull. Do we create a new enhancement ? Alphabetical order is of course more useful, but if we include this search order, why hide it? You could open a new report for it in order to get this
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #7) patch get pushed sooner. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9150 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> ---
Alphabetical order is of course more useful, but if we include this search order, why hide it? You could open a new report for it in order to get this patch get pushed sooner. Create bug 9150
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13633|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13817&action=edit [SINGED-OFF] Bug 9123: Authorities search ordered by authid does not work Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with Zebra, marc21, grs1. Discovered that paging through auth search results does no longer work, but that is not related to these changes. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with Zebra, marc21, dom. All tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9123 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Bugfix pushed to 3.10.x and 3.8.x, will be in 3.10.1 and 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org