http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32058&action=edit Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect On the vendor search results page if some cells contain textual data the "item count" and "biblio count" columns will sort incorrectly. This patch sets an explicit numeric sort on these columns. In doing so this patch also changes the existing column sorting configuration to use table header cell classes instead of sorting based on index. This patch also corrects two instances of unescaped ampersands. To test, search for a vendor which has multiple baskets, at least one of which should contain canceled orders. Confirm that sorting by item count, biblio count, date, and closed all work correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32058|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32299&action=edit Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect On the vendor search results page if some cells contain textual data the "item count" and "biblio count" columns will sort incorrectly. This patch sets an explicit numeric sort on these columns. In doing so this patch also changes the existing column sorting configuration to use table header cell classes instead of sorting based on index. This patch also corrects two instances of unescaped ampersands. To test, search for a vendor which has multiple baskets, at least one of which should contain canceled orders. Confirm that sorting by item count, biblio count, date, and closed all work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32299|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32329&action=edit [PASSED QA] Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect On the vendor search results page if some cells contain textual data the "item count" and "biblio count" columns will sort incorrectly. This patch sets an explicit numeric sort on these columns. In doing so this patch also changes the existing column sorting configuration to use table header cell classes instead of sorting based on index. This patch also corrects two instances of unescaped ampersands. To test, search for a vendor which has multiple baskets, at least one of which should contain canceled orders. Confirm that sorting by item count, biblio count, date, and closed all work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I have not been able to see the sorting problem, but the patch causes no regression and everything seems to work nicely. Passes QA script and tests. http://bugs.koha-community.org/show_bug.cgi?id=12039 -- You are receiving this mail because: You are watching all bug changes.