[Bug 12132] New: Show guarantees in staff patron details too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Bug ID: 12132 Summary: Show guarantees in staff patron details too Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 27516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27516&action=edit Show guarantees in staff patron details too For some reason, guarantees are not shown in patron details, if the patron is a staffer. Attached patch fixes that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that's because patrons with the staff category are not supposed to have children currently - I think this probably needs more than a display fix. Would also require changing documentation etc. We favor that the staff account should not be identical with the personal account for a staff member, so keep it separate. But there is bug 6922 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think one of the things to check is that you can actually search for a guarantor that is a staff member - if you do it the other way around and create a 'child' first and then link it to the 'adult'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #3 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Katrin Fischer from comment #2)
I think one of the things to check is that you can actually search for a guarantor that is a staff member - if you do it the other way around and create a 'child' first and then link it to the 'adult'.
Yes, you can. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #4 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Katrin Fischer from comment #1)
I think that's because patrons with the staff category are not supposed to have children currently - I think this probably needs more than a display fix. Would also require changing documentation etc.
We favor that the staff account should not be identical with the personal account for a staff member, so keep it separate.
But there is bug 6922
The current behaviour is completely inconsistent: Change a patron's type from adult to staff, and their guarantees aren't showing up in the patron details. If the patron has guarantees, those should be shown, no matter what the patron's type is. If you use separate accounts for staff use and personal use, then your staff account shouldn't have the guarantees. But some other places might not do that kind of separation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #5 from paxed <pasi.kallinen@pttk.fi> --- To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron@veron.ch --- Comment #6 from Marc Véron <veron@veron.ch> --- This bug has a working patch but has status "NEW". Change status to "Needs signoff". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 27772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27772&action=edit [Signed-off] Show guarantees for staff patron details too. Staffers are adult borrowers. To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown. http://bugs.koha-community.org/show_bug.cgi?id=12132 Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27516|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28294&action=edit [PASSED QA] Show guarantees for staff patron details too. Staffers are adult borrowers. To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown. http://bugs.koha-community.org/show_bug.cgi?id=12132 Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27772|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28475&action=edit [COUNTER-PATCH] Bug 12132: display guarantees if a patron has them, regardless of category type If a patron has guarantees, always display them on the patron summary, even if the patron is of a type that ordinarily would have them. For example, at present you can cannot directly add a guarantee to a staff record the way you can do for an adult patron, but if you create a juvenile patron and add a guarantor to it, you can override that restriction. Note that this patch ignores whether that is strictly desirable behavior. To test: [1] Create a juvenile patron. While editing it, make a staff account a guarantor of the new patron. [2] View patron details for the staff account. Note that the juvenile patron is not displayed as a guarantee. [3] Apply this patch. [4] Refresh details for the staff account. The juvenile should now show up. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to paxed from comment #4)
If the patron has guarantees, those should be shown, no matter what the patron's type is.
That is reasonable. The submitted patch, however, does not actually do this; I have attached a counter-patch that does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28294|0 |1 is obsolete| | Attachment #28475|0 |1 is obsolete| | --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32787&action=edit [SIGNED-OFF] Bug 12132: display guarantees if a patron has them, regardless of category type If a patron has guarantees, always display them on the patron summary, even if the patron is of a type that ordinarily would have them. For example, at present you can cannot directly add a guarantee to a staff record the way you can do for an adult patron, but if you create a juvenile patron and add a guarantor to it, you can override that restriction. Note that this patch ignores whether that is strictly desirable behavior. To test: [1] Create a juvenile patron. While editing it, make a staff account a guarantor of the new patron. [2] View patron details for the staff account. Note that the juvenile patron is not displayed as a guarantee. [3] Apply this patch. [4] Refresh details for the staff account. The juvenile should now show up. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Frederic Demians <f.demians@tamil.fr> Galen patch works as described. The way it's implemented seems sensible. Whatever the reason why a patron has guarantes, it make sense to display them. So it's better to check the count of guarantes rather than the current patron type to decide to display guarantes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Just hope switching bug status directly from In discussion to Signed-off doesn't violate any rule. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32787|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32805&action=edit [PASSED QA] Bug 12132: display guarantees if a patron has them, regardless of category type If a patron has guarantees, always display them on the patron summary, even if the patron is of a type that ordinarily would have them. For example, at present you can cannot directly add a guarantee to a staff record the way you can do for an adult patron, but if you create a juvenile patron and add a guarantor to it, you can override that restriction. Note that this patch ignores whether that is strictly desirable behavior. To test: [1] Create a juvenile patron. While editing it, make a staff account a guarantor of the new patron. [2] View patron details for the staff account. Note that the juvenile patron is not displayed as a guarantee. [3] Apply this patch. [4] Refresh details for the staff account. The juvenile should now show up. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Frederic Demians <f.demians@tamil.fr> Galen patch works as described. The way it's implemented seems sensible. Whatever the reason why a patron has guarantes, it make sense to display them. So it's better to check the count of guarantes rather than the current patron type to decide to display guarantes. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, small change, no regressions found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks, Galen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org