[Bug 11283] New: Restriction type is not translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Bug ID: 11283 Summary: Restriction type is not translatable Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The new restrictions system has different types: MANUAL, OVERDUES and FINES. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2720 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23081&action=edit Bug 11283 - Restriction type is not translatable The new restrictions system has different types: MANUAL, OVERDUES and SUSPENSION. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. Test Plan: 1) Create a patron with one of each type of restriction 2) Apply this patch 3) Note you see the type with only the first letter capitialized, this indicates you are seeing the translatable string -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23081|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23117&action=edit [SIGNED OFF] Bug 11283 - Restriction type is not translatable The new restrictions system has different types: MANUAL, OVERDUES and SUSPENSION. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. Test Plan: 1) Create a patron with one of each type of restriction 2) Apply this patch 3) Note you see the type with only the first letter capitialized, this indicates you are seeing the translatable string Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Strings now appear in updated po files: msgid "%s %s Manual %s Overdues %s Suspension %s " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23117|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23189&action=edit Bug 11283 - Restriction type is not translatable The new restrictions system has different types: MANUAL, OVERDUES and SUSPENSION. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. Test Plan: 1) Create a patron with one of each type of restriction 2) Apply this patch 3) Note you see the type with only the first letter capitialized, this indicates you are seeing the translatable string Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Strings now appear in updated po files: msgid "%s %s Manual %s Overdues %s Suspension %s " Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch Depends on| |2720 Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org