http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23156|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 23159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23159&action=edit Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly Detail page tabs are not displayed properly because JavaScript is broken in French. This is due to _(' JS string construction used in place of _(". This patch fixes: - opac-detail.tt page - xt/single_quotes to test bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested by applying the patch, running translate update, then translate install. Saw no JavaScript error on the French detail page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23159|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23183&action=edit [PASSED QA] Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly Detail page tabs are not displayed properly because JavaScript is broken in French. This is due to _(' JS string construction used in place of _(". This patch fixes: - opac-detail.tt page - xt/single_quotes to test bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested by applying the patch, running translate update, then translate install. Saw no JavaScript error on the French detail page. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Switches from single to double quotes for translatatable strings. Unit tests for xt/single_quotes passes now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 PS : 2 single quotes remains, but they are not in a translated text : data.rating_total + ' ' + _("votes") -- You are receiving this mail because: You are watching all bug changes.