[Bug 8260] New: Routing List Ranking Needs Re-order After Patron Delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Priority: P5 - low Change sponsored?: --- Bug ID: 8260 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: Routing List Ranking Needs Re-order After Patron Delete Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: Serials Product: Koha Currently, deleting a patron will create a missing value in the ranking of members in a routing list. For instance, the ranking will go 1, 2, 3, 5 in the database when the patron ranked at #4 is deleted. This causes the intranet to display these rankings as 1, 2, 3, 1, since 5 is not a valid option due to there only being 4 entries in the database. I've written up a little re-order function based on the reorder_members function, which just re-orders all the members for that routing list every time routing.pl or routing-preview.pl are called. It might be more ideal to only run it if errors are detected, but that error detection would require more code that might just add more bulk. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Actually, I'm not currently running it for routing-preview.pl, since there are no numbers displayed. (In reply to comment #0)
Currently, deleting a patron will create a missing value in the ranking of members in a routing list. For instance, the ranking will go 1, 2, 3, 5 in the database when the patron ranked at #4 is deleted.
This causes the intranet to display these rankings as 1, 2, 3, 1, since 5 is not a valid option due to there only being 4 entries in the database.
I've written up a little re-order function based on the reorder_members function, which just re-orders all the members for that routing list every time routing.pl or routing-preview.pl are called.
It might be more ideal to only run it if errors are detected, but that error detection would require more code that might just add more bulk.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 10342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10342&action=edit Force re-order of routing list rankings on page load -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- This works well, and mimics the behaviour that happens with the reserves that are set if you have system preference set to create reserves for routing lists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- The only problem is that it is called unconditionally on every load of the page, even if we just reranked the list by deleting a member, or changing the rank. For that reason i'm hesitant to sign off, does anyone else have a better idea on how to solve this? I'm thinking fixing the borrower delete to not delete borrowers who are in a routing list might be better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #4)
The only problem is that it is called unconditionally on every load of the page, even if we just reranked the list by deleting a member, or changing the rank.
For that reason i'm hesitant to sign off, does anyone else have a better idea on how to solve this? I'm thinking fixing the borrower delete to not delete borrowers who are in a routing list might be better.
I agree with the problem, but I think it's still a good idea to be able to delete borrowers who are in routing lists. I think it would be a bit too finicky to have to go into each routing list and remove them before doing a complete delete. Why don't we call the new reorder function on patron delete? I see that there is already a function for handling patron deletes in regards to Lists/VirtualShelves. That probably makes the most sense. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to David Cook from comment #5)
Why don't we call the new reorder function on patron delete? I see that there is already a function for handling patron deletes in regards to Lists/VirtualShelves. That probably makes the most sense.
I prefer this option. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org