[Bug 7032] New: can select multiple layouts to edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Bug #: 7032 Summary: can select multiple layouts to edit Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: cgi-bin/koha/labels/label-manage.pl?label_element=layo ut OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Label printing AssignedTo: cnighswonger@foundations.edu ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org I've noticed that I am allowed to check off more than one layout in the list of layouts. It's not a big deal, since the system tells me to choose only one layout to edit, but it seems like those check boxes should be exclusive (I can't come up with the right term for it) -- so if I check one box and then check another box, the initial check should go away when I check box #2 or they should be radio buttons instead. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7386 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8776&action=edit Bug 7032 - can select multiple layouts to edit Switch from checkboxes to radio buttons. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #1)
Created attachment 8776 [details] Bug 7032 - can select multiple layouts to edit
Switch from checkboxes to radio buttons.
Personally I'd like to see these stay check boxes for two reasons: 1. This allows for multiple template deletes which was the original intent though it dropped through the cracks and did not get implemented. 2. Visual coordination and consistency with the rest of the label/patron creation interface. It should be just a matter of adjusting the JS trapping as the multiple delete code is already in the back-end IIRC (its been a while since I looked at it). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 --- Comment #3 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #2)
It should be just a matter of adjusting the JS trapping as the multiple delete code is already in the back-end IIRC (its been a while since I looked at it).
Actually it will also require a few moments in labels/label-manage.pl to mod the delete option to take multiple params and loop through them, deleting each one. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=labels/label-manag... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- I would agree, but since this system does not support editing multiple templates at once, that would leave this issue unresolved. The best resolution would be to use "Edit" links for each row and leave the check-boxes for deleting only, but this is made practically impossible be the hideous way this system builds the tables. It would need a huge amount of rewriting to do so. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 --- Comment #5 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #4)
I would agree, but since this system does not support editing multiple templates at once, that would leave this issue unresolved. The best resolution would be to use "Edit" links for each row and leave the check-boxes for deleting only, but this is made practically impossible be the hideous way this system builds the tables. It would need a huge amount of rewriting to do so.
I must agree with your analysis of how the tables are built. It was quite a chore getting it written that poorly, I assure you. ;-) At any rate, my objection to the proposed fix stands for the reasons stated. I'll defer to QA and the RM, however, as I don't have time to fix it myself. FWIW, there are several libraries who use this feature and none has complained of this "problem." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8788&action=edit Mockup of an alternate layout
Personally I'd like to see these stay check boxes for two reasons:
1. This allows for multiple template deletes which was the original intent though it dropped through the cracks and did not get implemented.
This interface came up during our discussions at Hackfest of inconsistencies in Koha's interfaces. The most common pattern is for tables like this to have edit and/or delete links in each row for single-item operations. The column of checkboxes would then be used for bulk-delete operations. I've attached a mockup of what I'm thinking of. I think it is worthwhile to preserve the option of multiple deletions, but we shouldn't let that stop us from dealing with the ambiguity of having it appear as if one can select multiple lines to edit. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 --- Comment #7 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #6)
Created attachment 8788 [details] Mockup of an alternate layout
Personally I'd like to see these stay check boxes for two reasons:
1. This allows for multiple template deletes which was the original intent though it dropped through the cracks and did not get implemented.
This interface came up during our discussions at Hackfest of inconsistencies in Koha's interfaces. The most common pattern is for tables like this to have edit and/or delete links in each row for single-item operations. The column of checkboxes would then be used for bulk-delete operations. I've attached a mockup of what I'm thinking of. I think it is worthwhile to preserve the option of multiple deletions, but we shouldn't let that stop us from dealing with the ambiguity of having it appear as if one can select multiple lines to edit.
That looks nice. I'm not sure how hard it would be to implement, though. What Kyle says about the table-building code is very true... its ugly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- I approve of Owen's suggestion - I'd like to see them consistent with other tables. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org