[Bug 40105] New: Patrons cannot add notes when creating an ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Bug ID: 40105 Summary: Patrons cannot add notes when creating an ILL Change sponsored?: --- Product: Koha Version: Main Hardware: PC OS: Mac OS Status: NEW Severity: enhancement Priority: P1 - high Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: ephetteplace@cca.edu CC: pedro.amorim@openfifth.co.uk, tomascohen@gmail.com While there is a notesopac field for ILL requests, it's not shown on the patron-facing form to create an ILL request (/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard) for any type of resource. Patrons can edit request notes by going to their dashboard > ILL requests > View an existing request > Notes but that is difficult to discover and an extra step for every request. We'd like patrons to be able to add notes to any request during the creation process. I tried to work around this with OpacUserJS by adding a <textarea> with name="notesopac" but that did not work; the request is created successfully, but Koha discards the note. -- You are receiving this mail because: You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ephetteplace@cca.edu |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 184523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184523&action=edit Bug 40105: Patrons cannot add notes when creating an ILL Testing plan: - Enable the ILLModule system preference - Sign into the OPAC and make an ILL request at /cgi-bin/koha/opac-illrequests.pl - Note there's no option to specify notes - Apply the patch and restart services - Make another ILL request - Use the new notes field - View the request and note that the notes value was saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Eric Phetteplace <ephetteplace@cca.edu> --- Made a patch for this so it can be tried out but maybe it should have tests? I also asked in mattermost about whether to do the notes as its own distinct fieldset like custom fields (the patch's approach) or as something more incorporated into the other metadata fields but got not responses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@openfifth.c | |o.uk --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi Eric, I think this makes sense, but would it be reasonable to have a system preference to enable/disable this? i.e. Koha systems that don't require it wouldn't have a new, possibly redundant (for them), input on the form. Or, alternatively, make it an expandable input that shows upon clicking a always visible 'Want to add some notes to your request?" link. Adding others for additional thoughts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #4 from Eric Phetteplace <ephetteplace@cca.edu> --- Hi Pedro, I don't think a system preference for this makes sense for several reasons. One can always hide the opacnotes input with IntranetUserCSS if it's unwanted. Also, one can use a different ILL backend which provides different fields. There are a wide variety of metadata fields and resource types available in the Standard backend, but there are no analogous system preferences to control them (e.g. to show the DOI field, the conference resource type, etc.). Notes can already be added under the single ILL view, just not at the time of creation, yet there's no existing system preference to control them. A system preference seems like overkill to me and inconsistent with the way the rest of the ILL module has been designed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184523|0 |1 is obsolete| | --- Comment #5 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 185354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185354&action=edit Bug 40105: Patrons cannot add notes when creating an ILL Testing plan: - Enable the ILLModule system preference - Sign into the OPAC and make an ILL request at /cgi-bin/koha/opac-illrequests.pl - Note there's no option to specify notes - Apply the patch and restart services - Make another ILL request - Use the new notes field - View the request and note that the notes value was saved Sponsored-By: California College of the Arts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Eric Phetteplace <ephetteplace@cca.edu> --- I have added a test to this, I'm not sure how necessary it is but why not. Changing to needs signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described. I'm only failing QA because on the last step when you view the request the note renders as an input, which implies it's editable when it's not. It should just need a small change on opac-illrequests.tt so that it's not an input when you are viewing a request that's already created. Something like this on line 209: <label for="notesopac">Notes:</label> - [% IF !request.completed %] + [% IF !request.completed && !request.illrequest_id %] <textarea id="notesopac" name="notesopac" rows="5" cols="50">[% request.notesopac | html %]</textarea> [% ELSE %] [% request.notesopac | html %] [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Eric Phetteplace <ephetteplace@cca.edu> --- I had to compare with how the form currently works but I think my patch preserves the current behavior, where patrons can modify the note (but only the note) of requests that have not been completed yet. Try viewing a new, incomplete ILL as a patron. The notes field is a <textarea> and the "submit modifications" button updates the notes. If you add an extra condition like `!request.illrequest_id` so the notes isn't an input then there are no editable fields but the "submit modifications" button is still there; clicking it erases any note added when the ILL was created. So I *think* the current patch makes sense but I'm open to discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185354|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 185942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185942&action=edit Bug 40105: Patrons cannot add notes when creating an ILL Testing plan: - Enable the ILLModule system preference - Sign into the OPAC and make an ILL request at /cgi-bin/koha/opac-illrequests.pl - Note there's no option to specify notes - Apply the patch and restart services - Make another ILL request - Use the new notes field - View the request and note that the notes value was saved Sponsored-By: California College of the Arts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Ok, that makes sense. I wasn't familiar with using ill requests and didn't realize that the request notes should still be editable on that screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact| |lisette@bywatersolutions.co | |m --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- hmm I wonder if that's not how the OPAC note should work. I would think that's more like the OPAC note in a patron or an item, where the patron can see but not edit. I think a separate patron note might be better and not have the OPAC note be better? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #12 from Lisette Scheer <lisette@bywatersolutions.com> --- Purchase suggestions you can add a note at creation but you can't edit anything except cancelling the request. It seems like that makes more sense here, though I'm somewhat worried about removing that functionality if people are using it that way. Especially with the lack of proper logging on ILL's I'm concerned about this use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #13 from Eric Phetteplace <ephetteplace@cca.edu> --- I wouldn't mind that behavior—notes can be created initially not modified—but the main thing for us is we really need the note on creation for things like acceptable editions/formats, not needed by, miscellaneous metadata, etc. The patron cannot modify any of the other request details so note being immutable is consistent, but it's also a bigger behavior change. For instance, the ILL_REQUEST_MODIFIED notice would no longer have a purpose, as it's not possible for the patron to modify the request. For what it's worth, the opac note cannot be modified after the request is marked "completed". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189506&action=edit Bug 40105: (QA follow-up): Have a 'additional information' section This will encompass the 'Notes' field plus custom fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189507&action=edit before_after_QA_patch Hi all, I think this is ready for QA but I have a suggestion follow-up patch, please see attached screenshot for before and after. Please let me know if you agree. Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.graham4@herts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #16 from Eric Phetteplace <ephetteplace@cca.edu> --- I like the "additional information" section! These fields are both global, usable regardless of request type, so separating them from the metadata makes sense to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185942|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189515&action=edit Bug 40105: Patrons cannot add notes when creating an ILL Testing plan: - Enable the ILLModule system preference - Sign into the OPAC and make an ILL request at /cgi-bin/koha/opac-illrequests.pl - Note there's no option to specify notes - Apply the patch and restart services - Make another ILL request - Use the new notes field - View the request and note that the notes value was saved Sponsored-By: California College of the Arts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189506|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189516&action=edit Bug 40105: (QA follow-up): Have a 'additional information' section This will encompass the 'Notes' field plus custom fields. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Eric Phetteplace from comment #16)
I like the "additional information" section! These fields are both global, usable regardless of request type, so separating them from the metadata makes sense to me.
That's great, thank you Eric. I've added my SO lines, over to you Lisette! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |California College of the list of Sponsors| |Arts Status|Signed Off |Passed QA --- Comment #20 from Lisette Scheer <lisette@bywatersolutions.com> --- Worked well, one test file failed a tidy test, but it looks like it's consistent with other files, so I'll let Lucas decide if it needs to be fixed or if the newest tidy script is tidying something oddly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189516|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #21 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 193159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193159&action=edit Bug 40105: Patrons cannot add notes when creating an ILL Testing plan: - Enable the ILLModule system preference - Sign into the OPAC and make an ILL request at /cgi-bin/koha/opac-illrequests.pl - Note there's no option to specify notes - Apply the patch and restart services - Make another ILL request - Use the new notes field - View the request and note that the notes value was saved Sponsored-By: California College of the Arts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #22 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 193160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193160&action=edit Bug 40105: (QA follow-up): Have a 'additional information' section This will encompass the 'Notes' field plus custom fields. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 --- Comment #24 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40105 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #25 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org