[Bug 18479] New: Holds 'Placed on' column in opac-user.pl not sorting correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Bug ID: 18479 Summary: Holds 'Placed on' column in opac-user.pl not sorting correctly Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - place three holds for a patron 2 - in db set reservedates to "2017-04-19","2016-04-20","2017-04-21" 3 - Sign in to opac 4 - View holds tab 5 - Sort by 'placed on' 6 - Note 2016 date is in the middle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62590&action=edit Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Two columns in the user's holds table in the OPAC do not sort correctly because they are not marked up correctly to enable date sorting: 'Placed on' and 'Expires on.' This patch corrects it. This patch also removes a stray </td> which was causing validation errors. To test, apply the patch and log into the OPAC with an account which has multiple holds with differnt hold dates and expiration dates. Confirm that sorting on these columns works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62590|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 62728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62728&action=edit [SIGNED-OFF] Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Two columns in the user's holds table in the OPAC do not sort correctly because they are not marked up correctly to enable date sorting: 'Placed on' and 'Expires on.' This patch corrects it. This patch also removes a stray </td> which was causing validation errors. To test, apply the patch and log into the OPAC with an account which has multiple holds with differnt hold dates and expiration dates. Confirm that sorting on these columns works correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62728|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62731&action=edit Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Two columns in the user's holds table in the OPAC do not sort correctly because they are not marked up correctly to enable date sorting: 'Placed on' and 'Expires on.' This patch corrects it. This patch also removes a stray </td> which was causing validation errors. To test, apply the patch and log into the OPAC with an account which has multiple holds with differnt hold dates and expiration dates. Confirm that sorting on these columns works correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply cleanly to 16.11.x - please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 months, no rebase. Closing. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org