https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62511&action=edit Bug 18467 - Error calling count on undefined bib in basket.pl if order cancelled and record deleted To test: 1 - Create a basket 2 - Order a bib 3 - Cancel order and delete record 4 - You cannot view basket 5 - Apply patch 6 - View basket 7 - There should not be an error r calling count on undefined bib in basket.pl if order cancelled and record deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think I have a counter-patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, Reading the code I think it's important to clearly highlight this specific case. Moreover if the bibliographic record does no longer exist, we can skip the whole block. Let me know if you agree. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62537|0 |1 is obsolete| | --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62570&action=edit Bug 18467: Handle orders with deleted biblio when viewing a basket If the bibliographic record of an order has been removed, $order->{bibionumber} is undefined. We need to handle this specific case correctly. To test: 1 - Create a basket 2 - Order a bib 3 - Cancel order and delete record 4 - You cannot view basket 5 - Apply patch 6 - View basket 7 - There should not be an error r calling count on undefined bib in basket.pl if order cancelled and record deleted -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62570|0 |1 is obsolete| | --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62571&action=edit Bug 18467: Handle orders with deleted biblio when viewing a basket If the bibliographic record of an order has been removed, $order->{bibionumber} is undefined. We need to handle this specific case correctly. To test: 1 - Create a basket 2 - Order a bib 3 - Cancel order and delete record 4 - You cannot view basket 5 - Apply patch 6 - View basket 7 - There should not be an error r calling count on undefined bib in basket.pl if order cancelled and record deleted Followed test plan, works as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62571|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62654&action=edit Bug 18467: Handle orders with deleted biblio when viewing a basket If the bibliographic record of an order has been removed, $order->{bibionumber} is undefined. We need to handle this specific case correctly. To test: 1 - Create a basket 2 - Order a bib 3 - Cancel order and delete record 4 - You cannot view basket 5 - Apply patch 6 - View basket 7 - There should not be an error r calling count on undefined bib in basket.pl if order cancelled and record deleted Followed test plan, works as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This doesn't apply cleanly on 16.11.x, please rebase/comment if it's needed there. -- You are receiving this mail because: You are watching all bug changes.