[Bug 11006] New: Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Bug ID: 11006 Summary: Useless column totalamount in aqorders table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org In Schemaspy, column totalamount is reported as "not used? always NULL". "grep -r totalamount *" give this result, so I suppose it is true : blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql: `totalamount` decimal(28,6) default NULL, -- not used? always NULL blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:totalamount decimal(28,6) default NULL, installer/data/mysql/kohastructure.sql: `totalamount` decimal(28,6) default NULL, -- not used? always NULL installer/data/Pg/kohastructure.sql:totalamount decimal(28,6) default NULL, t/db_dependent/Acquisition.t: totalamount I propose the deletion of this column. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38320&action=edit Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- # git grep totalamount Koha/Schema/Result/Aqorder.pm:=head2 totalamount Koha/Schema/Result/Aqorder.pm: "totalamount", Should that still appear? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #2)
# git grep totalamount Koha/Schema/Result/Aqorder.pm:=head2 totalamount Koha/Schema/Result/Aqorder.pm: "totalamount",
Should that still appear?
Yes, I don't update the schema when not needed to test. The RM uploads it when needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 38393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38393&action=edit [Signed-off] Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38393|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38402&action=edit [PASSED QA] Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! tatus: Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39186&action=edit Bug 11006: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org