[Bug 14132] New: suggestions table is missing indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bug ID: 14132 Summary: suggestions table is missing indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Suggestions table is missing some indexes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 38806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38806&action=edit Bug 14132 - suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #2 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 38807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38807&action=edit Bug 14132 - suggestions table is missing indexes - atomicupdate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Should this have the status "Needs sign-off"? For the second patch: Instead of ALTER TABLE `suggestions`... maybe better: ALTER IGNORE TABLE `suggestions`... http://wiki.koha-community.org/wiki/Database_updates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14053 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Marc Véron from comment #3)
Should this have the status "Needs sign-off"? Indeed. I've used git bz without -e.
For the second patch: Instead of ALTER TABLE `suggestions`... maybe better: ALTER IGNORE TABLE `suggestions`...
Ok thanks. I did not knew that INGORE can be used with ALTER TABLE. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38806|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 38841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38841&action=edit Bug 14132 - suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38807|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 38842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38842&action=edit Bug 14132 - suggestions table is missing indexes - atomicupdate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Ready for signoff. I've spitted each alter table in a unique line because if one key already exists the all line fails. If the key alreeady exists, it will still return an error even with ALTER IGNORE. Looks like the is only useful for unique keys. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38841|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38937&action=edit [SIGNED-OFF] Bug 14132: suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38842|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38938&action=edit [SIGNED-OFF] Bug 14132: suggestions table is missing indexes - atomicupdate Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Sorry but removed backticks No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38937|0 |1 is obsolete| | Attachment #38938|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38975&action=edit [PASSED QA] Bug 14132: suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38976&action=edit [PASSED QA] Bug 14132: suggestions table is missing indexes - atomicupdate Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Sorry but removed backticks No errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org