[Bug 16531] New: Circ overdues report is showing an empty table if no overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Bug ID: 16531 Summary: Circ overdues report is showing an empty table if no overdues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 51556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51556&action=edit Empty table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 51557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51557&action=edit Bug 16531: Circ overdue report is showing an empty table if no overdues To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Apply patch and refresh page 5) Notice empty table is no longer showing and page prompts you to choose filters to see results 6) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 7) Refresh overdue report page 8) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think we can improve this page by giving the user more information about why nothing is displaying. I can think of two cases to plan for: 1. Nothing displays because there are no overdues. By default the overdue report show anything which is overdue, with no filters applied by default. If we know we're showing the unfiltered view, we can show a message which says "There are no overdues." 2. Nothing displays because the user has applied a filter to the results. ( "[% IF ( isfiltered ) %]" ). In this case we display a message which says something like, "There are no overdues matching your search." This would also allow us to display a link to "Reset filter," which is shown without this patch but isn't with the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51557|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 51729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51729&action=edit Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Apply patch and refresh page 5) Notice empty table is no longer showing and page says "There are no overdues" 6) Apply a filter to search 7) Page now says "There are no overdues matching your search" with a link to reset filter. 8) Click Reset filter -> confirm any filters you applied are cleared. 9) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 10) Refresh overdue report page 11) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51729|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51769&action=edit [SIGNED-OFF] Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Apply patch and refresh page 5) Notice empty table is no longer showing and page says "There are no overdues" 6) Apply a filter to search 7) Page now says "There are no overdues matching your search" with a link to reset filter. 8) Click Reset filter -> confirm any filters you applied are cleared. 9) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 10) Refresh overdue report page 11) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- With this patch, the noreport variable becomes useless. However it seems that it's useful in case of FilterBeforeOverdueReport is set. Please double check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51769|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 53059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53059&action=edit Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53059|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53322&action=edit [SIGNED-OFF] Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53322|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53434&action=edit Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org