https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53230|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53231&action=edit Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53231|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 53250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53250&action=edit Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I think the addition of the "fa-ban" icon is unnecessary. At this time we use icons for actions (links, buttons), but not as decoration for other page elements. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Keep signed-off since just removed a icon decoration -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53250|0 |1 is obsolete| | Attachment #53266|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53281&action=edit [PASSED QA] Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.