[Bug 41995] New: Autocomplete for syspref search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Bug ID: 41995 Summary: Autocomplete for syspref search Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 41994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41994 [Bug 41994] REST API route to list system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194492&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #2 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- This is a great idea. :) I tested this in a sandbox and the autocomplete works but when you select one of the recommendations the search does not work. It does not do the search with the selected system preference name. The next one is not a show stopper but should we add the autocomplete to the System preferences search box also? See the screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #3 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Created attachment 194498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194498&action=edit Screenshot of System preferences search box -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Anneli Österman from comment #2)
The next one is not a show stopper but should we add the autocomplete to the System preferences search box also? See the screenshot.
I had the same thought -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194501&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194507&action=edit Bug 41995: Add autocomplete on the admin home page Patch from commit 04e7c46 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Anneli Österman from comment #2)
I tested this in a sandbox and the autocomplete works but when you select one of the recommendations the search does not work. It does not do the search with the selected system preference name.
Oops yes sorry, I made a mistake when I clean the code for submission.
The next one is not a show stopper but should we add the autocomplete to the System preferences search box also? See the screenshot.
Done in the second patch. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194501|0 |1 is obsolete| | --- Comment #8 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194508&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194507|0 |1 is obsolete| | --- Comment #9 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194509&action=edit Bug 41995: Add autocomplete on the admin home page Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 [Bug 42093] Use the REST API and kohaTable to list and search sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Lisette Scheer <lisette@bywatersolutions.com> --- It's not working for me. When I type at least 3 letters into a box, it shows a list of 'undefined' and the number of them doesn't change even if I type a whole system pref. I tried in both Chrome and Firefox. in the plack lock it looks like this is the GET: GET /intranet/mainpage.pl?pref=[object%20Object] but the object should be the search term. Additionally tests are failing: [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc FAIL forbidden_patterns forbidden pattern: <script> elements must have a "src" or "nonce" attribute (line 101) [PASS] koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt FAIL forbidden_patterns forbidden pattern: <script> elements must have a "src" or "nonce" attribute (line 330) [PASS] koha-tmpl/intranet-tmpl/prog/js/fetch/system-preferences-api-client.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43161 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lisette Scheer from comment #10)
It's not working for me.
Terrible conflict with bug 37762... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43161 [Bug 43161] ILL module should have a /config endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194508|0 |1 is obsolete| | Attachment #194509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202474&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202475&action=edit Bug 41995: Add autocomplete on the admin home page Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202476&action=edit Bug 41995: Fix conflict with bug 37762 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202477&action=edit Bug 41995: Remove extra JS code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202478&action=edit Bug 41995: Add nonce -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202474|0 |1 is obsolete| | Attachment #202475|0 |1 is obsolete| | Attachment #202476|0 |1 is obsolete| | Attachment #202477|0 |1 is obsolete| | Attachment #202478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202507&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202508&action=edit Bug 41995: Add autocomplete on the admin home page Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202509&action=edit Bug 41995: Fix conflict with bug 37762 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202510&action=edit Bug 41995: Remove extra JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202511&action=edit Bug 41995: Add nonce Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Bug 41995 depends on bug 43161, which changed state. Bug 43161 Summary: ILL module should have a /config endpoint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43161 What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Lisette Scheer <lisette@bywatersolutions.com> --- Works great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202507|0 |1 is obsolete| | Attachment #202508|0 |1 is obsolete| | Attachment #202509|0 |1 is obsolete| | Attachment #202510|0 |1 is obsolete| | Attachment #202511|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #23 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 202692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202692&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202692|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #24 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 202693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202693&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #25 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 202694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202694&action=edit Bug 41995: Add autocomplete on the admin home page Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #26 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 202695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202695&action=edit Bug 41995: Fix conflict with bug 37762 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #27 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 202696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202696&action=edit Bug 41995: Remove extra JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #28 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 202697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202697&action=edit Bug 41995: Add nonce Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org