[Bug 41995] New: Autocomplete for syspref search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Bug ID: 41995 Summary: Autocomplete for syspref search Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 41994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41994 [Bug 41994] REST API route to list system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194492&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #2 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- This is a great idea. :) I tested this in a sandbox and the autocomplete works but when you select one of the recommendations the search does not work. It does not do the search with the selected system preference name. The next one is not a show stopper but should we add the autocomplete to the System preferences search box also? See the screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #3 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Created attachment 194498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194498&action=edit Screenshot of System preferences search box -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Anneli Österman from comment #2)
The next one is not a show stopper but should we add the autocomplete to the System preferences search box also? See the screenshot.
I had the same thought -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194501&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194507&action=edit Bug 41995: Add autocomplete on the admin home page Patch from commit 04e7c46 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Anneli Österman from comment #2)
I tested this in a sandbox and the autocomplete works but when you select one of the recommendations the search does not work. It does not do the search with the selected system preference name.
Oops yes sorry, I made a mistake when I clean the code for submission.
The next one is not a show stopper but should we add the autocomplete to the System preferences search box also? See the screenshot.
Done in the second patch. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194501|0 |1 is obsolete| | --- Comment #8 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194508&action=edit Bug 41995: Autocomplete for syspref search This patch adds autocompletion to the syspref search in the header. Test plan: 1. Go to the admin home page - /cgi-bin/koha/admin/admin-home.pl 2. In the header start typing the name of a syspref and notice that there is now autocompletion (you need at least 3 chars) 3. Select an entry and confirm that you are correctly redirected to the correct search result Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194507|0 |1 is obsolete| | --- Comment #9 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194509&action=edit Bug 41995: Add autocomplete on the admin home page Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 [Bug 42093] Use the REST API and kohaTable to list and search sysprefs -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org