[Bug 41996] New: Further improvements to EDIFACT error recording
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Bug ID: 41996 Summary: Further improvements to EDIFACT error recording Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Depends on: 38689 We've been running the updated edifact error handling code in production for a little while now and there's a few improvements we can make to further enhance and clarify the error reporting for debugging EDI flows. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 [Bug 38689] EDIFACT errors should log to a staff accessible location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194502&action=edit Bug 41996: Improve EDI invoice error messages for branch mismatches When EDI invoice processing fails to match an item to a branch, the error message now includes: - The ordernumber referenced in the invoice (RFF+LI segment) - The branches that order actually has items at - A hint that the ordernumber in the invoice may be incorrect Also adds a warning when an invoice line references an order that is already marked as complete, which can indicate the supplier sent the wrong ordernumber. These improvements help acquisitions staff and vendors quickly diagnose whether the problem is a supplier error (wrong RFF+LI value) rather than a Koha data issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194503&action=edit Bug 41996: Add invoicenumber column to edifact_errors table Adds an optional invoicenumber column to edifact_errors so that errors generated during invoice processing can be associated with the specific invoice they relate to, rather than only the EDI message as a whole. Message-level errors (e.g. unmatched vendor EAN) leave invoicenumber NULL, indicating they apply to the whole file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194504&action=edit Bug 41996: Schema Updates Patch from commit 1e48998 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194505&action=edit Bug 41996: Thread invoicenumber through EDI invoice error recording All errors generated during process_invoice and receipt_items now store the invoicenumber of the specific invoice being processed. This allows errors to be displayed only on the relevant invoice page rather than appearing on every invoice generated from the same EDI file. Also fixes two pre-existing spacing bugs in error message strings ("itemnumberis missing" and "barcode"for invoice line"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194506&action=edit Bug 41996: Filter EDI errors on invoice page by invoicenumber The invoice page previously fetched all edifact_errors for the EDI message, causing errors from unrelated invoice lines to appear on every invoice generated from the same EDI file. For example, one unmatched ordernumber in a file with 20 invoices would flag all 20 as having errors. Now only errors where invoicenumber matches the current invoice (or where invoicenumber is NULL, indicating a message-level error) are displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194502|0 |1 is obsolete| | Attachment #194503|0 |1 is obsolete| | Attachment #194504|0 |1 is obsolete| | Attachment #194505|0 |1 is obsolete| | Attachment #194506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198469&action=edit Bug 41996: Improve EDI invoice error messages for branch mismatches When EDI invoice processing fails to match an item to a branch, the error message now includes: - The ordernumber referenced in the invoice (RFF+LI segment) - The branches that order actually has items at - A hint that the ordernumber in the invoice may be incorrect Also adds a warning when an invoice line references an order that is already marked as complete, which can indicate the supplier sent the wrong ordernumber. These improvements help acquisitions staff and vendors quickly diagnose whether the problem is a supplier error (wrong RFF+LI value) rather than a Koha data issue. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198470&action=edit Bug 41996: Add invoicenumber column to edifact_errors table Adds an optional invoicenumber column to edifact_errors so that errors generated during invoice processing can be associated with the specific invoice they relate to, rather than only the EDI message as a whole. Message-level errors (e.g. unmatched vendor EAN) leave invoicenumber NULL, indicating they apply to the whole file. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198471&action=edit Bug 41996: Schema Updates Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198472&action=edit Bug 41996: Thread invoicenumber through EDI invoice error recording All errors generated during process_invoice and receipt_items now store the invoicenumber of the specific invoice being processed. This allows errors to be displayed only on the relevant invoice page rather than appearing on every invoice generated from the same EDI file. Also fixes two pre-existing spacing bugs in error message strings ("itemnumberis missing" and "barcode"for invoice line"). Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198473&action=edit Bug 41996: Filter EDI errors on invoice page by invoicenumber The invoice page previously fetched all edifact_errors for the EDI message, causing errors from unrelated invoice lines to appear on every invoice generated from the same EDI file. For example, one unmatched ordernumber in a file with 20 invoices would flag all 20 as having errors. Now only errors where invoicenumber matches the current invoice (or where invoicenumber is NULL, indicating a message-level error) are displayed. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198469|0 |1 is obsolete| | Attachment #198470|0 |1 is obsolete| | Attachment #198471|0 |1 is obsolete| | Attachment #198472|0 |1 is obsolete| | Attachment #198473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199909&action=edit Bug 41996: Improve EDI invoice error messages for branch mismatches When EDI invoice processing fails to match an item to a branch, the error message now includes: - The ordernumber referenced in the invoice (RFF+LI segment) - The branches that order actually has items at - A hint that the ordernumber in the invoice may be incorrect Also adds a warning when an invoice line references an order that is already marked as complete, which can indicate the supplier sent the wrong ordernumber. These improvements help acquisitions staff and vendors quickly diagnose whether the problem is a supplier error (wrong RFF+LI value) rather than a Koha data issue. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199910&action=edit Bug 41996: Add invoicenumber column to edifact_errors table Adds an optional invoicenumber column to edifact_errors so that errors generated during invoice processing can be associated with the specific invoice they relate to, rather than only the EDI message as a whole. Message-level errors (e.g. unmatched vendor EAN) leave invoicenumber NULL, indicating they apply to the whole file. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199911&action=edit Bug 41996: Schema Updates Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199912&action=edit Bug 41996: Thread invoicenumber through EDI invoice error recording All errors generated during process_invoice and receipt_items now store the invoicenumber of the specific invoice being processed. This allows errors to be displayed only on the relevant invoice page rather than appearing on every invoice generated from the same EDI file. Also fixes two pre-existing spacing bugs in error message strings ("itemnumberis missing" and "barcode"for invoice line"). Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199913&action=edit Bug 41996: Filter EDI errors on invoice page by invoicenumber The invoice page previously fetched all edifact_errors for the EDI message, causing errors from unrelated invoice lines to appear on every invoice generated from the same EDI file. For example, one unmatched ordernumber in a file with 20 invoices would flag all 20 as having errors. Now only errors where invoicenumber matches the current invoice (or where invoicenumber is NULL, indicating a message-level error) are displayed. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Just another rebase.. it would be really nice ot get this pushed this cycle so I don't have to backport it again next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|--- |Feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #17 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201189&action=edit Bug 41996: Improve EDI invoice error messages for branch mismatches When EDI invoice processing fails to match an item to a branch, the error message now includes: - The ordernumber referenced in the invoice (RFF+LI segment) - The branches that order actually has items at - A hint that the ordernumber in the invoice may be incorrect Also adds a warning when an invoice line references an order that is already marked as complete, which can indicate the supplier sent the wrong ordernumber. These improvements help acquisitions staff and vendors quickly diagnose whether the problem is a supplier error (wrong RFF+LI value) rather than a Koha data issue. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #18 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201190&action=edit Bug 41996: Add invoicenumber column to edifact_errors table Adds an optional invoicenumber column to edifact_errors so that errors generated during invoice processing can be associated with the specific invoice they relate to, rather than only the EDI message as a whole. Message-level errors (e.g. unmatched vendor EAN) leave invoicenumber NULL, indicating they apply to the whole file. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #19 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201191&action=edit Bug 41996: Schema Updates Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #20 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201192&action=edit Bug 41996: Thread invoicenumber through EDI invoice error recording All errors generated during process_invoice and receipt_items now store the invoicenumber of the specific invoice being processed. This allows errors to be displayed only on the relevant invoice page rather than appearing on every invoice generated from the same EDI file. Also fixes two pre-existing spacing bugs in error message strings ("itemnumberis missing" and "barcode"for invoice line"). Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #21 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201193&action=edit Bug 41996: Filter EDI errors on invoice page by invoicenumber The invoice page previously fetched all edifact_errors for the EDI message, causing errors from unrelated invoice lines to appear on every invoice generated from the same EDI file. For example, one unmatched ordernumber in a file with 20 invoices would flag all 20 as having errors. Now only errors where invoicenumber matches the current invoice (or where invoicenumber is NULL, indicating a message-level error) are displayed. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #22 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201194&action=edit Bug 41996: (QA follow-up) Update EDI.t for improved invoice error messages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #23 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201195&action=edit Bug 41996: (QA follow-up) Test that invoicenumber is recorded on EDI invoice errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 --- Comment #24 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201196&action=edit Bug 41996: (QA follow-up) Fix up atomic update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org