[Bug 37791] New: Fix terminology 'Biblio not found'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Bug ID: 37791 Summary: Fix terminology 'Biblio not found' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com There are places in which this text is generated. In particular, on the API spec. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |37686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 [Bug 37686] render_resource_not_found() and render_resource_deleted() misses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And also these here: return $c->render_resource_not_found("Biblio"); The should all be changed to read: Bibliographic record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #1)
And also these here: return $c->render_resource_not_found("Biblio");
The should all be changed to read: Bibliographic record
Yes, that is the main target for this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 170903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170903&action=edit Bug 37791: Fix 'Biblio not found' messages on the API This patch fixes some API-related cases of 'Biblio' terminology incorrectly used. To test: 1. Run: $ ktd --shell k$ git grep 'Biblio not found' => FAIL: Several occurences 2. Run: k$ git grep 'render_resource_not_found("Biblio")' => FAIL: Several occurences 3. Apply this patches 4. Repeat 1 and 2 => SUCCESS: No more occurences! 5. Run: k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 170904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170904&action=edit Bug 37791: (follow-up) Last occurence Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170903|0 |1 is obsolete| | --- Comment #5 from Olivier V <ovezina@inlibro.com> --- Created attachment 171493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171493&action=edit Bug 37791: Fix 'Biblio not found' messages on the API This patch fixes some API-related cases of 'Biblio' terminology incorrectly used. To test: 1. Run: $ ktd --shell k$ git grep 'Biblio not found' => FAIL: Several occurences 2. Run: k$ git grep 'render_resource_not_found("Biblio")' => FAIL: Several occurences 3. Apply this patches 4. Repeat 1 and 2 => SUCCESS: No more occurences! 5. Run: k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170904|0 |1 is obsolete| | --- Comment #6 from Olivier V <ovezina@inlibro.com> --- Created attachment 171494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171494&action=edit Bug 37791: (follow-up) Last occurence Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ovezina@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171493|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171617&action=edit Bug 37791: Fix 'Biblio not found' messages on the API This patch fixes some API-related cases of 'Biblio' terminology incorrectly used. To test: 1. Run: $ ktd --shell k$ git grep 'Biblio not found' => FAIL: Several occurences 2. Run: k$ git grep 'render_resource_not_found("Biblio")' => FAIL: Several occurences 3. Apply this patches 4. Repeat 1 and 2 => SUCCESS: No more occurences! 5. Run: k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171494|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171618&action=edit Bug 37791: (follow-up) Last occurence Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Bug 37791 depends on bug 37686, which changed state. Bug 37686 Summary: render_resource_not_found() and render_resource_deleted() misses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37791 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Missing deps for 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org