[Bug 37967] New: Allow auto renewals notices to be sent via phone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Bug ID: 37967 Summary: Allow auto renewals notices to be sent via phone Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171791&action=edit Bug 37967 - Allow auto renewals notices to be sent via phone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171791|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171792&action=edit Bug 37967 - Allow auto renewals notices to be sent via phone Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note you can now select phone for auto-renewals! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171792|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 171808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171808&action=edit Bug 37967 - Allow auto renewals notices to be sent via phone Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note you can now select phone for auto-renewals! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Set the PhoneNotification system preerence to 'Enable'. 2. View a patron's details (the Details section) 3. Note that there is now a phone column in the 'Patron messaging preferences' section, but for 'Auto renewal' there is no checkbox. 4. Apply the patch. 5. Update the database: updatedatabase 6. Restart everything: restart_all 7. Refresh the page. 8. If you edit the patron's messaging preferences, you can now select phone as an option. 9. If you edit a patron category, you can also now select phone as an option. Note: I have no way of actually sending a phone message, so couldn't test that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171950&action=edit Bug 37967: Allow auto renewals notices to be sent via phone Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note you can now select phone for auto-renewals! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171951&action=edit Bug 37967: (QA follow-up) Add bug number/description and perltidy atomicupdate Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Attachment #171808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- We should not try catch without rethrow. Please adjust the db rev: Simply remove the try-catch block. See bug 37895 for more details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #8)
We should not try catch without rethrow. Please adjust the db rev: Simply remove the try-catch block.
See bug 37895 for more details.
See bug 38394. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37967 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org