[Bug 31930] New: Ignore whitespace before and after barcodes when adding items to rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Bug ID: 31930 Summary: Ignore whitespace before and after barcodes when adding items to rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When you add items to a rotating collection by copy and pasting the barcode, there will often be whitespace causing a 'barcode not found' error. We should automatically remove/ignore this leading/trailing whitespace as we do in other forms like the checkout/checkin forms. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Yanjun Li <yanjun.li@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yanjun.li@bywatersolutions. | |com --- Comment #1 from Yanjun Li <yanjun.li@bywatersolutions.com> --- Hi Katrin, the whitespace doesn't affect the submission in the rotating collection page while adding new collection on my side. Let me know if you still have this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Can confirm that barcode whitespace is still not handled well in upstream To reproduce: 1. Go to Tools -> Rotating collections 2. Create a rotating collection 3. Chose Actions -> Manage items 4. Paste a barcode and put some spaces around it, for example " 39999000010053 " 5. Click Submit => Shown an error, no item with matching barcode found, though the barcode is printed without all the whitespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Yvonne Waterman <yvonnewaterman@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |yvonnewaterman@catalyst.net |ity.org |.nz CC| |yvonnewaterman@catalyst.net | |.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 --- Comment #3 from Yvonne Waterman <yvonnewaterman@catalyst.net.nz> --- Created attachment 184263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184263&action=edit Bug 31930: Ignore whitespace before and after barcodes Decoded the barcode in add items to collection. Test plan: 1. Go to Tools -> Rotating collections 2. Create a rotating collection 3. Chose Actions -> Manage items 4. Paste a barcode and put some spaces around it, for example " 39999000010053 " 5. Click Submit => Shown an error, no item with matching barcode found, though the barcode is printed without all the whitespace 6. Apply patch 7. Repeat steps 1 - 5, barcode should be accepted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Yvonne Waterman <yvonnewaterman@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184263|0 |1 is obsolete| | --- Comment #4 from Yvonne Waterman <yvonnewaterman@catalyst.net.nz> --- Created attachment 184264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184264&action=edit Bug 31930: Ignore whitespace before and after barcodes Decoded the barcode in add items to collection. Test plan: 1. Go to Tools -> Rotating collections 2. Create a rotating collection 3. Chose Actions -> Manage items 4. Paste a barcode and put some spaces around it, for example " 39999000010053 " 5. Click Submit => Shown an error, no item with matching barcode found, though the barcode is printed without all the whitespace 6. Apply patch 7. Repeat steps 1 - 5, barcode should be accepted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Yvonne Waterman <yvonnewaterman@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184264|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 184274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184274&action=edit Bug 31930: Ignore whitespace before and after barcodes Decoded the barcode in add items to collection. Test plan: 1. Go to Tools -> Rotating collections 2. Create a rotating collection 3. Chose Actions -> Manage items 4. Paste a barcode and put some spaces around it, for example " 39999000010053 " 5. Click Submit => Shown an error, no item with matching barcode found, though the barcode is printed without all the whitespace 6. Apply patch 7. Repeat steps 1 - 5, barcode should be accepted Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes adding or release notes| |removing items to a | |rotating collection (Tools | |> Patrons and circulation > | |Rotating collections). If a | |barcode has a space before | |it, it is now ignored | |instead of generating an | |error message. CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Nice work Yvonne, and thanks for the patch! I've added a draft release note. David Nind Testing notes (using koha-testing-docker): 1. Before the patch, I was able to successfully add a barcode with spaces after it, but got an error if there were spaces before it. 2. After the patch, things work as expected. 3. Also, not related to this bug, if you remove an item using the action from the table (instead of pasting a barcode into the barcode field), the "Remove item from collection" remains ticked. So another bug to create. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184274|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184647&action=edit Bug 31930: Ignore whitespace before and after barcodes Decoded the barcode in add items to collection. Test plan: 1. Go to Tools -> Rotating collections 2. Create a rotating collection 3. Chose Actions -> Manage items 4. Paste a barcode and put some spaces around it, for example " 39999000010053 " 5. Click Submit => Shown an error, no item with matching barcode found, though the barcode is printed without all the whitespace 6. Apply patch 7. Repeat steps 1 - 5, barcode should be accepted Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from David Nind <david@davidnind.com> --- Bug fix, no update to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org