https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 --- Comment #1 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 175899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175899&action=edit Bug 38771: Typo 'AuthScuccessLog' system preference Typo in system preference 'AuthScuccessLog' -> 'AuthSuccessLog'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175900|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 175901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175901&action=edit Bug 38771: Typo 'AuthScuccessLog' system preference Typo in system preference 'AuthScuccessLog' -> 'AuthSuccessLog'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main CC| |david@davidnind.com Text to go in the| |This fixes the log viewer release notes| |authentication module "Log | |not enabled" warning | |message for the log viewer. | |If either AuthFailureLog or | |AuthSuccessLog system | |preferences are set to | |"Don't log", the "Log not | |enabled" warning icon is | |now shown. Previously, if | |one of the system | |preferences was set to | |"Log", no warning icon was | |shown. Patch complexity|--- |Trivial patch --- Comment #5 from David Nind <david@davidnind.com> --- I've signed off, as this does fix a typo in the code. However, I have a question for QA, as I think the existing logic is wrong. I've added a follow-up to correct the logic. Please remove or amend the follow-up patch if you think this is incorrect. Question for QA =============== 1. I think the warning icon with "Log not enabled" should show if either AuthFailureLog or AuthSuccessLog are not enabled. 2. After the patch, the warning icon with "Log not enabled" is only shown if both the authentication log system preferences are not enabled. [1] 3. It is the only module that I can see that has the case with two system preferences, and it uses an ||, but I think it should be an &&. That is, if either of the system preference are not enabled, it should show the warning. [1] Settings and the warning triangle in the log viewer, after the patch ==================================================================== 1. If both AuthFailureLog and AuthSuccessLog enabled: => No warning triangle in the log viewer tool with "Log not enabled" (as expected) 2. If both AuthFailureLog and AuthSuccessLog not enabled: => Warning triangle in the log viewer tool with "Log not enabled" (as expected) 3. If AuthFailureLog enabled and AuthSuccessLog not enabled: => No warning triangle in the log viewer tool with "Log not enabled" (not as expected) 4. If AuthFailureLog not enabled and AuthSuccessLog enabled: => No warning triangle in the log viewer tool with "Log not enabled" (not as expected) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 175957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175957&action=edit Bug 38771: Add "Auth" prefix to system preference search query -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fix, no update to the manual required. -- You are receiving this mail because: You are watching all bug changes.