[Bug 38407] New: Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Bug ID: 38407 Summary: Eliminate event handler attributes in the staff interface Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Like bug 34709 but for the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- egrep -R " on[a-zA-Z]+=" --exclude-dir="greybox" koha-tmpl/intranet-tmpl/ | wc -l The above shows that there are currently 181 instances of inline event handler attributes in the staff interface templates (Note: There may be other places where inline event handler attributes are added to generated code throughout Koha other than in templates, but I think that Koha/FrameworkPlugin.pm already looks fixed, so those places might be few or non-existent.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34709 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38364 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38364 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED --- Comment #2 from David Cook <dcook@prosentient.com.au> --- It wouldn't hurt to have a test in the QA scripts to make sure that inline event handler attributes aren't being added, if we don't have one already. Note that we can quote the coding guidelines when we do specific reports for this one: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38365 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- On bug 38365, Jonathan has pointed out a few places to check in the cataloguing editor like cloning subfields and using the Tag Editor for fields with linked authorities like 100$a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Technically, this is just a best practice in general and even a Koha coding guidelines requirement. Even without Content-Security-Policy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Like bug 34709 I think this is actually an umbrella/omnibus bug report, since trying to replace all the inline event handlers at once probably isn't realistic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 [Bug 38365] Add Content-Security-Policy HTTP header to HTML responses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Technically, we don't have to have this one depend on bug 38365. That is, the change for bug 38407 don't require bug 38365. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- But now that bug 38365 is pushed, I'll have more resources free to work on this one. Yay! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #6)
Technically, we don't have to have this one depend on bug 38365. That is, the change for bug 38407 don't require bug 38365.
Yes but I wanted to highlight that this one was the next step. Feel free to remove it if you disagree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #8)
(In reply to David Cook from comment #6)
Technically, we don't have to have this one depend on bug 38365. That is, the change for bug 38407 don't require bug 38365.
Yes but I wanted to highlight that this one was the next step. Feel free to remove it if you disagree.
Fair enough! I think I'm happy to leave it for now. Especially as I was thinking of spinning off other reports that this one will depend on anyway. Yeah it's fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42435 [Bug 42435] Many console errors on addbiblio.tt page after content secure policy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42438 [Bug 42438] Remove event attributes from icon selection include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42439 [Bug 42439] Remove event attributes from label-edit-batch.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 [Bug 42440] Remove event attributes from labeled MARC detail template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 [Bug 42441] Remove event attributes from authority merge template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 [Bug 42442] Remove event attributes from bibliographic record merge template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 [Bug 42445] Remove event attributes from list creation template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- You're a legend, Owen. Hoping to take a look a those dep bugs soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #10)
You're a legend, Owen. Hoping to take a look a those dep bugs soon.
I'm just picking the low-hanging fruit :D Scared to touch addbiblio.tt and additems.tt! XD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #11)
(In reply to David Cook from comment #10)
You're a legend, Owen. Hoping to take a look a those dep bugs soon.
I'm just picking the low-hanging fruit :D Scared to touch addbiblio.tt and additems.tt! XD
I figure the harder ones are easier because they're more likely to explode 😅 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42467 [Bug 42467] Remove event attributes from MARC modification templates template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Bug 38407 depends on bug 42445, which changed state. Bug 42445 Summary: Remove event attributes from list creation template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42445 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Bug 38407 depends on bug 42438, which changed state. Bug 42438 Summary: Remove event attributes from icon selection include file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42438 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Bug 38407 depends on bug 42439, which changed state. Bug 42439 Summary: Remove event attributes from label-edit-batch.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42439 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Bug 38407 depends on bug 42442, which changed state. Bug 42442 Summary: Remove event attributes from bibliographic record merge template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Bug 38407 depends on bug 42441, which changed state. Bug 42441 Summary: Remove event attributes from authority merge template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43257 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 [Bug 43257] Remove event attributes from circulation.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Bug 38407 depends on bug 42440, which changed state. Bug 42440 Summary: Remove event attributes from labeled MARC detail template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43318 [Bug 43318] Remove event attributes from patron_messages.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43319 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 [Bug 43319] Remove event attribute from library_groups.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 [Bug 43321] Remove event attribute from search filter administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43325 [Bug 43325] Remove event attribute from point of sale receipt window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43329 [Bug 43329] Remove event attribute from some acquisitions pages -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org