[Bug 42748] New: Rewrite selenium/administration_tasks.t using Cypress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 Bug ID: 42748 Summary: Rewrite selenium/administration_tasks.t using Cypress Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 29285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29285 [Bug 29285] [OMNIBUS] Rewrite Selenium tests using Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199810&action=edit Bug 42748: Rewrite selenium/administration_tasks.t using Cypress Test plan: yarn cypress run --spec t/cypress/integration/Admin/AdministrationTasks_spec.ts should return green. QA will make sure all the tests have been properly rewritten -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Unfortunately this depends on bug 42322 (because of a DT bug on the visibility column "action" of the item types table). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 [Bug 42322] Collapse sidebar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|42322 |42094 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #2)
Unfortunately this depends on bug 42322 (because of a DT bug on the visibility column "action" of the item types table).
It's bug 42094. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags (except value_builder) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 [Bug 42322] Collapse sidebar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Note: Dependent bug, Bug 42279, no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #4)
Note: Dependent bug, Bug 42279, no longer applies.
Now fixed, but now bug 42295 no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Jonathan! All the dependent patches now apply. However, the tests didn't pass for me - 1 test fails: ... 1) should edit an existing itemtype ... 12 passing (54s) 1 failing 1) Administration module - Itemtypes tests should edit an existing itemtype: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Edit' within the element: <tr> but never did. at Context.eval (webpack://koha/./t/cypress/integration/Admin/AdministrationTasks_spec.ts:44:13) ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- It actually depends on bug 42332. The fix is "Bug 42332: DT visibility - admin/itemtypes". I think I've adjusted the dependencies last week (42094 does no longer depend on 42332), hence the confusion, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- So now it should depend on bug 42332, right? (which will also pull bug 42094) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from David Nind <david@davidnind.com> --- All the dependent bugs apply! However, one test is failing: Administration module - Itemtypes tests ✓ should create a new itemtype (4763ms) 1) should edit an existing itemtype ... 12 passing (49s) 1 failing 1) Administration module - Itemtypes tests should edit an existing itemtype: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Edit' within the element: <tr> but never did. Testing notes (using KTD): 1. Apply the patch (and all the dependent patches) 2. Rebuild everything: yarn build 3. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org