https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42977 Bug ID: 42977 Summary: Plugin upload does not tell InstallPlugins which plugin was uploaded Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: kyle@bywatersolutions.com, martin.renvoize@openfifth.co.uk, tomascohen@gmail.com Depends on: 42976 Target Milestone: --- plugins/plugins-upload.pl calls Koha::Plugins->new->InstallPlugins({ verbose => 0 }) with no 'include' filter after extracting an uploaded plugin archive, so it cannot benefit from the scoping added in Bug 42976 -- every installed plugin still gets deleted and reloaded from disk on every single upload, not just the one that was actually uploaded. This bug is to have plugins-upload.pl determine the plugin class name(s) actually contained in the uploaded archive (e.g. from the list of files Archive::Extract extracted under the plugins directory) and pass them via InstallPlugins({ include => \@classes }), so an upload only forces a reload of the plugin(s) it actually changed. Test plan: 1. Install two or more plugins. 2. Upload a new version of one of them via Tools > Plugins. 3. Confirm only the uploaded plugin's class is deleted and reloaded from disk, not every installed plugin. 4. Confirm the uploaded plugin's updated methods are correctly reflected (per Bug 42430's original test plan: upload a version that renames a method and confirm the new name takes effect without restarting Plack). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42976 [Bug 42976] InstallPlugins reloads every plugin from disk even when only one is being installed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.