[Bug 42570] New: OPAC patron summary shows literal holds count instead of group-aware count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 Bug ID: 42570 Summary: OPAC patron summary shows literal holds count instead of group-aware count Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: dcook@prosentient.com.au, sbrown@bywatersolutions.com When using grouped holds, holds limits are enforced based on the number of hold groups + the number of ungrouped holds. This count also represents the number of items the patron can expect to receive. As such, it's the number we should show in the patron summary on the OPAC homepage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42168 Depends on| |15516, 42255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42255 [Bug 42255] Grouped holds counted inconsistently for circ rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198901&action=edit Bug 42570: Use count_holds for OPAC patron summary pending holds To test: 1 - enable DisplayAddHoldGroups 2 - place two ungrouped holds for a patron 3 - log into the opac as your patron, see 2 pending holds 3 - group the two holds 4 - reload OPAC, still see 2 pending holds 5 - Apply patch, restart_all 6 - reload OPAc, see 1 pending holds 7 - ungroup holds 8 - reload OPAC, see 2 pending holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- (In reply to Andrew Fuerste-Henry from comment #0)
When using grouped holds, holds limits are enforced based on the number of hold groups + the number of ungrouped holds. This count also represents the number of items the patron can expect to receive. As such, it's the number we should show in the patron summary on the OPAC homepage.
I'm not seeing this in the current main (just updated everything) (for step 4 of the test plan before applying the pacth). I'll add a screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 198906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198906&action=edit Screenshote - Before the patch - count for group holds in OPAC shows correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198906|Screenshote - Before the |Screenshot - Before the description|patch - count for group |patch - count for group |holds in OPAC shows |holds in OPAC shows |correctly |correctly Attachment #198906|Screenshot 2026-05-09 at |Screenshot 2026-05-09 at filename|08-18-47 Your summary ⺠|08-18-47 Your summary ⺠|Koha online catalog.png |Koha online catalog.png -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198908&action=edit User summary on front page of OPAC I mean the count on the front page of the OPAC, in the User Summery box. I've attached a screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198901|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 198909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198909&action=edit Bug 42570: Use count_holds for OPAC patron summary pending holds To test: 1 - enable DisplayAddHoldGroups 2 - place two ungrouped holds for a patron 3 - log into the opac as your patron, see 2 pending holds 3 - group the two holds 4 - reload OPAC, still see 2 pending holds 5 - Apply patch, restart_all 6 - reload OPAc, see 1 pending holds 7 - ungroup holds 8 - reload OPAC, see 2 pending holds Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the patron release notes| |summary on the front page | |of the OPAC to show the | |correct number of holds | |when hold groups are | |enabled | |(DisplayAddHoldGroups | |system preference). | | | |Grouped holds are now | |correctly shown as 1 hold, | |instead of the number of | |individual holds in hold | |groups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Not sure how I got added to the CC but I'm glad for it! I was super busy when I made this comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168#c5 so thanks heaps Andrew! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Monday morning here so just getting my bearings still, but I'll loop back to QA this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- It looks like the holds list is a bit broken at the moment, but due to an unrelated change... I'll have to come back to this I think -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
It looks like the holds list is a bit broken at the moment, but due to an unrelated change... I'll have to come back to this I think
Ah, I forgot to restart after rebuilding the API following the push of bug 37762. All good... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from David Cook <dcook@prosentient.com.au> --- When I try to group the holds I get a 500 error from the API saying: "The method Koha::HoldGroup->visual_hold_group_id is not covered by tests!" I'm guessing this is due to an unrelated change, but I don't have time to hunt it down right now unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Actually, I worked around that problem by enabling DisplayMultiItemHolds and just making a hold group from the start. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 198978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198978&action=edit Bug 42570: Use count_holds for OPAC patron summary pending holds To test: 1 - enable DisplayAddHoldGroups 2 - place two ungrouped holds for a patron 3 - log into the opac as your patron, see 2 pending holds 3 - group the two holds 4 - reload OPAC, still see 2 pending holds 5 - Apply patch, restart_all 6 - reload OPAc, see 1 pending holds 7 - ungroup holds 8 - reload OPAC, see 2 pending holds Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41956 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #15 from David Cook <dcook@prosentient.com.au> --- Depends on bug 15516 so not relevant for backporting from here. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org