[Bug 23673] New: Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Bug ID: 23673 Summary: Separate time sent from time created in message_queue table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org Problem: Currently in the message_queue table the only time/date field in the message_queue table is "time_queued". This is set when the message is created and then updated when the message is sent. Additionally, the time_queued data is displayed on the notices tab in a patron's account in a column simply called "Time." Solution: We need to create separate fields for the time a message is created and for the time the message is sent. The time_queued will be populated when added to the message queue table. Populate the time_sent field with the time the message was sent and do not modify time_queued field. Then, for the purposes of helping staff answer questions about notices for patrons, we need to rename the "Time" column on the patron's notices tab to "Time sent" and add a separate column for "Time created". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by: Northeast release notes| |Kansas Library System | |(NEKLS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 94503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94503&action=edit Bug 23673: change db structure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #2 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 94504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94504&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- I decided to change "Time sent" column name for "Time status changed". I thought it would be clearer in the case the message failed. The other way, a user may see that the message failed and a timestamp in "Time sent" column and may be confused thinking that the message was sent but failed afterwards. If anyone comes up with a better name for the column I'll change it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #4 from Maxime Dufresne <maxime.dufresne@inlibro.com> --- Created attachment 94954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94954&action=edit Bug 23805: (RM follow-up) Remove CHECK constraints MariaDB and MySQL support different syntaxes for CHECK constraints at different versions. To remove complexities in the updatedatabase script I have opted to remove all CHECK constraints entirely. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Maxime Dufresne <maxime.dufresne@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.dufresne@inlibro.com Attachment #94954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94504|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96232&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94503|0 |1 is obsolete| | Attachment #96232|0 |1 is obsolete| | --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 96346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96346&action=edit Bug 23673: change db structure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #7 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 96347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96347&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- Fixed atomic update file. I missed in line 6 when it checked if column exists it said 'time_sent' instead of 'time_status_changed' as it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #9 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 96391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96391&action=edit success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96347|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96392&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96346|0 |1 is obsolete| | Attachment #96392|0 |1 is obsolete| | --- Comment #11 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 96451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96451&action=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 96452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96452&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A couple of small things: 1. Should not we have the new column with the "default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP" clause in order to delegate the update of this value to the DBMS? 2. I think we almost agreed on a pattern for the timestamp/datetime columns (there is nothing in the coding guidelines however), to name them suffixed by _on time_status_changed would be updated_on I know that it's not exactly what the patch does, but in practice it will be the same I think. Once queued, we only update their status afaik. Marked as Failed QA but could be considered as "In discussion" if you disagree or if I missed something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #14 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Jonathan
1. Should not we have the new column with the "default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP" clause in order to delegate the update of this value to the DBMS?
Mysql doesn't accept a table with 2 columns with "default CURRENT_TIMESTAMP".. there can be only one.
2. I think we almost agreed on a pattern for the timestamp/datetime columns (there is nothing in the coding guidelines however), to name them suffixed by _on time_status_changed would be updated_on
Ok, I didn't know about that rule.. I'll change that name in follow up. Regards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 96643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96643&action=edit Bug 23673: (follow-up) Change time_status_changed to updated_on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Agustín Moyano from comment #14)
Hi Jonathan
1. Should not we have the new column with the "default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP" clause in order to delegate the update of this value to the DBMS?
Mysql doesn't accept a table with 2 columns with "default CURRENT_TIMESTAMP".. there can be only one.
Hola Agustín, Yes I know and that's why I suggested to have it on the new column :) Take a look at library_groups or borrowers tables for instance. Note that article_requests does the reverse. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #16)
(In reply to Agustín Moyano from comment #14)
Hi Jonathan
1. Should not we have the new column with the "default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP" clause in order to delegate the update of this value to the DBMS?
Mysql doesn't accept a table with 2 columns with "default CURRENT_TIMESTAMP".. there can be only one.
Hola Agustín, Yes I know and that's why I suggested to have it on the new column :)
Take a look at library_groups or borrowers tables for instance. Note that article_requests does the reverse.
You mean making the 'time_queued' column TIMESTAMP DEFAULT NULL (and so making us set it manually), and making 'updated_on' be the one with the trigger? (so we don't do the update manually?). I'm fine with either. Just trying to clarify so we move this forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #17)
(In reply to Jonathan Druart from comment #16)
(In reply to Agustín Moyano from comment #14)
Hi Jonathan
1. Should not we have the new column with the "default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP" clause in order to delegate the update of this value to the DBMS?
Mysql doesn't accept a table with 2 columns with "default CURRENT_TIMESTAMP".. there can be only one.
Hola Agustín, Yes I know and that's why I suggested to have it on the new column :)
Take a look at library_groups or borrowers tables for instance. Note that article_requests does the reverse.
You mean making the 'time_queued' column TIMESTAMP DEFAULT NULL (and so making us set it manually), and making 'updated_on' be the one with the trigger? (so we don't do the update manually?). I'm fine with either. Just trying to clarify so we move this forward.
Yes, that is what I meant. 4252 created_on TIMESTAMP NULL, -- Date and time of creation 4253 updated_on TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, -- Date and time of last -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96451|0 |1 is obsolete| | Attachment #96452|0 |1 is obsolete| | Attachment #96643|0 |1 is obsolete| | --- Comment #19 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98090&action=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #20 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98091&action=edit Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not sure what should be the status of this bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98090|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98419&action=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98091|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98420&action=edit Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Re-checked and re-signed-off. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Agustin, it seems that updated_on should be set to time_queued when the column is added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98431&action=edit Bug 23673: Avoid sleep in tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98419|0 |1 is obsolete| | Attachment #98420|0 |1 is obsolete| | Attachment #98431|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98432&action=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98433&action=edit Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98434&action=edit Bug 23673: Avoid sleep in tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98435&action=edit Bug 23673: Set updated_on=time_queued on DB update Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not sure about the latch patch. Martin, please wait for Agustin approval before pushing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #33 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by: Northeast |The time a message was release notes|Kansas Library System |created and the time it was |(NEKLS) |sent are now separate | |columns in the | |message_queue table and | |will shown in the patron's | |account on the notice tab. | | | |Sponsored by: Northeast | |Kansas Library System | |(NEKLS) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org