https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A couple of small things: 1. Should not we have the new column with the "default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP" clause in order to delegate the update of this value to the DBMS? 2. I think we almost agreed on a pattern for the timestamp/datetime columns (there is nothing in the coding guidelines however), to name them suffixed by _on time_status_changed would be updated_on I know that it's not exactly what the patch does, but in practice it will be the same I think. Once queued, we only update their status afaik. Marked as Failed QA but could be considered as "In discussion" if you disagree or if I missed something. -- You are receiving this mail because: You are watching all bug changes.