[Bug 35098] New: ILL batch is not displayed in ILL table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Bug ID: 35098 Summary: ILL batch is not displayed in ILL table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 35096 To reproduce, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 10) Go back to ILL requests table, visit: /cgi-bin/koha/ill/ill-requests.pl 11) On the top right of the table, click 'Columns' and enable Batch 12) Notice the batch column is empty for the request we just created within a batch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 [Bug 35096] ILL request manage page explodes if it belongs to a batch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157341&action=edit Bug 35098: Fix display of clickable batch name in ILL table Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 10) Go back to ILL requests table, visit: /cgi-bin/koha/ill/ill-requests.pl 11) On the top right of the table, click 'Columns' and enable Batch 12) Notice the batch column now shows correctly and is clickable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157341|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157439&action=edit Bug 35098: Fix display of clickable batch name in ILL table Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 10) Go back to ILL requests table, visit: /cgi-bin/koha/ill/ill-requests.pl 11) On the top right of the table, click 'Columns' and enable Batch 12) Notice the batch column now shows correctly and is clickable Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another trivial fix after the last minute refactoring Going straight for QA Passed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Bug 35098 depends on bug 35096, which changed state. Bug 35096 Summary: ILL request manage page explodes if it belongs to a batch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35096 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org