[Bug 30719] New: ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

9 May 2022 9 May '22

1:04 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Bug ID: 30719 Summary: ILL should provide the ability to create batch requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com Some interlibrary loan providers, for example Reprints Desk, allow for ILL requests to be submitted in batches. In the Reprints Desk case, a batch is created with the supplier, then requests are then submitted including the batch ID. Obviously, this workflow may differ according to supplier and these differences should be abstracted away into the supplier backend. For core Koha, we should provide the ability for it to recognise if a given backend can process batch requests. If so, we should provide an interface for creating and manipulating batches within Koha, then submitting a batch to the supplier. It should also be possible to view all batches and the contents of a given batch. The funding institution has defined the following workflow for creating and populating batches: - A encapsulating "batch" is created with a name and a requesting borrower - Requests are added to a batch via two methods: - In bulk: - A form which allows the user to paste in a collection of identifiers, such as DOI / PMID etc. - For each of these identifiers: - The request metadata should be populated via API queries to metadata suppliers, for example, PubMed API or LibKey/Browzine. This behaviour is governed by the presence of appropriate plugins. - (Optional) Once the metadata is populated for an item, we check for item availability via any installed ILL availability plugins - Individually: - A regular ILL request form, requests are added to the batch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

9 May 9 May

3:32 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

7 Nov 7 Nov

11:40 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

28 Nov 28 Nov

1:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 144281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144281&action=edit Bug 30719: Batch requests minor misc improvements - Fix wrong link in message in case there are no requests batch - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

2:03 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:50 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 144285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144285&action=edit Bug 30719: DB, API & tests This commit adds the following: - A database update that adds an "illbatches" table, a "illrequest.batch_id" foreign key and an "illbatches.borrowernumber" foreign key - Illbatch and Illbatches Koha objects - Adds 'batch' accessor to Illrequest object - CRUD API endpoints for working with ILL batches - Unit tests of the Koha objects and API endpoints - Adds 'batch_id' filter to /illrequests endpoint -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:51 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 144286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144286&action=edit Bug 30719: Batch ILL requests - Add API endpoint for ILL request creation - UI for creation of ILL batches, including: - Ability to paste in list of identifier - Auto metadata enrichment for each identifier, using installed third party service API plugins - Auto retrieval of identifier availability, using installed third party service API plugins - Auto creation of local requests within batch - UI for management of existing ILL batches, including adding requests to, and removing requests from, batches - Additional UI to allow users to navigate from requests to their enclosing batches and vice-versa -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:51 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 144287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144287&action=edit Bug 30719: Logging of batch operations This commit adds logging of the following batch operations: - Batch creation - Batch update (Updating of the batch itself, not its contents) - Batch delete -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:52 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 144288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144288&action=edit Bug 30719: Batch statuses This commits adds the following provision for batch statuses: - Database updates - Object definitions - CRUD REST API - Unit tests - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:53 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Apply all current 5 patches, on ktd, preparation: - Run DBIC - Run reset_all - Enable ILLModule sys pref - Default ILLLIBS patron category needs to exist, create that - At least one ILL batch status needs to exist, admin -> ILL batch statuses, create for example name:NEW status:NEW - At least one ILL Backend with "provide_batch_requests" capability needs to exist, create ReprintsDesk backend from https://github.com/PTFS-Europe/koha-ill-reprintsdesk - Install ReprintsDesk backend dependencies: cpan XML::Compile XML::Smart XML::Compile:WSDL11 XML::Compile::SOAP12 - Need to restart plack here - Update backend_directory in koha-conf.xml to <backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory> - Need to restart plack here - Install metadata enrichment plugin pubmedid from https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0 through "Manage plugins" in admin - Need to restart plack here - Go to ILL Requests admin area, click "New ILL batch request" and select ReprintsDesk - Create new batch (insert name, cardnumber and library) and press "continue" - Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process identifiers" - After processing is complete, click "add items to batch" and then "finish and view batch" Verify that: - The items requested in the batch are now illrequests in Koha, and are part of the batch that was just created - Clicking on "Batch requests" lists all batch requests created - Clicking on a batch name lists only the requests from that batch - If a batch is deleted, whatever requests previously on that batch are not deleted (they have been detached, their batch_id is now NULL) - When editing a request that is part of a batch, it's possible to change which batch the request is part of, or none. Test logs: - Before doing the above, enable illlog sys pref - Do some CRUD actions on batch requests - Check log viewer -> module "Interlibrary loans" - Verify that the actions performed have been logged Run tests: perl t/db_dependent/Illbatches.t perl t/db_dependent/Illbatchstatuses.t #currently failing, will check why soon -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:26 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:27 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:27 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:27 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:28 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:39 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Apply all current 5 patches, on ktd, preparation: - Run DBIC - Run reset_all - Enable ILLModule sys pref - Default ILLLIBS patron category needs to exist, create that - At least one ILL batch status needs to exist, admin -> ILL batch statuses, create for example name:NEW status:NEW - At least one ILL Backend with "provide_batch_requests" capability needs to exist, create ReprintsDesk backend from https://github.com/PTFS-Europe/koha-ill-reprintsdesk - Install ReprintsDesk backend dependencies: cpan XML::Compile XML::Smart XML::Compile:WSDL11 XML::Compile::SOAP12 - Need to restart plack here - Update backend_directory in koha-conf.xml to <backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory> - Need to restart plack here - Install metadata enrichment plugin pubmedid from https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0 through "Manage plugins" in admin - Need to restart plack here - Go to ILL Requests admin area, click "New ILL batch request" and select ReprintsDesk - Create new batch (insert name, cardnumber and library) and press "continue" - Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process identifiers" - After processing is complete, click "add items to batch" and then "finish and view batch" Verify that: - The items requested in the batch are now illrequests in Koha, and are part of the batch that was just created - Clicking on "Batch requests" lists all batch requests created - Clicking on a batch name lists only the requests from that batch - If a batch is deleted, whatever requests previously on that batch are not deleted (they have been detached, their batch_id is now NULL) - When editing a request that is part of a batch, it's possible to change which batch the request is part of, or none. Test logs: - Before doing the above, enable illlog sys pref - Do some CRUD actions on batch requests - Check log viewer -> module "Interlibrary loans" - Verify that the actions performed have been logged Run tests: perl t/db_dependent/Illbatches.t perl t/db_dependent/Illbatchstatuses.t #currently failing, will check why soon -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:49 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 144296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144296&action=edit Koha 22.11.00 Rosalie is here! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:59 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:48 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

27 Jan 27 Jan

10:22 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |m.de.rooy@rijksmuseum.nl --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking at bug history, I am asking for another signoff please. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:25 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm asking the customer whose sponsored this work to SO. We got a bit ahead of ourselves here. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145760&action=edit Bug 30719: (QA Follow-up): - Fixed an issue with illrequest api definition that prevented the listing of any ILL requests if if any had a status_alias - Updated "Add items to batch" css class to match new 22.11 style - Fixed conflict issue where it prevented the creation of a request in a backend that has JS field validation utilizing the #cardnumber selector - Added a check for metadata enrichment plugins and bail batches JS code if none are found, this prevents a console error - Remove ysearch from patron auto complete and use new standard one. FIXME: The dialog modal .modal has a z-index of 1050 but the autocomplete patron suggestions .ui-front has a z-index of 100, it's working but shows behind the modal and is unclickable. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Jan 31 Jan

2:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:52 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

2:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:30 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

1 Feb 1 Feb

1:14 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

1:18 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:19 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Apply patches, on ktd, preparation: - Run dbic - Run reset_all - Enable ILLModule sys pref - At least one ILL batch status needs to exist, admin -> (bottom right) Interlibrary Loan batch statuses, add that (name:NEW status:NEW) - At least one ILL Backend with "provide_batch_requests" capability needs to exist, add ReprintsDesk backend from https://github.com/PTFS-Europe/koha-ill-reprintsdesk to kohadevbox/koha/Koha/Illbackends with name 'ReprintsDesk' - Update backend_directory in koha-conf.xml to <backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory> - At least one metadata enrichment plugin needs to exist, admin -> Manage plugins add that (https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0) - restart_all - Run yarn build to update CSS Test plan: - Go to ILL Requests admin area, click "New ILL batch request" and select ReprintsDesk - Create new batch (insert name, cardnumber and library) and press "continue" - Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process identifiers" - After processing is complete, click "add items to batch" and then "finish and view batch" Verify that: - The items requested in the batch are now illrequests in Koha, and are part of the batch that was just created - Clicking on "Batch requests" lists all existing batches - From the previous step, clicking on a batch name lists only the requests from that batch - If a batch is deleted, whatever requests that were previously on that batch are not deleted (their batch_id is now NULL) - When editing a request that is part of a batch, it's possible to change which batch the request is part of, or none. (Optional) Test logging: - Before doing the above, enable illlog sys pref - Do some CRUD actions on batch requests - Check log viewer -> module "Interlibrary loans" - Verify that the actions performed have been logged (Optional) Test error messaging: - Try creating a batch with an already existing batch name, verify it doesn't create and error message shows appropriately - Try creating a batch with a non-existent borrower cardnumber, verifiy it doesn't create the batch and error message shows appropriately Run tests and ensure all are passing: prove -v t/db_dependent/Illbatches.t prove -v t/db_dependent/api/v1/illbatches.t prove -v t/db_dependent/IllbatchStatuses.t prove -v t/db_dependent/api/v1/illbatchstatuses.t -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Feb 2 Feb

10:32 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:24 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Feb 3 Feb

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145934|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 146152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146152&action=edit Bug 30719: (QA Follow-up): - Fix wrong link 'Create a new batch status message' in case there are no existing batch statuses - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list page - Fixed an issue with illrequest api definition that prevented the listing of any ILL requests if any request had a status_alias - Updated "Add items to batch" css class to match new 22.11 style - Fixed conflict issue where it prevented the creation of a single request in a backend that is using JS field validation utilizing the #cardnumber selector - Added a check for metadata enrichment plugins and bail batches JS code if none are found, this prevents a console error - Remove ysearch from patron auto complete in batch creation and use patron_autocomplete instead - 'New batch' and 'list batches' buttons no longer show if no metadata plugin is installed - Fixed tests, all passing now - Improved error messaging for non-existent cardnumber input in patron in ill batch creation - Improved error messaging for duplicate batch name creation error - Fix sidemenu filters and search not working after new batch_id column Sponsored-by: UKHSA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Feb 22 Feb

11:22 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Mar 2 Mar

5:33 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146152|0 |1 is obsolete| | --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147658&action=edit Bug 30719: (QA Follow-up): - Fix wrong link 'Create a new batch status message' in case there are no existing batch statuses - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list page - Fixed an issue with illrequest api definition that prevented the listing of any ILL requests if any request had a status_alias - Updated "Add items to batch" css class to match new 22.11 style - Fixed conflict issue where it prevented the creation of a single request in a backend that is using JS field validation utilizing the #cardnumber selector - Added a check for metadata enrichment plugins and bail batches JS code if none are found, this prevents a console error - Remove ysearch from patron auto complete in batch creation and use patron_autocomplete instead - 'New batch' and 'list batches' buttons no longer show if no metadata plugin is installed - Fixed tests, all passing now - Improved error messaging for non-existent cardnumber input in patron in ill batch creation - Improved error messaging for duplicate batch name creation error - Fix sidemenu filters and search not working after new batch_id column - Move 'add items to batch' button to bottom right and make button bigger - Add a11y aria tags - Update cancel/close button label depending on step of batch creation - Keep 'finish and see batch' button disabled until 'add items to batch' has been clicked Sponsored-by: UKHSA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Mar 7 Mar

5:37 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31705 Depends on|31705 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:38 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31705 | Depends on| |31705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:01 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31705 | Blocks| |31705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Mar 8 Mar

3:17 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:20 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:20 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:20 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:20 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:20 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147658|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147934&action=edit Bug 30719: (QA Follow-up): - Fix wrong link 'Create a new batch status message' in case there are no existing batch statuses - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list page - Fixed an issue with illrequest api definition that prevented the listing of any ILL requests if any request had a status_alias - Updated "Add items to batch" css class to match new 22.11 style - Fixed conflict issue where it prevented the creation of a single request in a backend that is using JS field validation utilizing the #cardnumber selector - Added a check for metadata enrichment plugins and bail batches JS code if none are found, this prevents a console error - Remove ysearch from patron auto complete in batch creation and use patron_autocomplete instead - 'New batch' and 'list batches' buttons no longer show if no metadata plugin is installed - Fixed tests, all passing now - Improved error messaging for non-existent cardnumber input in patron in ill batch creation - Improved error messaging for duplicate batch name creation error - Fix sidemenu filters and search not working after new batch_id column - Move 'add items to batch' button to bottom right and make button bigger - Add a11y aria tags - Update cancel/close button label depending on step of batch creation - Keep 'finish and see batch' button disabled until 'add items to batch' has been clicked Sponsored-by: UKHSA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:45 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:45 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:45 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:45 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:45 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147934|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147956&action=edit Bug 30719: (QA Follow-up): - Fix wrong link 'Create a new batch status message' in case there are no existing batch statuses - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list page - Fixed an issue with illrequest api definition that prevented the listing of any ILL requests if any request had a status_alias - Updated "Add items to batch" css class to match new 22.11 style - Fixed conflict issue where it prevented the creation of a single request in a backend that is using JS field validation utilizing the #cardnumber selector - Added a check for metadata enrichment plugins and bail batches JS code if none are found, this prevents a console error - Remove ysearch from patron auto complete in batch creation and use patron_autocomplete instead - 'New batch' and 'list batches' buttons no longer show if no metadata plugin is installed - Fixed tests, all passing now - Improved error messaging for non-existent cardnumber input in patron in ill batch creation - Improved error messaging for duplicate batch name creation error - Fix sidemenu filters and search not working after new batch_id column - Move 'add items to batch' button to bottom right and make button bigger - Add a11y aria tags - Update cancel/close button label depending on step of batch creation - Keep 'finish and see batch' button disabled until 'add items to batch' has been clicked Sponsored-by: UKHSA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:10 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #43 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Didn't apply. Rebased. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:45 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31705 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5 May 5 May

4:27 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32768 |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:28 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

12 May 12 May

7:33 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33716 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 [Bug 33716] ILL - Allow for a disclaimer stage per request type -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #45 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151152&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #46 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151153&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #47 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151154&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #48 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151155&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151156&action=edit Bug 30719: dbic specific, DONT PUSH -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:08 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #50 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This has now been rebased on top of 22440 and 33716 and is ready for testing. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 May 16 May

12:40 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Bug 30719 depends on bug 22440, which changed state. Bug 22440 Summary: Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:19 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:19 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:19 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:19 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:19 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:17 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:17 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:17 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:17 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:17 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

5:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

22 May 22 May

1:58 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:59 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

1:59 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

1:59 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

1:59 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

2 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:10 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:10 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

3:10 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

23 May 23 May

4:36 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151519|0 |1 is obsolete| | --- Comment #76 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 151571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151571&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:36 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151520|0 |1 is obsolete| | --- Comment #77 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 151572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151572&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:36 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151521|0 |1 is obsolete| | --- Comment #78 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 151573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151573&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:36 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:36 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:37 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 May 24 May

10:46 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

10:46 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

10:46 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

10:46 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

10:46 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

10:48 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #86 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- rebased after bug 33762 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

30 May 30 May

6:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #87 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151804&action=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber=<borrowernumber> 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:06 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:07 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:07 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:07 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:07 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:08 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #93 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- rebased for bug 33716 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:08 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #94 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- rebase for bug 33786 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:25 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 [Bug 33762] Restore page-section in ILL -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Jun 23 Jun

2:55 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact| |katrin.fischer@bsz-bw.de --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The dependency to bug 33716 is a bit of an issue here, we need to see how to resolve that. As I signed it off I can't QA, but it will send this one to BLOCKED even if passing. I skipped the last patch (DBIC) and ran dbic manually for testing as there was a conflict. 1) QA script FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill-batch-modal.inc FAIL valid_template options_for_libraries: not found FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint WARNING - The new column (is_system) for table illbatch_statuses is using INT(1) as type, must be TINYINT(1) if it has a boolean purpose, see the SQL12 coding guideline FAIL koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt FAIL filters wrong_html_filter at line 669 ( <a href="/cgi-bin/koha/ill/ill-requests.pl?batch_id=[% request.batch.id | html %]">) 2a) Database update is not idempotent Easy fix with our existing check methods: DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_30719_add_ill_batches.pl [11:39:04]: Bug 30719 - Add ILL batches ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate column name 'batch_id' at /kohadevbox/koha/C4/Installer.pm line 741 2b) Database update and kohastructure are not using COMMENT We standardized on using COMMENT as they display in schema.koha-community.org etc. Could you please move the comments to COMMENT syntax? 3) Unit tests are failing (after running db Update and dbic) Test Summary Report ------------------- t/db_dependent/api/v1/ill_requests.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=5, Tests=33, 21 wallclock secs ( 0.03 usr 0.02 sys + 18.99 cusr 1.70 csys = 20.74 CPU) Result: FAIL 4) Perltidy It might be nice (not blocker) to run the new perltidy over the code when working on it, thinking especially of the new files. There are some small inconsistencies like spaces and such: +use JSON qw( to_json ); +use base qw(Koha::Object); 5) FIXMEs Koha/REST/V1/Illbatches.pm + #FIXME: This should be $c->objects-search + my @batches = Koha::Illbatches->search()->as_list; + + #FIXME: Below should be coming from $c->objects accessors + # Get all patrons associated with all our batches +# FIXME: This should be moved to Koha::Illbackend +sub can_batch { + // TODO: need to also reset progress bar and already processed identifiers + // FIXME: This should be a kohaTable not KohaTable Are these something we should change now or at least have a follow-up bug for filed? 6) API If I understand correctly the API is not using the common/standardized terminology: + id: + type: string + description: Internal ILL batch identifier Should be batch_id or maybe ill_batch_id? (compared with other API routes: hold_id, patron_id, etc.) + borrowernumber: + type: string + description: Borrower number of the patron of the ILL batch Should be: patron_id + branchcode: + type: string + description: Branch code of the branch of the ILL batch Should be library_id + branch: + type: + - object + - "null" + description: The branch associated with the batch Should possibly be library + statuscode: + type: string + description: Code of the status of the ILL batch Should probably be status_code Similar for illbatchstatus.yaml: id: ill_batch_status_id ? 7a) Illbatch_statuses are not translatable They should probably be moved to en, like we just did with the debit types and credit types too. For reporting it's nice when the description can be translated. +++ b/installer/data/mysql/mandatory/illbatch_statuses.sql @@ -0,0 +1,5 @@ +INSERT INTO illbatch_statuses ( name, code, is_system ) VALUES +('New', 'NEW', 1), +('In progress', 'IN_PROGRESS', 1), +('Completed', 'COMPLETED', 1), +('Unknown', 'UNKNOWN', 1); 7b) Strings can be transalted inside the .js files We don't really need: ill-batch-modal-strings.inc ill-batch-table-strings.inc This file is probably no longer needed as we can now translate strings in .js files. Not blocker, could still be moved later. It might simplify the code in koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js quite a bit. Also: + var ill_batch_item_remove = _("Are you sure you want to remove this item from the batch"); Missing question mark at the end? 7c) Avoid "building" sentences from multiple parts + <a href="#" aria-current="page"> + [% IF status.id %] + Modify + [% ELSE %] + New + [% END %] batch status + </a> This will end up to be something like: %sModify%New%batch status. This is hard to read, but also harder to translate. Imaging having a language where you need to change the sequence, to be "Batch status edit". Better: + <a href="#" aria-current="page"> + [% IF status.id %] + <span>Modify batch status</span> + [% ELSE %] + <span>New batch status</span> + [% END %] + </a> The span would be to make both separate strings. The parsing looks for HTML tags. repeating the <a> inside the IF-ELSE would also work. Also here: + <h1> + View ILL requests + [% IF batch %] + for batch "[% batch.name | html %]" + [% END %] + </h1> 7d) Not sure if this is translatable I have doubts about this one here: <strong>[% status.is_system ? "Yes" : "No" | html %]</strong> I think we need to verify or just move to an IF-ELSE construct. 8) Capitalization + <li><a href="/cgi-bin/koha/admin/ill_batch_statuses.pl">Interlibrary Loan batch statuses</a></li> Interlibrary loan... + <th scope="col">Request Status</th> Request status <dt><a href="/cgi-bin/koha/admin/ill_batch_statuses.pl">Interlibrary Loan batch statuses</a></dt> + Interlibrary Loan batch statuses › Administration › Koha + <a href="/cgi-bin/koha/admin/ill_batch_statuses.pl">Interlibrary Loan batch statuses</a> Maybe to a search replace for Interlibrary Loan? There are many more... 9) Terminology + <th scope="col">Branch</th> Should be Library. 10) Page titles and breadcrumbs Need updating to follow Owen's latest work using Template WRAPPER etc. koha-tmpl/intranet-tmpl/prog/en/modules/admin/ill_batch_statuses.tt 11) Using page-section and btn-primary This predates the staff interface redesign work and needs some touch ups for yellow main buttons and white backgrounds. 12) Null? This looks like it might display "null" when either one is empty (unconfirmed): + var displayText = [data.firstname, data.surname].join(' ') + ' ( ' + data.cardnumber + ' )'; -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Jul 11 Jul

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #96 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Katrin, thank you for your amazing QA. I have 18 patches that address your observations here: https://github.com/PTFS-Europe/koha/commits/new_30719 Please have another look and then let me know how to proceed, if there's more fixing required, should I submit all these patches here or provide a squashed version? I did not address 11) directly because I'm not sure where exactly to apply it. Thank you! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Jul 14 Jul

2:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but the database update doesn't work: DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_30719_add_ill_batches.pl [12:29:56]: Bug 30719 - Add ILL batches ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Can't create table `koha_kohadev`.`illbatches` (errno: 150 "Foreign key constraint is incorrectly formed") at /kohadevbox/koha/C4/Installer.pm line 741 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I used the remote branch and did a rebase on master. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:48 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #99 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- After a chat with Katrin, these are the QA points we're still missing: - add mandatory batch statuses on the atomicupdate - double-check description field for batch statuses - add page section on the batch statuses list - style "Save" button on batch status edit page - "New ILL batch request" should be "New ill requests batch" - Are you sure you want to remove this item from the batch should be "Are you sure you want to remove this request from the batch?" - add requests modal - check for noExport class for the "remove" column - batches list table - check for noExport class for the actions column - add page-section to the ill batches list table - perltidy I hope to be able to finish this in the near future and comeback when that's done. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:27 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #100 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the summary Pedro, I believe we are close! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:42 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282 [Bug 34282] ILL batches - availability checking has issues -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Jul 28 Jul

6:23 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:23 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #101 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154046&action=edit Bug 30719: (QA follow-up squash): This is a squash of 25 QA patches located at: https://github.com/PTFS-Europe/koha/commits/new_30719 Bug 30719: (QA follow-up) Batch column should be hidden by default Bug 30719: (QA follow-up) Fix wrong tt filter type Bug 30719: (QA follow-up) Make atomicupdate idempotent Bug 30719: (QA follow-up) Use COMMENT syntax in database files Bug 30719: (QA follow-up) Fix tiny boolean is_system Bug 30719: (QA follow-up) Add missing CONSTRAINT entries from kohastructure.sql to the atomicupdate file Bug 30719: (QA follow-up) Add missing koha_object_class and koha_objects_class methods Bug 30719: (QA follow-up) Swap search to find Bug 30719: (QA follow-up) Fix tests Bug 30719: (QA follow-up) API terminology - id -> batch_id Bug 30719: (QA follow-up) API terminology - borrowernumber -> patron_id Bug 30719: (QA follow-up) API terminology - branchcode -> library_id Bug 30719: (QA follow-up) Make mandatory illbatch_statuses translatable Bug 30719: (QA follow-up) Improve translatability Bug 30719: (QA follow-up) Fix capitalization of Interlibrary Loan Bug 30719: (QA follow-up) Change Branch to Library in ILL batches table Bug 30719: (QA follow-up) Add template WRAPPER to batch statuses breadrcrumbs Bug 30719: (QA follow-up) Utilize patron_to_html function to display patron info in batches table Bug 30719: (QA follow-up) Add mandatory batch statuses to the atomicupdate Bug 30719: (QA follow-up) Add page-section to the batch statuses list page Bug 30719: (QA follow-up) Style Save button on batch status edit page Bug 30719: (QA follow-up) Add question mark to label string, rephrase new ILL batch button Bug 30719: (QA follow-up) Add noExport class to action columns in batch list table and batch modal table Bug 30719: (QA follow-up) Add page-section and headers to ILL batch table Bug 30719: (QA follow-up) Perltidy -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:28 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154046|0 |1 is obsolete| | --- Comment #107 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154052&action=edit Bug 30719: (QA follow-up squash): This is a squash of 25 QA patches located at: https://github.com/PTFS-Europe/koha/commits/new_30719 Bug 30719: (QA follow-up) Batch column should be hidden by default Bug 30719: (QA follow-up) Fix wrong tt filter type Bug 30719: (QA follow-up) Make atomicupdate idempotent Bug 30719: (QA follow-up) Use COMMENT syntax in database files Bug 30719: (QA follow-up) Fix tiny boolean is_system Bug 30719: (QA follow-up) Add missing CONSTRAINT entries from kohastructure.sql to the atomicupdate file Bug 30719: (QA follow-up) Add missing koha_object_class and koha_objects_class methods Bug 30719: (QA follow-up) Swap search to find Bug 30719: (QA follow-up) Fix tests Bug 30719: (QA follow-up) API terminology - id -> batch_id Bug 30719: (QA follow-up) API terminology - borrowernumber -> patron_id Bug 30719: (QA follow-up) API terminology - branchcode -> library_id Bug 30719: (QA follow-up) Make mandatory illbatch_statuses translatable Bug 30719: (QA follow-up) Improve translatability Bug 30719: (QA follow-up) Fix capitalization of Interlibrary Loan Bug 30719: (QA follow-up) Change Branch to Library in ILL batches table Bug 30719: (QA follow-up) Add template WRAPPER to batch statuses breadrcrumbs Bug 30719: (QA follow-up) Utilize patron_to_html function to display patron info in batches table Bug 30719: (QA follow-up) Add mandatory batch statuses to the atomicupdate Bug 30719: (QA follow-up) Add page-section to the batch statuses list page Bug 30719: (QA follow-up) Style Save button on batch status edit page Bug 30719: (QA follow-up) Add question mark to label string, rephrase new ILL batch button Bug 30719: (QA follow-up) Add noExport class to action columns in batch list table and batch modal table Bug 30719: (QA follow-up) Add page-section and headers to ILL batch table Bug 30719: (QA follow-up) Perltidy -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #108 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased on top of master and fixed the DBIC conflict. Katrin, all yours when you're available! Thank you very much! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Sep 8 Sep

4:08 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #114 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155426&action=edit Bug 30719: (QA follow-up) Squash: This is a squash of 25 QA patches located at: https://github.com/PTFS-Europe/koha/commits/new_30719 Bug 30719: (QA follow-up) Batch column should be hidden by default Bug 30719: (QA follow-up) Fix wrong tt filter type Bug 30719: (QA follow-up) Make atomicupdate idempotent Bug 30719: (QA follow-up) Use COMMENT syntax in database files Bug 30719: (QA follow-up) Fix tiny boolean is_system Bug 30719: (QA follow-up) Add missing CONSTRAINT entries from kohastructure.sql to the atomicupdate file Bug 30719: (QA follow-up) Add missing koha_object_class and koha_objects_class methods Bug 30719: (QA follow-up) Swap search to find Bug 30719: (QA follow-up) Fix tests Bug 30719: (QA follow-up) API terminology - id -> batch_id Bug 30719: (QA follow-up) API terminology - borrowernumber -> patron_id Bug 30719: (QA follow-up) API terminology - branchcode -> library_id Bug 30719: (QA follow-up) Make mandatory illbatch_statuses translatable Bug 30719: (QA follow-up) Improve translatability Bug 30719: (QA follow-up) Fix capitalization of Interlibrary Loan Bug 30719: (QA follow-up) Change Branch to Library in ILL batches table Bug 30719: (QA follow-up) Add template WRAPPER to batch statuses breadrcrumbs Bug 30719: (QA follow-up) Utilize patron_to_html function to display patron info in batches table Bug 30719: (QA follow-up) Add mandatory batch statuses to the atomicupdate Bug 30719: (QA follow-up) Add page-section to the batch statuses list page Bug 30719: (QA follow-up) Style Save button on batch status edit page Bug 30719: (QA follow-up) Add question mark to label string, rephrase new ILL batch button Bug 30719: (QA follow-up) Add noExport class to action columns in batch list table and batch modal table Bug 30719: (QA follow-up) Add page-section and headers to ILL batch table Bug 30719: (QA follow-up) Perltidy -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #115 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155427&action=edit Bug 30719: (QA follow-up) c->validation fixes -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:30 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:30 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155421|0 |1 is obsolete| | --- Comment #116 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155428&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155422|0 |1 is obsolete| | --- Comment #117 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155429&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155423|0 |1 is obsolete| | --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155430&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155424|0 |1 is obsolete| | --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155431&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155425|0 |1 is obsolete| | --- Comment #120 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155432&action=edit Bug 30719: dbic specific, DONT PUSH Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155426|0 |1 is obsolete| | --- Comment #121 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155433&action=edit Bug 30719: (QA follow-up) Squash: This is a squash of 25 QA patches located at: https://github.com/PTFS-Europe/koha/commits/new_30719 Bug 30719: (QA follow-up) Batch column should be hidden by default Bug 30719: (QA follow-up) Fix wrong tt filter type Bug 30719: (QA follow-up) Make atomicupdate idempotent Bug 30719: (QA follow-up) Use COMMENT syntax in database files Bug 30719: (QA follow-up) Fix tiny boolean is_system Bug 30719: (QA follow-up) Add missing CONSTRAINT entries from kohastructure.sql to the atomicupdate file Bug 30719: (QA follow-up) Add missing koha_object_class and koha_objects_class methods Bug 30719: (QA follow-up) Swap search to find Bug 30719: (QA follow-up) Fix tests Bug 30719: (QA follow-up) API terminology - id -> batch_id Bug 30719: (QA follow-up) API terminology - borrowernumber -> patron_id Bug 30719: (QA follow-up) API terminology - branchcode -> library_id Bug 30719: (QA follow-up) Make mandatory illbatch_statuses translatable Bug 30719: (QA follow-up) Improve translatability Bug 30719: (QA follow-up) Fix capitalization of Interlibrary Loan Bug 30719: (QA follow-up) Change Branch to Library in ILL batches table Bug 30719: (QA follow-up) Add template WRAPPER to batch statuses breadrcrumbs Bug 30719: (QA follow-up) Utilize patron_to_html function to display patron info in batches table Bug 30719: (QA follow-up) Add mandatory batch statuses to the atomicupdate Bug 30719: (QA follow-up) Add page-section to the batch statuses list page Bug 30719: (QA follow-up) Style Save button on batch status edit page Bug 30719: (QA follow-up) Add question mark to label string, rephrase new ILL batch button Bug 30719: (QA follow-up) Add noExport class to action columns in batch list table and batch modal table Bug 30719: (QA follow-up) Add page-section and headers to ILL batch table Bug 30719: (QA follow-up) Perltidy Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155427|0 |1 is obsolete| | --- Comment #122 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155434&action=edit Bug 30719: (QA follow-up) c->validation fixes Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:31 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155435&action=edit Bug 30719: (QA follow-up) Fix "Request Status" capitalization Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:38 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #124 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tortured Pedro long enough on this one ;) It's hard to take over someone else's code and I think we made a lot of improvements here trying to bring it closer to current standard. QA tools fail on tidiness (and a false positive for options_for_libraries), but are otherwise ok now. Given the size of this patch set and the age, I am willing to let that slip here. All new fiels have been perltidied. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 Oct 4 Oct

10:16 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #125 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156556&action=edit Bug 30719: Atomic update fixes -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:25 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #126 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi all. I know the history of this bug and am willing to overlook some things, but as-is I believe this requires some more work. High * The GET /illbatches endpoint is not /ill/batchess? * Illbatches.pm is too old school. Entirely relying on fetching the whole resultset: #FIXME: This should be $c->objects-search my @batches = Koha::Illbatches->search()->as_list; * And crafting the response manually, even the 'patron' attribute is done manually instead of an embed * The request body needs to be manually translated into the DB model: my $batch = Koha::Illbatch->new($body); we have Koha::Illbatches->new_from_api to avoid that. But there's obviously a reason it wasn't done like that. Lower * Table names, and column names: this is using old school naming for things. We can solve it on the API front, but even that is not entirely done. Please let me know if there's anything I can do to help you with this. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Oct 9 Oct

5:37 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #127 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156748&action=edit Bug 30719: QA follow-up: Rename illbatches endpoint to ill/batches -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:37 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #128 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156749&action=edit Bug 30719: QA follow-up: Rewrite Illbatches list endpoint Update accessors Add +strings embed Add x-koha-embed to batches list andpoint Add embed to API call from the front-end Update table to get data from _strings Add x-koha-embed to tests Add strings_map to Illbatch Add to_api_mapping to Illbatch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:38 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #129 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #126)

...

Hi all. I know the history of this bug and am willing to overlook some things, but as-is I believe this requires some more work.

High

* The GET /illbatches endpoint is not /ill/batchess? * Illbatches.pm is too old school. Entirely relying on fetching the whole resultset: #FIXME: This should be $c->objects-search my @batches = Koha::Illbatches->search()->as_list; * And crafting the response manually, even the 'patron' attribute is done manually instead of an embed * The request body needs to be manually translated into the DB model: my $batch = Koha::Illbatch->new($body); we have Koha::Illbatches->new_from_api to avoid that. But there's obviously a reason it wasn't done like that.

Lower

* Table names, and column names: this is using old school naming for things. We can solve it on the API front, but even that is not entirely done.

Please let me know if there's anything I can do to help you with this.

Hi Tomas, thanks for looking. Can you please check my latest 2 patches and confirm that this is what's required? More work will follow for the other endpoints and for illbatch statuses if so. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:54 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #130 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156752&action=edit Bug 30719: QA follow-up: Rewrite ill batches get endpoint -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Oct 10 Oct

12:18 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

12:47 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #132 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156785&action=edit Bug 30719: QA follow-up: Rename illbatchstatuses illbatchstatuses endpoint is now ill/batchstatuses -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Oct 11 Oct

11:22 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #133 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156811&action=edit Bug 30719: (QA follow-up) Pick better column names and cleanup This patch takes on normalizing the attribute names, embeds, and also makes the whole API more kosher, in terms of using accessors for related objects, using the standard structure for strings_map, etc. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:22 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #134 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156812&action=edit Bug 30719: QA follow-up: Update statuscode -> status_code on the js files Update remaining batch_id -> ill_batch_id Update batch object in Illrequest.pm strings_map -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:52 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

4:53 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #135 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156827&action=edit Bug 30719: QA follow-up: Updating remaining naming Update statuscode -> status_code on the js files Update remaining batch_id -> ill_batch_id Update batch object in Illrequest.pm strings_map -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:53 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #136 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156828&action=edit Bug 30719: QA follow-up: DB updates updates to atomicupdate and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Oct 13 Oct

2:30 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Oct 17 Oct

7:47 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:47 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #137 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:55 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35082 [Bug 35082] Koha::Illbatch should be kosher -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:56 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35083 [Bug 35083] Koha::Illbatchstatus should be kosher -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Oct 18 Oct

5:29 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35093 [Bug 35093] ILL table is broken -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Oct 25 Oct

8:21 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #138 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Nov 27 Nov

2:25 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35404 [Bug 35404] Wrong copy and paste in string (ILL batches) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Nov 29 Nov

10:59 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

11:34 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

11:49 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

11:50 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

11:50 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

11:52 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

bugzilla-daemon＠bugs.koha-community.org

12:03 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35403 [Bug 35403] Missing slash in string -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:04 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35411 [Bug 35411] Terminology: Card number, username or surname: -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Feb 12 Feb

12:27 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35930 [Bug 35930] <enable_plugins> variable in koha-conf breaks non-plugin module -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Feb 19 Feb

2:11 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 [Bug 36130] ILL batches table not showing all batches -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Mar 6 Mar

10:59 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36130 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 [Bug 36130] ILL batches table not showing all batches -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:59 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 [Bug 36130] ILL batches table not showing all batches -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Jul 16 Jul

9:23 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Bug 30719 depends on bug 33716, which changed state. Bug 33716 Summary: ILL - Allow for a disclaimer stage per request type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Jul 25 Jul

1:14 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Feb 6 Feb

2:23 p.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39050 [Bug 39050] Duplicate "type" attributes in ill-batch-modal.inc -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Oct 7 Oct

11:39 a.m.

New subject: [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38261 [Bug 38261] JS warning "unreachable code after return statement" -- You are receiving this mail because: You are watching all bug changes.

281

Age (days ago)

1528

Last active (days ago)

List overview

Download

194 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org