[Bug 34412] New: Inconsistencies in System preferences page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Bug ID: 34412 Summary: Inconsistencies in System preferences page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the System preferences (local use preferences) page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add a system preference' to 'New system preference' - Change "Confirm deletion of parameter 'variable'" to "Confirm deletion of system preference 'variable'" - Change 'Parameter deleted' to 'System preference deleted' Breadcrumb - Change 'Add a system preference' to 'New system preference' - Change "Confirm deletion of parameter 'variable'" to "Confirm deletion of system preference 'variable'" - In Confirm deletion, remove variable level - Change 'Parameter deleted' to 'System preference deleted' Page header - Change 'Add a system preference' to 'New system preference' - Styling of 'Add a system preference' header different than usual - Change 'Modify a system preference' to "Modify system preference 'variable'" - Styling of 'Modify a system preference' header different than usual - Change "Confirm deletion of 'variable'?" to "Confirm deletion of system preference 'variable'" - Change 'Data deleted' to 'System preference deleted' Styling of the Confirm deletion page is different than usual. It's usually a warning (yellow background) centered on the page. The buttons are white with a green checkmark for 'Yes, delete' and white with a red cross for 'No, do not delete' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155233&action=edit Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and header This patch makes changes to the markup of various areas of the local use system preferences template in order to make it more consistent with other pages in Koha. To test, apply the patch and go to Administration -> System preferences -> Local use. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - On the main page confirm that the heading is "Local use system preferences" - New preference: - The form on this page has been updated to make the markup structure more consistent with other pages, with the heading outside the white box of the form. - The two portions of the form have been combined into one so that the layout of the form is more consistent with similar forms. - Edit preference - Delete: - The deletion confirmation page has been reformatted to use an "alert" style dialog with styled confirmation buttons. - The "Data deleted" view has been reformatted to use a "message" style dialog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 155233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155233 Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and header Review of attachment 155233: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=34412&attachment=155233) ----------------------------------------------------------------- I have a few comments but none of them are blockers imo ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt @@ +13,4 @@
[% END %] › [% END %] [% IF ( add_validate ) %] + [% t("Preference added") | html %] ›
I couldn't find a way to see this text but I'm not too worried about it. @@ +91,5 @@
[% IF ( add_form ) %] + <h1> + [% IF ( modify ) %] + Modify a local use system preference
I think this could probably be "Modify preference '[% searchfield | html %]'", but not a deal breaker. @@ +283,5 @@
[% END %]
[% IF ( delete_confirm ) %] + <div class="dialog alert"> + <h1>Confirm deletion of [% searchfield | html %]?</h1>
It would be a good idea to wrap [% searchfield | html %] in single quotes, but since this is the same before and after the change I don't think it's in scope. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155233|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 155250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155250&action=edit Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and header This patch makes changes to the markup of various areas of the local use system preferences template in order to make it more consistent with other pages in Koha. To test, apply the patch and go to Administration -> System preferences -> Local use. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - On the main page confirm that the heading is "Local use system preferences" - New preference: - The form on this page has been updated to make the markup structure more consistent with other pages, with the heading outside the white box of the form. - The two portions of the form have been combined into one so that the layout of the form is more consistent with similar forms. - Edit preference - Delete: - The deletion confirmation page has been reformatted to use an "alert" style dialog with styled confirmation buttons. - The "Data deleted" view has been reformatted to use a "message" style dialog. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155262&action=edit Bug 34412: (follow-up) Clarify page heading, remove unused markup This patch updates the heading for the "modify" view so that it includes the name of the preference being modified. The patch also removes markup related to the "add_validate" state--a view confirming that a preference has been added--because that view doesn't exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inconsistencies in System |Inconsistencies in system |preferences page titles, |preferences page titles, |breadcrumbs, and header |breadcrumbs, and header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel it would be nicer to make some changes here: * We agreed a while not to use "preference" or "sys pref" to always give the full context (consistency). So I think we should use "New system preference" etc. * Instead of naming the placeholder searchfield, we should also name it {system_preference} because that is what will show up for translators and searchfield would likely cause confusion. [% tx("Confirm deletion of preference '{searchfield}'", { searchfield = searchfield }) | html %] › -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155393&action=edit Bug 34412: (QA follow-up) Terminology updates - Use "system preference" instead of just "preference" - Use "system_preference" as placeholder in translatable strings This patch also updates a few places where the placeholder i18n syntax can be used for consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155250|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155401&action=edit Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and header This patch makes changes to the markup of various areas of the local use system preferences template in order to make it more consistent with other pages in Koha. To test, apply the patch and go to Administration -> System preferences -> Local use. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - On the main page confirm that the heading is "Local use system preferences" - New preference: - The form on this page has been updated to make the markup structure more consistent with other pages, with the heading outside the white box of the form. - The two portions of the form have been combined into one so that the layout of the form is more consistent with similar forms. - Edit preference - Delete: - The deletion confirmation page has been reformatted to use an "alert" style dialog with styled confirmation buttons. - The "Data deleted" view has been reformatted to use a "message" style dialog. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155262|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155402&action=edit Bug 34412: (follow-up) Clarify page heading, remove unused markup This patch updates the heading for the "modify" view so that it includes the name of the preference being modified. The patch also removes markup related to the "add_validate" state--a view confirming that a preference has been added--because that view doesn't exist. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155393|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155403&action=edit Bug 34412: (QA follow-up) Terminology updates - Use "system preference" instead of just "preference" - Use "system_preference" as placeholder in translatable strings This patch also updates a few places where the placeholder i18n syntax can be used for consistency. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like others, not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35379 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35379 [Bug 35379] 'searchfield' parameter name misleading when translating -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org