[Bug 36567] New: Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Bug ID: 36567 Summary: Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Running t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t causes following warning:
You are creating a DateTime object with a far future year (9999) and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. at ../Koha/C4/Circulation.pm line 1614.
Datetime modules pod states (https://metacpan.org/pod/DateTime):
Currently, constructors will warn if you try to create a far future DateTime (year >= 5000) with any time zone besides floating or UTC. This can be very slow if the time zone has future DST transitions that need to be calculated. If the date is sufficiently far in the future this can be really slow (minutes).
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |emmi.takkinen@koha-suomi.fi Status|NEW |Needs Signoff --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164609&action=edit Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year (9999) and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than 9999 in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- Tests fail for prove t/db_dependent/Circulation.t after applying the patches (both tests pass before, only t/db_dependent/Circulation/dateexpiry.t passes after): prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 45/70 # Failed test 'renew log successfully added' # at t/db_dependent/Circulation.t line 4968. # got: '2' # expected: '3' # Looks like you failed 1 test of 13. t/db_dependent/Circulation.t .. 49/70 # Failed test 'AddRenewal and AddIssuingCharge tests' # at t/db_dependent/Circulation.t line 4987. t/db_dependent/Circulation.t .. 66/70 # Looks like you failed 1 test of 70. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/70 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 256 (exited 1) Tests: 70 Failed: 1) Failed test: 49 Non-zero exit status: 1 Files=1, Tests=70, 26 wallclock secs ( 0.08 usr 0.01 sys + 17.25 cusr 5.89 csys = 23.23 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to David Nind from comment #2)
Tests fail for prove t/db_dependent/Circulation.t after applying the patches (both tests pass before, only t/db_dependent/Circulation/dateexpiry.t passes after):
prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 45/70 # Failed test 'renew log successfully added' # at t/db_dependent/Circulation.t line 4968. # got: '2' # expected: '3' # Looks like you failed 1 test of 13. t/db_dependent/Circulation.t .. 49/70 # Failed test 'AddRenewal and AddIssuingCharge tests' # at t/db_dependent/Circulation.t line 4987. t/db_dependent/Circulation.t .. 66/70 # Looks like you failed 1 test of 70. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/70 subtests
Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 256 (exited 1) Tests: 70 Failed: 1) Failed test: 49 Non-zero exit status: 1 Files=1, Tests=70, 26 wallclock secs ( 0.08 usr 0.01 sys + 17.25 cusr 5.89 csys = 23.23 CPU) Result: FAIL
I'm unable to repeat this and I'm not even sure how these changes could affect those tests. Could this be caused by something in your testing environment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164609|0 |1 is obsolete| | --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 165635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165635&action=edit Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year (9999) and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than 9999 in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patch, keeping this as Failed QA due comment 2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165635|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 165636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165636&action=edit Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year (9999) and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than 9999 in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 --- Comment #7 from David Nind <david@davidnind.com> --- Both tests now pass after applying the patch. Not sure whether it was something with my KTD or not... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165636|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166096&action=edit Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year (9999) and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than 9999 in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org