[Bug 36122] New: NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Bug ID: 36122 Summary: NEW_SUGGESTION is sent for every modification to the suggestion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org If EmailPurchaseSuggestions is enabled, a new NEW_SUGGESTION notice is sent to the staff every time a modification is made to the suggestion. Create the suggestion --> NEW_SUGGESTION is sent to staff Accept the suggestion --> ACCEPTED is sent to patron; NEW_SUGGESTION is sent to staff Order the suggestion --> ORDERED is sent to patron; NEW_SUGGESTION is sent to staff To recreate: 1. Enable EmailPurchaseSuggestions 2. Create a suggestion from the OPAC 2.1. Go to the OPAC and log in as a patron 2.2. Go to Your account > Purchase suggestions 2.3. Click New purchase suggestion 2.4. Enter a title 2.5. Click Submit your suggestion 3. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 4. Update the suggestion to accepted 4.1. In the staff interface, go to Acquisitions > Suggestions 4.2. In the suggestions list, check the box next to the suggestion 4.3. At the bottom of the screen, choose Mark selected as: Accepted 4.4. Click Submit 5. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 6. Order the suggestion 3.1. Go to Acquisitions 3.2. Search for a vendor 3.3. Click New > Basket 3.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 3.5. Click Save 3.6. Click Add to basket 3.7. Click From a suggestion 3.8. Click Order next to the suggestion 3.9. Enter order details 3.10. Click Save 3.11. Click Close basket 3.12. Click Yes, close 7. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35854 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Might be the same as bug 35854, but I'm not 100% sure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I forgot the patron's email address in the test plan. I don't think notices are generated if the patron doesn't have an email address. To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33236 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Possibly linked to bug 33236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem@etf.edu --- Comment #4 from Mirjam Vantieghem <mirjam.vantieghem@etf.edu> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #5 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac@inlibro.com Assignee|koha-bugs@lists.koha-commun |matthias.le-gac@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #6 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162962&action=edit Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion Test plan : To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) 9. Apply the patch 10. now repeat steps 3 to 8 but : step 4 you have one NEW_SUGGESTION message in message_queue step 6 you have only one ACCEPTED message in message_queue step 8 you have only one ORDERED message in message_queue The NEW_SUGGESTION are now sent only on the submit of the suggestion and not on each steps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Failed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Can we have a Unit test for this please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #8 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162989&action=edit Bug 36122: add unit test Test plan : To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) 9. Apply the patch 10. now repeat steps 3 to 8 but : step 4 you have one NEW_SUGGESTION message in message_queue step 6 you have only one ACCEPTED message in message_queue step 8 you have only one ORDERED message in message_queue The NEW_SUGGESTION are now sent only on the submit of the suggestion and not on each steps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #9 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- this is the first time I do test for Koha, so let me know if there's anything to improve. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Mattais, Can you review these tests? Something seems not quite right: # Subtest: store 1..8 ok 1 - If suggesteddate not passed in, it will default to today ok 2 - If suggesteddate passed in, it should be taken into account ok 3 - If suggestion id modified, suggesteddate should not be modified ok 4 - If EmailPurchaseSuggestions is not enabled, a message should not be sent not ok 5 - No message was sent # Failed test 'No message was sent' # at /kohadevbox/koha/t/db_dependent/Koha/Suggestions.t line 89. ok 6 - If the status of suggestion is not set to ASKED, a message should not be sent ok 7 - store raises an exception on invalid STATUS ok 8 - UNKNOWN status stored # Looks like you failed 1 test of 8. not ok 1 - store Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #11 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Lucas Gass from comment #10)
Mattais,
Can you review these tests? Something seems not quite right:
# Subtest: store 1..8 ok 1 - If suggesteddate not passed in, it will default to today ok 2 - If suggesteddate passed in, it should be taken into account ok 3 - If suggestion id modified, suggesteddate should not be modified ok 4 - If EmailPurchaseSuggestions is not enabled, a message should not be sent not ok 5 - No message was sent
# Failed test 'No message was sent' # at /kohadevbox/koha/t/db_dependent/Koha/Suggestions.t line 89. ok 6 - If the status of suggestion is not set to ASKED, a message should not be sent ok 7 - store raises an exception on invalid STATUS ok 8 - UNKNOWN status stored # Looks like you failed 1 test of 8. not ok 1 - store
Thanks!
I can't reproduce the problem, I've tried different situations but test 5 passes every time. Can you add these print "print STDERR "syspref: " . $syspref->variable . " value :" . $syspref->value . "\n";" to line 85 and 86 (before and after the syspref store line) and tell me what you get? To be sure that the changes made to the preferences have been good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #12 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 164481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164481&action=edit Bug 36122: modif test Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #13 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- I have modified how I change the value of the 'EmailPurchaseSuggestions' syspref during testing. Let me know if it works better now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Daphne Hoolahan <dch@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162962|0 |1 is obsolete| | --- Comment #14 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 165577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165577&action=edit Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162989|0 |1 is obsolete| | --- Comment #15 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 165578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165578&action=edit Bug 36122: add unit test Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164481|0 |1 is obsolete| | --- Comment #16 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 165579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165579&action=edit Bug 36122: modif test Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165577|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166051&action=edit Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166052&action=edit Bug 36122: Add unit test Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166053&action=edit Bug 36122: Update unit test Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great improvement and bugfix, thanks! QA scripts are happy, the Unit tests cover the change well. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #22 from David Cook <dcook@prosentient.com.au> --- Well done everyone. I have just gotten a report of this happening to someone, so it's great to see it fixed already upstream! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- That said... looking at this again and I'm not sure that this is 100% solved yet. Technically, if you moved the status of a suggestion back to "Pending", it would trigger another email. The solution for this probably would've been to use !$self->in_storage before $self->SUPER::store() to set a flag for email sending. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #24 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #23)
That said... looking at this again and I'm not sure that this is 100% solved yet.
Technically, if you moved the status of a suggestion back to "Pending", it would trigger another email.
The solution for this probably would've been to use !$self->in_storage before $self->SUPER::store() to set a flag for email sending.
Another issue is if you have a suggestion as "Pending" and a staff user edits it without changing the status, emails will continue to be sent out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36820 [Bug 36820] NEW_SUGGESTION is still sent for some modifications to the suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- Both those raised in bug 36820 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Keywords|rel_23_05_candidate | --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Klas Blomberg <klas.blomberg@skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg@skovde.se --- Comment #28 from Klas Blomberg <klas.blomberg@skovde.se> --- We have applied this patch, and there is one curiosity: Before this patch there were sent two identical emails using NEW_SUGGESTION - one was sent to the borrower, one was sent to the library After this patch is one email sent, that to the library. No mail is sent to the borrower, although it says so on the message-tab in the borrowerrecord. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azmikhalib@utm.my --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 35816 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED --- Comment #30 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org