https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Thinking more about it, naming the syspref SMSSendFrom is more consistent with the other SMS prefs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 83132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83132&action=edit Bug 21988: Add support for SMSSendFrom syspref This patch adds a SMSSendFrom syspref which allows a "from" number to be provided to SMS drivers that support it. It is passed to the driver as a "_from" parameter, in line with the formatting of the _username and _password parameters. Testing: Since this work depends on an SMS driver that supports it, it is virtually impossible to test. I have added the mocking of the SMSSendFrom preference to t/SMS.t, but can't really take it beyond that. Other than the adding of the syspref, a very tiny modification is made to C4/SMS.pm, but I don't anticipate this having an adverse effect. SMS drivers that do not support the _from paramter will simple ignore it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 83170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83170&action=edit Bug 21988: (follow-up) Provide more open params Rather than specifying a very specific additional parameter to be passed to the provider, we now provide the ability for the user to specify a JSON object containing arbitrary additional parameters, which are then combined with the core parameters that are sent to the provider. Test plan: - Apply the patch and do the database update - Navigate to the SMS preferences - TEST => Observe that a new "Provide additional parameters to be passed to the SMS provider (as a JSON object)" preference is displayed - Enter a JSON object in to the preference - Navigate away from the preferences - Navigate back to the SMS preferences - TEST => Observe that the value entered is preserved -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83132|0 |1 is obsolete| | Attachment #83170|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83175&action=edit Bug 21988: Add support for SMSSendFrom syspref This patch adds a SMSSendFrom syspref which allows a "from" number to be provided to SMS drivers that support it. It is passed to the driver as a "_from" parameter, in line with the formatting of the _username and _password parameters. Testing: Since this work depends on an SMS driver that supports it, it is virtually impossible to test. I have added the mocking of the SMSSendFrom preference to t/SMS.t, but can't really take it beyond that. Other than the adding of the syspref, a very tiny modification is made to C4/SMS.pm, but I don't anticipate this having an adverse effect. SMS drivers that do not support the _from paramter will simple ignore it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83175|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Comment on attachment 83175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83175 Bug 21988: Add support for SMSSendFrom syspref Obsoleting, as https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83176&action=diff supercedes this patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- D'oh! Ignore me, I was misreading the second patch, it replaces the contents of the first one, so no obsoleting required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- I was completely unaware of sms_send_config and, reading C4::SMS::send_sms, it appears to already do what this patch was intending to do, albeit in a slightly less end-user friendly way. There is a general move towards making things more visible via sysprefs, so there could be an argument that this furthers that effort? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ...to avoid *the* file... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- We've decided that we're going to abandon this as it's replicating functionality that already exists. It's true that moving it to a syspref makes it more user friendly, but it also introduces a migration path that we don't have the time to tackle. Leaving as "In discussion" in case anyone at any point in the future thinks it's worth tackling. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Isherwood from comment #15)

We've decided that we're going to abandon this as it's replicating functionality that already exists. It's true that moving it to a syspref makes it more user friendly, but it also introduces a migration path that we don't have the time to tackle.

Leaving as "In discussion" in case anyone at any point in the future thinks it's worth tackling.

Closing as WONTFIX for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.