[Bug 21512] New: CalculateFinesOnReturn doesn't work without the syspref finesMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Bug ID: 21512 Summary: CalculateFinesOnReturn doesn't work without the syspref finesMode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivilahti@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Fines are not created for checking in an Item, if the syspref 'CalculateFinesOnReturn' is enabled without the syspref finesMode being in the 'production' -mode (Calculate and charge). CalculateFinesOnReturn must work without the fines.pl -feature. The problem is with the subroutine C4::Circulation::_CalculateAndUpdateFine() Initially it looks like it must be invoked from the fines.pl as well. But that subroutine is only used within the C4::Circulation module for AddRenew and AddReturn. Hence the _CalculateAndUpdateFine() has nothing to do with fines.pl|finesMode. This patch replaces the finesMode-check with CalculateFinesOnReturn-check. I am not sure why there needs to be a specific syspref for the fines.pl, or why CalculateFinesOnReturn is needed, as the fine amounts can be tweaked using the circulation rules matrix and the fines.pl-cronjob can either be ran, or not, with an endless possibility of parameters that shouldn't be in the sysprefs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> --- Created attachment 80174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80174&action=edit 0001-Bug-21512-CalculateFinesOnReturn-doesn-t-work-withou.patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> --- Bug found and fix sponsored by Minna Kivinen @ https://www.hamk.fi/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure I agree with the intent. To me it feels like the right behaviour that FinesMode does also keep CalculateFinesOnReturn from calculating. A change like this could result in some surprises for libraries. Could we imagine a way to achieve your goal without a possibly unwanted surprise? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@helsin |ity.org |ki.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 hienpn <hien.pham@dlcorp.com.vn> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hien.pham@dlcorp.com.vn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org