https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Test Plan: 1. Create a serial 2 Have a serial with a frequency set for this serial. 3. Receive some serials. 4. Attempt to generate the next issue, get a software error. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 --- Comment #4 from Kelly McElligott <kelly@bywatersolutions.com> --- Kyle, error while testing: Could not compile /kohadevbox/koha/serials/serials-collection.pl: Global symbol "$frequency" requires explicit package name (did you forget to declare "my $frequency"?) at /kohadevbox/koha/serials/serials-collection.pl line 80. Global symbol "$frequency" requires explicit package name (did you forget to declare "my $frequency"?) at /kohadevbox/koha/serials/serials-collection.pl line 85. Global symbol "$frequency" requires explicit package name (did you forget to declare "my $frequency"?) at /kohadevbox/koha/serials/serials-collection.pl line 88. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/serials/serials-collection.pl line 218. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111168|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 111171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111171&action=edit Bug 26604: "Generate next" button gives error on serials-collection.pl In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. Signed-off-by: kelly mcelligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17047 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111171|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111242&action=edit Bug 26604: "Generate next" button gives error on serials-collection.pl In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. Signed-off-by: kelly mcelligott <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't recreate the problem, can you provide me a more detailed test plan please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok, I managed to recreate it. This is very tricky. Test plan: 1. Create a new subscription * When there is an irregular issue: Skip issue number * Select a frequency (not irregular) * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field 2. Receive a first serial (mark it arrived, an "expected" one is created) 3. Claim the expected one => You have 1 arrived and 1 claimed. It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl 4. Generate next => boom -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111242|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111399&action=edit Bug 26604: "Generate next" button gives error on serials-collection.pl In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. Signed-off-by: kelly mcelligott <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD Test plan: 1. Create a new subscription * When there is an irregular issue: Skip issue number * Select a frequency (not irregular) * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field 2. Receive a first serial (mark it arrived, an "expected" one is created) 3. Claim the expected one => You have 1 arrived and 1 claimed. It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl 4. Generate next => boom Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06, released in| |19.11.12 Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes.