https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111242|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111399&action=edit Bug 26604: "Generate next" button gives error on serials-collection.pl In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. Signed-off-by: kelly mcelligott <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD Test plan: 1. Create a new subscription * When there is an irregular issue: Skip issue number * Select a frequency (not irregular) * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field 2. Receive a first serial (mark it arrived, an "expected" one is created) 3. Claim the expected one => You have 1 arrived and 1 claimed. It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl 4. Generate next => boom Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.