[Bug 20615] New: add the link of number of times the authority are used in edit mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Bug ID: 20615 Summary: add the link of number of times the authority are used in edit mode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: patrick.robitaille@collecto.ca QA Contact: testopia@bugs.koha-community.org Hi, in the authorities module, when we consult a record there is a line at the top of the page indicating the number of records for which this authority is being usaed in. But this line disappears when you go into edit mode of the record. It would be convenient to keep this information on edit mode too. Thanks, Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | CC| |gveranis@dataly.gr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #1 from George Veranis <gveranis@dataly.gr> --- Hi Patrick, That you asked as a bug it seems that on the latest version of Koha has already be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #2 from George Veranis <gveranis@dataly.gr> --- Created attachment 129207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129207&action=edit The screenshot shows that on edit mode it has the number of records are connected to the authority record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Assignee|gveranis@dataly.gr |koha-bugs@lists.koha-commun | |ity.org Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #3 from Patrick Robitaille <patrick.robitaille@collecto.ca> --- Hello, My need is to see this information in the edit mode page also not just in the authority details page. Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #4 from George Veranis <gveranis@dataly.gr> --- Hi Patrick, On edit mode of an authority as you can check also at the attached screenshot already exist . Can you please provide me more explanation , or maybe a screenshot , where you expect to have that info that you need ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #5 from Patrick Robitaille <patrick.robitaille@collecto.ca> --- Hi, In the screenshot you added, you are at the authority details page. Here you can see the number of notices attached. What I would like is that when we click on 'Edit' and switch to the authority's edit page to also have this information that shows the number of records attached on that page. Is it clearer to you? I added a screenshot to this task Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #6 from Patrick Robitaille <patrick.robitaille@collecto.ca> --- Created attachment 129294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129294&action=edit Authority edit page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #7 from George Veranis <gveranis@dataly.gr> --- Yes, now is more clear , sorry to not understand it earlier ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add the link of number of |Add the link of number of |times the authority are |times the authority are |used in edit mode |used in edit mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #8 from George Veranis <gveranis@dataly.gr> --- Created attachment 131065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131065&action=edit Bug 20615: Add the link of number of times the authority are used in edit mode Currently when show an authority record you can see the count of records linked with that authority, but when edit that authority record the that detail is dissapeared. Applying this patch will have that information also on edit mode of authority. Test plan: 1) Search for an authority that is already connected with at least one record 2) On detail view of an authority you can check that authority is linked with x records. 3) Edit that authority and the information about in how many records that authority is linked is missing. 4) Apply this patch 5) Edit again that authrity and you can find now the count in how many records is used that authority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131065|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 131171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131171&action=edit Bug 20615: Add the link of number of times the authority are used in edit mode Currently when show an authority record you can see the count of records linked with that authority, but when edit that authority record the that detail is dissapeared. Applying this patch will have that information also on edit mode of authority. Test plan: 1) Search for an authority that is already connected with at least one record 2) On detail view of an authority you can check that authority is linked with x records. 3) Edit that authority and the information about in how many records that authority is linked is missing. 4) Apply this patch 5) Edit again that authrity and you can find now the count in how many records is used that authority Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Needs Signoff |Signed Off --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Looks like this was signed off so adjusting bug status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Aleisha Amohia from comment #10)
Looks like this was signed off so adjusting bug status.
Thanks, Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've changed the patch author for root <root@vmi538303.contaboserver.net> to George Veranis <gveranis@dataly.gr> and reattached the patch. The problem here is bug 30641 which I think makes this require another follow-up. The code was taken from the detail page, which shows the wrong number of linked authorities. I wonder if Koha::Authorities->find($authid); doesn't do an exact search? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131171|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134226&action=edit Bug 20615: Add the link of number of times the authority are used in edit mode Currently when show an authority record you can see the count of records linked with that authority, but when edit that authority record the that detail is dissapeared. Applying this patch will have that information also on edit mode of authority. Test plan: 1) Search for an authority that is already connected with at least one record 2) On detail view of an authority you can check that authority is linked with x records. 3) Edit that authority and the information about in how many records that authority is linked is missing. 4) Apply this patch 5) Edit again that authrity and you can find now the count in how many records is used that authority Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I wonder if Koha::Authorities->find($authid); doesn't do an exact search? That's wrong. It's using:
get_usage_count So we'd need to look there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641 [Bug 30641] Authority detail page shows wrong number of records using the authority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I have investigated a bit more. The wrong count is due to how we handle things in get_usage_count and it only happens when Elasticsearch is used in combination with QueryAutoTruncate = ON. We will need to fix get_usage_count, but we should do this separately. Willing to pass this as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134226|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134249&action=edit Bug 20615: Add the link of number of times the authority are used in edit mode Currently when show an authority record you can see the count of records linked with that authority, but when edit that authority record the that detail is dissapeared. Applying this patch will have that information also on edit mode of authority. Test plan: 1) Search for an authority that is already connected with at least one record 2) On detail view of an authority you can check that authority is linked with x records. 3) Edit that authority and the information about in how many records that authority is linked is missing. 4) Apply this patch 5) Edit again that authrity and you can find now the count in how many records is used that authority Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30641 Depends on|30641 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641 [Bug 30641] Authority detail page shows wrong number of records using the authority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org