[Bug 30290] New: Article requests: Specify TOC on AR notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Bug ID: 30290 Summary: Article requests: Specify TOC on AR notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Follow-up of report 29093. We should add a line showing if TOC was requested. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 [Bug 29093] Article requests: Checkbox for table of contents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 131654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131654&action=edit Bug 30290: Adjust sample_notices.yml Test plan: Run a new install. Check the AR notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 131655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131655&action=edit Bug 30290: Database revision for existing notices Note: It will be hard to update translated notices. If we cannot find the part 'Pages:' then the replace does not do anything. Test plan: Run db rev. Check an existing AR notice (English). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 131656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131656&action=edit Bug 30290: (follow-up) Add warning for translated notices Note: Problem is that we cannot know if default was translated or en contains the original notice. Actually this holds for the other languages too. So this is an educated guess without using the lang field. Test plan: Run db rev. Trigger the warning by replacing Pages by PPages in an AR notice. Run db rev again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133468&action=edit Bug 30290: Adjust sample_notices.yml Test plan: Run a new install. Check the AR notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133469&action=edit Bug 30290: Database revision for existing notices Note: It will be hard to update translated notices. If we cannot find the part 'Pages:' then the replace does not do anything. Test plan: Run db rev. Check an existing AR notice (English). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133470&action=edit Bug 30290: (follow-up) Add warning for translated notices Note: Problem is that we cannot know if default was translated or en contains the original notice. Actually this holds for the other languages too. So this is an educated guess without using the lang field. Test plan: Run db rev. Trigger the warning by replacing Pages by PPages in an AR notice. Run db rev again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I tested this and works as expected. My only doubt would be the wording. I'd prefer to see: Include TOC: yes/no but no strongly attached to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133730&action=edit Bug 30290: (QA follow-up) Sample notices: Change phrasing to Yes/No -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133468|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133731&action=edit Bug 30290: Adjust sample_notices.yml Test plan: Run a new install. Check the AR notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133469|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133732&action=edit Bug 30290: Database revision for existing notices Note: It will be hard to update translated notices. If we cannot find the part 'Pages:' then the replace does not do anything. Test plan: Run db rev. Check an existing AR notice (English). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133470|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133733&action=edit Bug 30290: (follow-up) Add warning for translated notices Note: Problem is that we cannot know if default was translated or en contains the original notice. Actually this holds for the other languages too. So this is an educated guess without using the lang field. Test plan: Run db rev. Trigger the warning by replacing Pages by PPages in an AR notice. Run db rev again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133734&action=edit Bug 30290: (QA follow-up) Sample notices/database update: Change phrasing to Yes/No Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #7)
I tested this and works as expected. My only doubt would be the wording. I'd prefer to see:
Include TOC: yes/no
but no strongly attached to it.
I had the same feeling so I povided a follow-up with this change. As we had been burnt on bug 29805 with old MySQL versions, I also verified that RLIKE and REGEXP are both ok to use: https://dev.mysql.com/doc/refman/5.7/en/regexp.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Article requests: Specify |Article requests: Add TOC |TOC on AR notices |information to AR notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org