https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |matt.blenkinsop@openfifth.c | |o.uk, oleonard@myacpl.org, | |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188815&action=edit Bug 41151: Improve additional fields display alignment and formatting This patch improves the display of additional fields by: - Removing the nested fieldset wrapper that caused alignment issues - Converting the legend to a header list item for consistency - Aligning additional field labels with main form field labels - Displaying multi-value fields (comma-separated) on separate lines without bullets or extra indentation, aligned with single values - Using the same visual separator pattern as the entry form This creates perfect alignment between additional fields and regular fields in the display view, with multi-value fields showing cleanly stacked values in the same column as single values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188817|Updated input view |Updated table display description| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188819&action=edit Updated display view -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188814|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 188820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188820&action=edit Bug 41151: Modernize clear button UX in additional fields This patch improves the UX of the clear functionality for additional fields by: - Replacing the separate "Clear" button with an inline clear icon (×) that appears inside the input field when there is content - Adding proper spacing between the input field and "New" button using flexbox layout - Styling the "New" button with Bootstrap button classes for consistency - Making the clear button only visible when the field has content This provides a more modern, intuitive interface pattern similar to standard search inputs and maintains better visual consistency with other form elements in Koha. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188816|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 188822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188822&action=edit Bug 41151: Display multi-value additional fields as lists in datatables This patch improves the display of searchable repeatable additional fields in datatable columns by: - Detecting comma-separated values in the value_str field - Rendering multiple values as an HTML unordered list instead of comma-separated text - Adding appropriate CSS styling for list display within table cells - Maintaining single-value display for non-repeatable fields This makes multi-value additional fields much more readable in list views, with each value appearing on its own line within the table cell. For example, "Bang, History" now displays as: • Bang • History This completes the UX improvements for additional fields across all three contexts: entry forms, detail views, and list datatables. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #11 from Michaela Sieber <michaela.sieber@kit.edu> --- I like it ! There is only one thing I noticed when exporting a result list: if you have an additional field that is repeatable it is displayed now as a list with bullets. But if you do an export (excel or csv) the values are all in one cell without separators. In the past the values were separated with a comma+space -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188821|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188875&action=edit Bug 41151: Improve additional fields display alignment and formatting This patch improves the display of additional fields by: - Removing the nested fieldset wrapper that caused alignment issues - Converting the legend to a header list item for consistency - Aligning additional field labels with main form field labels - Displaying multi-value fields (comma-separated) on separate lines without bullets or extra indentation, aligned with single values - Using the same visual separator pattern as the entry form This creates perfect alignment between additional fields and regular fields in the display view, with multi-value fields showing cleanly stacked values in the same column as single values. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188877&action=edit Bug 41151: Preserve multi-value formatting in datatable exports This patch fixes the export functionality for repeatable additional fields in datatables. Previously, when exporting to CSV or Excel, multi-value fields displayed as HTML markup instead of properly formatted values. The fix detects when DataTables is requesting data for export (type === "export") and returns newline-separated values instead of HTML list markup. This ensures that: - CSV exports properly quote cells containing newlines - Excel exports display each value on a separate line within the cell - The visual list structure is maintained in exported data - Each field's values remain in the correct cell/row For example, a field with values "Bang, History" now exports as: Bang History (with each value on its own line within the same cell) This complements the display improvements made in the previous commits while ensuring exports remain clean and properly formatted. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188878&action=edit Bug 41151: Add optional clear button to standard input components This patch enhances the core input components (InputText, InputNumber, and TextArea) with optional clear button functionality, providing a consistent UX across both standard fields and additional fields. Changes: - Added optional 'clearable' prop (default: true) to all three components - Implemented clear button with identical styling to additional fields - Clear button only appears when field has content - Can be disabled per-field with clearable: false if needed The clear button: - Appears as a small 'x' icon on the right side of the input - Only shows when the field contains a value - Uses consistent styling and behavior across all input types - Includes proper ARIA labels for accessibility - Has hover and focus states for better UX Usage (enabled by default): <InputText v-model="myValue" /> <InputNumber v-model="myNumber" /> <TextArea v-model="myText" /> To disable for specific fields: <InputText :clearable="false" v-model="myValue" /> This provides developers with a simple, modern clear button UX by default across all form inputs, ensuring consistency throughout the entire application. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188880&action=edit Bug 41151: Replace FontAwesome icons with SVG and improve input styling This patch updates all clear buttons with two improvements: 1. Replaced FontAwesome icons with cleaner SVG X icon from vue-select 2. Updated input padding to match Select2/vue-select styling Changes: - Replaced <i class="fa fa-times"></i> with SVG in InputText - Replaced <i class="fa fa-times"></i> with SVG in InputNumber - Replaced <i class="fa fa-times"></i> with SVG in TextArea - Replaced <i class="fa fa-times"></i> with SVG in AdditionalFieldsEntry - Updated CSS from .clear-button i to .clear-button svg - Added title attribute for better tooltip support - Updated input padding from just "padding-right: 2rem" to full padding specification: "padding: 0.375rem 2rem 0.375rem 0.75rem" - Added line-height: 1.5 to match Select2 styling The SVG icon: - Is the same 10x10 SVG used in vue-select components - Uses currentColor via fill for proper color inheritance - Maintains the same hover/focus color transitions (#999 → #333) - Provides a cleaner, more professional appearance The improved padding: - Matches the vertical and horizontal spacing of Select2 dropdowns - Makes text inputs less "squashed" and more spacious - Creates visual consistency across all form controls - Uses Bootstrap's standard input padding (0.375rem vertical, 0.75rem horizontal) This creates visual consistency between clear buttons and padding across all input types and the existing Select2/vue-select components. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #21 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Martin Renvoize (ashimema) from comment #16)

Thankyou so much for the thorough testing and great spot finding the export issue Michaela, hopefully my additional patch resolves that too now :)

Your're welcome! I set up a new sandbox with the new patches but the exported values are still in one cell without separator. As well in Excel as in Libre Office -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from David Nind <david@davidnind.com> --- Can confirm that when exporting repeatable fields with multiple values, the values are no longer comma separated with a space. For example, before the patches it was "Test 1, Test2", now it is "Test 1Test2". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Right.. I've found the issue.. Davids security work around for DataTables breaks any multiple line formatted cells for export/output. Bug 37727 - CVE-2024-24337 - Fix CSV formula injection - client side (DataTables) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188874|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189295&action=edit Bug 41151: Modernize clear button UX in additional fields This patch improves the UX of the clear functionality for additional fields by: - Replacing the separate "Clear" button with an inline clear icon (×) that appears inside the input field when there is content - Adding proper spacing between the input field and "New" button using flexbox layout - Styling the "New" button with Bootstrap button classes for consistency - Making the clear button only visible when the field has content This provides a more modern, intuitive interface pattern similar to standard search inputs and maintains better visual consistency with other form elements in Koha. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188876|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189297&action=edit Bug 41151: Display multi-value additional fields as lists in datatables This patch improves the display of searchable repeatable additional fields in datatable columns by: - Detecting comma-separated values in the value_str field - Rendering multiple values as an HTML unordered list instead of comma-separated text - Adding appropriate CSS styling for list display within table cells - Maintaining single-value display for non-repeatable fields This makes multi-value additional fields much more readable in list views, with each value appearing on its own line within the table cell. For example, "Bang, History" now displays as: • Bang • History This completes the UX improvements for additional fields across all three contexts: entry forms, detail views, and list datatables. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188878|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189299&action=edit Bug 41151: Add optional clear button to standard input components This patch enhances the core input components (InputText, InputNumber, and TextArea) with optional clear button functionality, providing a consistent UX across both standard fields and additional fields. Changes: - Added optional 'clearable' prop (default: true) to all three components - Implemented clear button with identical styling to additional fields - Clear button only appears when field has content - Can be disabled per-field with clearable: false if needed The clear button: - Appears as a small 'x' icon on the right side of the input - Only shows when the field contains a value - Uses consistent styling and behavior across all input types - Includes proper ARIA labels for accessibility - Has hover and focus states for better UX Usage (enabled by default): <InputText v-model="myValue" /> <InputNumber v-model="myNumber" /> <TextArea v-model="myText" /> To disable for specific fields: <InputText :clearable="false" v-model="myValue" /> This provides developers with a simple, modern clear button UX by default across all form inputs, ensuring consistency throughout the entire application. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188922|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189301&action=edit Bug 41151: Replace FontAwesome icons with SVG and improve input styling This patch updates all clear buttons with two improvements: 1. Replaced FontAwesome icons with cleaner SVG X icon from vue-select 2. Updated input padding to match Select2/vue-select styling Changes: - Replaced <i class="fa fa-times"></i> with SVG in InputText - Replaced <i class="fa fa-times"></i> with SVG in InputNumber - Replaced <i class="fa fa-times"></i> with SVG in TextArea - Replaced <i class="fa fa-times"></i> with SVG in AdditionalFieldsEntry - Updated CSS from .clear-button i to .clear-button svg - Added title attribute for better tooltip support - Updated input padding from just "padding-right: 2rem" to full padding specification: "padding: 0.375rem 2rem 0.375rem 0.75rem" - Added line-height: 1.5 to match Select2 styling The SVG icon: - Is the same 10x10 SVG used in vue-select components - Uses currentColor via fill for proper color inheritance - Maintains the same hover/focus color transitions (#999 → #333) - Provides a cleaner, more professional appearance The improved padding: - Matches the vertical and horizontal spacing of Select2 dropdowns - Makes text inputs less "squashed" and more spacious - Creates visual consistency across all form controls - Uses Bootstrap's standard input padding (0.375rem vertical, 0.75rem horizontal) This creates visual consistency between clear buttons and padding across all input types and the existing Select2/vue-select components. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- OK, I had to revert part of this set.. I chose to revert it as a distinct commit to clarify my intentions, and I'll add a follow-up bug for the datatable display enhancement we intended to implement here. Apologies, but I feel it's better to drop that last piece for now rather than hold up the rest. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189296|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189298|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189302|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194274&action=edit Bug 41151: Improve additional fields display alignment and formatting This patch improves the display of additional fields by: - Removing the nested fieldset wrapper that caused alignment issues - Converting the legend to a header list item for consistency - Aligning additional field labels with main form field labels - Displaying multi-value fields (comma-separated) on separate lines without bullets or extra indentation, aligned with single values - Using the same visual separator pattern as the entry form This creates perfect alignment between additional fields and regular fields in the display view, with multi-value fields showing cleanly stacked values in the same column as single values. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194276&action=edit Bug 41151: Preserve multi-value formatting in datatable exports This patch fixes the export functionality for repeatable additional fields in datatables. Previously, when exporting to CSV or Excel, multi-value fields displayed as HTML markup instead of properly formatted values. The fix detects when DataTables is requesting data for export (type === "export") and returns newline-separated values instead of HTML list markup. This ensures that: - CSV exports properly quote cells containing newlines - Excel exports display each value on a separate line within the cell - The visual list structure is maintained in exported data - Each field's values remain in the correct cell/row For example, a field with values "Bang, History" now exports as: Bang History (with each value on its own line within the same cell) This complements the display improvements made in the previous commits while ensuring exports remain clean and properly formatted. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194278&action=edit Bug 41151: Wire clearable prop through FormElement to input components This patch enables the clearable functionality in forms that use the BaseResource/FormElement pattern by passing the clearable attribute from field definitions through to the underlying input components. Changes: - Updated FormElement to pass clearable prop to InputText - Updated FormElement to pass clearable prop to InputNumber - Updated FormElement to pass clearable prop to TextArea The logic only passes clearable when explicitly defined in the field configuration, allowing the component's default (true) to apply when not specified. This means: - Fields without clearable attribute: clear button enabled (default) - Fields with clearable: false: clear button disabled - Fields with clearable: true: clear button explicitly enabled All text, number, and textarea fields in BaseResource forms (like agreements, packages, titles, etc.) now automatically get the clear button UX unless explicitly disabled. Example to disable for a specific field: { name: "my_field", type: "text", label: $__("My Field"), clearable: false, // Disable clear button for this field } This completes the clear button UX implementation across all form input patterns in the application. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194280&action=edit Bug 41151: Revert multi-value display and export formatting changes This reverts commits: - 042b0e90bab "Bug 41151: Preserve multi-value formatting in datatable exports" - dc280faea41 "Bug 41151: Display multi-value additional fields as lists in datatables" These commits attempted to improve the display of multi-value additional fields in datatables by rendering them as lists and preserving newlines in exports. However, the implementation conflicted with existing DataTables export button formatting that strips newlines for security reasons (Bug 37727). The root issue is that Koha currently uses: - datatables.net-buttons 2.3.4 (from Feb 2023) - datatables.net-vue3 2.0.0 (requires DataTables 1.x) Native support for escapeExcelFormula (which would allow proper newline handling) requires: - datatables.net-buttons 3.2.0+ (introduced escapeExcelFormula) - datatables.net-vue3 3.x (for DataTables 2.x compatibility) This revert allows us to: 1. Create a separate bug for upgrading DataTables to version 2.x with Buttons 3.x for native formula escaping and better export handling 2. Re-implement the multi-value display feature with proper export support once the DataTables upgrade is complete The reverted functionality will be restored in future patches once the underlying DataTables infrastructure is upgraded. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm still hopeful this one might make it this cycle... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #45 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197506&action=edit Bug 41151: Remove JS warnings [Vue warn]: setup() return property "$__" should not start with "$" or "_" which are reserved prefixes for Vue internals. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197523&action=edit Bug 41151: Address QA feedback for Vue clear button Follow-up to QA review: - Consolidate duplicated .clear-button / .input-with-clear-* rules into koha-tmpl/intranet-tmpl/prog/css/vue.css and drop the scoped <style> blocks from InputText, InputNumber, TextArea and AdditionalFieldsEntry. - Replace the inline <svg> clear icon with <i class="fa fa-xmark"> (bold via CSS) to reuse the existing FontAwesome glyph already in use elsewhere (cataloguing/addbiblio.tt, circ/returns.tt). - In AdditionalFieldsEntry.vue, switch the repeatable input wrapper from Bootstrap's .input-group to .input-with-clear-wrapper. The .input-group class forced border-top-right-radius: 0 and border-bottom-right-radius: 0 on the input because Bootstrap expects an appended addon button; our clear button is absolutely positioned so no input-group behavior is wanted. - Remove the empty <label></label> placeholder from the "Additional fields" header and align the heading with CSS padding on the <li> instead. - Simplify FormElement.vue's :clearable binding. The ternary "attr.clearable !== undefined ? attr.clearable : undefined" evaluates identically to attr.clearable: when undefined is passed, Vue treats the prop as not passed and the child default (true) kicks in. The simpler form is equivalent and easier to read. To test: 1. yarn js:build && yarn css:build inside KTD. 2. Staff -> ERM -> Agreements -> Edit. Text/textarea fields show the fa-xmark clear button; clicking clears. 3. Any form with repeatable additional text fields: the input keeps proper rounded corners on the right side (no Bootstrap input-group border-radius reset). 4. Inspect DOM: no <label></label> in the additional-fields-header. 5. Inspect CSS: clear-button styles load once from vue.css, not from per-component scoped styles. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #44)

QA review:

1. if you have a repeatable field and a value with commas: value1: a,b,c, value2: b value3: c

On the "show" view they are displayed: Before the patch: a,b,c, b, c

After: a b c b c

Didn't I already revert that in my last commit.. it's been a while since I looked at this.

2. The CSS is duplicated, it think it should be moved to koha-tmpl/intranet-tmpl/prog/css/vue.css.

3. There is also a duplication of the icon. Why didn't you pick fa-xmark instead? If you make it bold it's almost identical as the svg.

4. The input of additional fields get the following CSS rules when the clear button is visible: border-top-right-radius: 0; border-bottom-right-radius: 0;

5. There is an empty label in AdditionalFieldsEntry.vue + <label></label>

6. There are several warnings in the console: [Vue warn]: setup() return property "$__" should not start with "$" or "_" which are reserved prefixes for Vue internals.

7. I would add a Cypress test to test the "0" "", etc. for InputText and InputNumber

8. in FormElement.vue + :clearable=" + attr.clearable !== undefined ? attr.clearable : undefined + " What's the subtlety I am not getting here?

Why not :clearable="attr.clearable"? Or, shouldn't we pass true/false instead?

All address in the two follow-ups. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197705&action=edit Bug 41151: (follow-up) Quote comma-bearing repeat values in strings_map The previous display fix on this bug left a latent issue: when a repeatable additional field held a value that itself contained a comma (e.g. "a,b,c"), the joined value_str was indistinguishable from three plain repeats. Any consumer that split on "," would mangle the data. Encode value_str with a CSV-style convention: the separator stays ", ", but any individual value containing "," or '"' is wrapped in double quotes with internal quotes doubled (RFC 4180-ish). Plain values pass through unchanged, so "red, blue, green" still round-trips as-is, while "a,b,c" / "b" / "c" now encodes as '"a,b,c", b, c' and is losslessly parsable. Test plan: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197707&action=edit Bug 41151: (follow-up) Restore multi-value list rendering in KohaTable Commit dc280fa ("Display multi-value additional fields as lists in datatables") was reverted in 9e7d7ac because its display logic relied on the same naive comma-split that mangled comma-bearing values, and because the companion export commit (042b0e9) was blocked on a DataTables upgrade. With parseValueStr() in place we can safely restore the display half: reuse the shared parser to turn a multi-value value_str into a <ul>, and return plain value_str for non-display render calls so filtering, sorting, and CSV/Excel export keep working exactly as they do today. HTML-escape each entry on the way in; the original reverted patch interpolated raw field values into markup, which would be a latent XSS for any staff user who could author an additional-field value. The export newline formatting (042b0e9) is deliberately not restored here; it remains blocked on upgrading datatables.net-buttons to 3.2.0+ and datatables.net-vue3 to 3.x for native escapeExcelFormula support. Test plan: 1. Rebuild JS: yarn js:build 2. Load a datatable view that renders a searchable repeatable additional field (e.g. ERM agreements or ILL requests). 3. For a row with three repeats where one value contains commas, confirm the cell shows a bulleted list of three items with the comma-bearing entry intact on its own line. 4. Export the table to CSV; confirm exported cells show the plain comma-separated value_str (unchanged from the current reverted state). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Strategic theme|--- |Modernisation Initiative type|--- |Epic Target Milestone|--- |26.11 -- You are receiving this mail because: You are watching all bug changes.