https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #44)
QA review:
1. if you have a repeatable field and a value with commas: value1: a,b,c, value2: b value3: c
On the "show" view they are displayed: Before the patch: a,b,c, b, c
After: a b c b c
Didn't I already revert that in my last commit.. it's been a while since I looked at this.
2. The CSS is duplicated, it think it should be moved to koha-tmpl/intranet-tmpl/prog/css/vue.css.
3. There is also a duplication of the icon. Why didn't you pick fa-xmark instead? If you make it bold it's almost identical as the svg.
4. The input of additional fields get the following CSS rules when the clear button is visible: border-top-right-radius: 0; border-bottom-right-radius: 0;
5. There is an empty label in AdditionalFieldsEntry.vue + <label></label>
6. There are several warnings in the console: [Vue warn]: setup() return property "$__" should not start with "$" or "_" which are reserved prefixes for Vue internals.
7. I would add a Cypress test to test the "0" "", etc. for InputText and InputNumber
8. in FormElement.vue + :clearable=" + attr.clearable !== undefined ? attr.clearable : undefined + " What's the subtlety I am not getting here?
Why not :clearable="attr.clearable"? Or, shouldn't we pass true/false instead?
All address in the two follow-ups. -- You are receiving this mail because: You are watching all bug changes.