[Bug 7896] New: Acquisition statistics wizard: add filters and cell values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 7896 Assignee: julian.maurice@biblibre.com Summary: Acquisition statistics wizard: add filters and cell values QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Reports Product: Koha This development, sponsored by Aix-Marseille university, add the following changes: - Possibility to select for line and column: items.homebranch and items.ccode - Possibility to filter on these fields - Possibility to count unique biblios (count(distinct biblionumber)), ordered amount and spent amount (based on aqorders.datereceived) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8863&action=edit Acq statistics wizard: add filters and cell values - Possibility to select for line and column: items.homebranch and items.ccode - Possibility to filter on these fields - Possibility to count unique biblios (count(distinct biblionumber)), ordered amount and spent amount (based on aqorders.datereceived) Filtering on item homebranch and ccode works only on items that were created at ordering or receiving (ie items are linked to an order) Some refactoring is done, mainly replacing switch-like if statements by given/when -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |7175 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Note that partially received orders can make the calculation wrong since partially received orders are splitted, but links to created items are not updated. This is fixed by bug 7175, so marking this one as dependent of 7175 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #3 from delaye <stephane.delaye@biblibre.com> --- i try to test the patch with sandbox 3 but i have this message when i want open the statistic tool Software error: Type of arg 1 to keys must be hash (not private variable) at /home/koha/src/reports/acquisitions_stats.pl line 246, near "$branches ) " Execution of /home/koha/src/reports/acquisitions_stats.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8863|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8865&action=edit Acq statistics wizard: add filters and cell values Same patch, with incompatibilities fixed to be Perl 5.10 compliant: keys $branches changed to keys %$branches $var = do { given ($i) { when(1) { "..." } ... } }; changed to given ($i) { when (1) { $var = "..." } ... } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #5 from delaye <stephane.delaye@biblibre.com> --- i have tested in a sandbox (3) it works Some details for those who want to test amount = ammount spended + ammount ordered collection = items.ccode -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Bug 7896 depends on bug 7175, which changed state. Bug 7175 Summary: Improve order receiving page http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- I can't test completly this patch because I haven't enough acquisition data. But it seems to work. Two remarks/demands: [1] GetMarcSubfieldStructureFromKohaField new routine is querying marc_subfield_structure table. It should be cached. Or, since it must have been already retrieved, and cached by GetMarcStructure, the cached version of frameworks must be used. [2] Some texts are not translatable. It was already there, but your patch add text that can't be translated: In reports/acquisitions_stats.pl, line 126, there is: $select{''} = "All Suppliers"; Since it isn't in template, it can't be translated. The is also: given ($i) { when (0) { $cell{crit} = "Placed On From" } when (1) { $cell{crit} = "Placed On To" } when (2) { $cell{crit} = "Received On From" } when (3) { $cell{crit} = "Received On To" } when (4) { $cell{crit} = "Bookseller" } when (5) { $cell{crit} = "Home branch" } when (6) { $cell{crit} = "Collection" } when (7) { $cell{crit} = "Doc Type" } when (8) { $cell{crit} = "Budget" } when (9) { $cell{crit} = "Sort1" } when (10) { $cell{crit} = "Sort2" } default { $cell{crit} = "" } Could you propose a fix to help translate this page? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11103&action=edit Bug 7896: follow-up: Allow translation of strings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to comment #6)
I can't test completly this patch because I haven't enough acquisition data. But it seems to work.
Two remarks/demands:
[1] GetMarcSubfieldStructureFromKohaField new routine is querying marc_subfield_structure table. It should be cached. Or, since it must have been already retrieved, and cached by GetMarcStructure, the cached version of frameworks must be used.
Why ? It is used only once, in a report page, outside of any loop. I don't think we should continue to use the same caching method as the one used for GetMarcStructure as it is not compatible with Plack and mod_perl (and any method that provides persistency)
[2] Some texts are not translatable. It was already there, but your patch add text that can't be translated:
Fixed in the new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8865|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12945&action=edit [SIGNED-OFF] Bug 7896: Acq statistics wizard: add filters and cell values - Possibility to select for line and column: items.homebranch and items.ccode - Possibility to filter on these fields - Possibility to count unique biblios (count(distinct biblionumber)), ordered amount and spent amount (based on aqorders.datereceived) Filtering on item homebranch and ccode works only on items that were created at ordering or receiving (ie items are linked to an order) Some refactoring is done, mainly replacing switch-like if statements by given/when Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11103|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12946&action=edit [SIGNED-OFF] Bug 7896: follow-up: Allow translation of strings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Medium patch QA Contact|koha.sekjal@gmail.com |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I looked at the patch and there are lots of smaller things I noted while testing: 1) Terms and capitalization - Budget/All budgets is labelled wrong, as it really shows the funds - All Item Types should be 'All item types' - All Suppliers should be 'All vendors' 2) Untranslatable terms - $select{''} = "All budgets"; - $select{''} = "All Item Types"; 3) POD - Old copy & paste error: plugin that shows a stats on borrowers 4) Item type - biblio level only? - Looking at the code it seems like only bibio level itypes are taken into account. I wonder if the stats should use 'item-level itypes'. If that can't be done, a little note would be helpful. 5) Error logs (can be reproduced by sending the form with preselected options) [Sun Dec 02 10:24:14 2012] [error] [client 127.0.0.1] [Sun Dec 2 10:24:14 2012] acquisitions_stats.pl: Use of uninitialized value in addition (+) at /home/katrin/kohaclone/reports/acquisitions_stats.pl line 582., referer: http://localhost:8080/cgi-bin/koha/reports/acquisitions_stats.pl That all said, perlcritic passes, all tests pass, and most problems are preexistant to your patches. But I would love to see a follow up addressing some of the other problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12945|0 |1 is obsolete| | Attachment #12946|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13818&action=edit [SIGNED-OFF] Bug 7896: Acq statistics wizard: add filters and cell values - Possibility to select for line and column: items.homebranch and items.ccode - Possibility to filter on these fields - Possibility to count unique biblios (count(distinct biblionumber)), ordered amount and spent amount (based on aqorders.datereceived) Filtering on item homebranch and ccode works only on items that were created at ordering or receiving (ie items are linked to an order) Some refactoring is done, mainly replacing switch-like if statements by given/when Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13819&action=edit [SIGNED-OFF] Bug 7896: follow-up: Allow translation of strings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. As a note, per this page http://perldoc.perl.org/perlsyn.html#Switch-Statements we try to avoid given statements. As your follow-up removed the given statement, this is a non-issue for this patch, of course. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Ok in master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org