http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to comment #6)
I can't test completly this patch because I haven't enough acquisition data. But it seems to work.
Two remarks/demands:
[1] GetMarcSubfieldStructureFromKohaField new routine is querying marc_subfield_structure table. It should be cached. Or, since it must have been already retrieved, and cached by GetMarcStructure, the cached version of frameworks must be used.
Why ? It is used only once, in a report page, outside of any loop. I don't think we should continue to use the same caching method as the one used for GetMarcStructure as it is not compatible with Plack and mod_perl (and any method that provides persistency)
[2] Some texts are not translatable. It was already there, but your patch add text that can't be translated:
Fixed in the new patch. -- You are receiving this mail because: You are watching all bug changes.