[Bug 29457] New: Fee Cancellation records the wrong manager_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Bug ID: 29457 Summary: Fee Cancellation records the wrong manager_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org With the introduction of bug 22008 it has highlighted an error in the charge cancellation controller. We are passing '$user', which contains cardnumber/userid, to cancel when we should be passing a borrowernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127527&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Without the above patch, cancelling a charge in the worst case can lead to a database error regarding key constrain failures.. or if your userid's happen to coincide with an existing borrowernumber it will record entirely the wrong user as the staff member who actioned the cancellation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127527|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127596&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- well this is bad indeed. I wonder what should be done with those corrupted entries, delete them or move them to some temp column in case someone wants to try to use them to track down the person who did the action? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I was really disappointed in myself getting this wedding in the first place :-(. Very good question regarding the corrupt entries; I can't see any obvious way to work backwards to reconstruct them so I think my vote would be to remove them... but I'm very much open to suggestions if anyone can think of a way to do better.. perhaps assigning to the anonymous user if one exists? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, maybe we can work backwards to get the right manager id.. I'll work on an update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127739&action=edit Bug 29457: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My database update works.. though I'm sure it could be refined. But.. it's not idempotent and I'm not sure how to fix that or whether it matters now we have the new DB update system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- The userid could have been changed later on by the staff member and someone else might have started to use that same userid, thus the DB upgrade here is buggy. Maybe the best bet is just to delete or move the data to some safe place? Or provide somehow instructions for the users to do the data recovery themselves. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't think we can/should move the data.. there's isn't a good place to put it. Whilst I agree the DB update isn't perfect either... perhaps move the DB update to a script that can be optionally run instead and leave the data as is otherwise.? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24603 CC| |jonathan.druart+koha@gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 [Bug 24603] Allow to cancel charges in patron accounting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #2)
Without the above patch, cancelling a charge in the worst case can lead to a database error regarding key constrain failures.. or if your userid's happen to coincide with an existing borrowernumber it will record entirely the wrong user as the staff member who actioned the cancellation.
It actually won't lead every often to a DBI exception, I've tried to recreate with userid="koha"/borrowernumber=51, and I saw that "koha" was passed to ->store, but "NULL" was actually in DB. It's coming from Koha::Object->store: 134 if ( _numeric_column_type( $columns_info->{$col}->{data_type} ) 135 or _decimal_column_type( $columns_info->{$col}->{data_type} ) 136 ) { 137 # Has been passed but not a number, usually an empty string 138 my $value = $self->_result()->get_column($col); 139 if ( defined $value and not looks_like_number( $value ) ) { 140 if ( $columns_info->{$col}->{is_nullable} ) { 141 # If nullable, default to null 142 $self->_result()->set_column($col => undef); And that's certainly why we didn't catch that earlier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What about a warn during the upgrade, for NULLs? Userid that was a valid borrowernumber will never be restored correctly, no idea what we can do with that. However the more the wait, the more we introduce bad data, we should fix ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here. This serves to demonstrate that the field name 'userid' is kind of confusing. E.g. user_code would already be better.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #12)
What about a warn during the upgrade, for NULLs?
Userid that was a valid borrowernumber will never be restored correctly, no idea what we can do with that.
However the more the wait, the more we introduce bad data, we should fix ASAP.
In most cases NULL will have been stored. So the db rev makes no sense. But the question is: Does it really hurt that the manager_id field is NULL for historic cancellations. Looks to me that it does not. So we could just go with the first patch? We could perhaps print the number of NULLs found in accountlines for this reason? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127596|0 |1 is obsolete| | Attachment #127739|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128024&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128025&action=edit Bug 29457: (QA follow-up) Warn number of missing manager_id's No sense in trying to match userid's with borrowernumbers. In 99% of the cases (at least) we will find just NULLs. We could print the number we found. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Joonas, Martin, do you agree with this follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128024|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128030&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128025|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128031&action=edit Bug 29457: (QA follow-up) Warn number of missing manager_id's No sense in trying to match userid's with borrowernumbers. In 99% of the cases (at least) we will find just NULLs. We could print the number we found. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128032&action=edit Bug 29457: (follow-up) Add additional information to warnings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- - say $out "Prior to this patch a users 'userid' was being passed into the manager_id field where borrowernumber is expected"; + say $out "Prior to this patch a user's 'userid' was being passed into the manager_id field where borrowernumber is expected"; And at the end + say $out "Nothing to worry about" unless $count_bad || $count_empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I would push at least the fix only ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_05_candidate --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #22)
I would push at least the fix only ?
Sorry, I haven't answered here. I was not confident to push this the same day of the release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK for push now ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- No, it's not ready. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I wouldnt try to run this LOL SELECT borrowernumber FROM borrowers WHERE borrowers.userid = accountlines.manager_id ) WHERE credit_type_code = 'CANCELLATION'' Double WHERE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Another try to get this further ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #26)
I wouldnt try to run this LOL
SELECT borrowernumber FROM borrowers WHERE borrowers.userid = accountlines.manager_id ) WHERE credit_type_code = 'CANCELLATION''
Double WHERE
Sorry, reading half the line or something -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This seems like overkill. But it worked for me without CAST warnings etc on alphanumeric userid's : UPDATE accountlines LEFT JOIN borrowers ON CAST(borrowers.userid AS INT) = accountlines.manager_id SET manager_id = borrowers.borrowernumber WHERE manager_id IS NOT NULL AND userid RLIKE "^[0-9]+$" AND borrowers.borrowernumber IS NOT NULL AND credit_type_code = 'CANCELLATION' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that the idea is just to list these SQL updates here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prior to this patch release notes| |inadvertently the field | |borrowers.userid was used | |to fill | |accountslines.manager_id. | |This should have been | |borrowernumber. | | | |This | |report fixes that. The | |dbrev will count the number | |of missing or bad | |manager_id's in | |cancellation records and | |report them. It refers to | |this report for optional | |sql updates to fix or clear | |the records. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- NOTE: This comment is referred to from the db revision of this report ! If you come here since a Koha upgrade referred you to this place, you have two options: (1) try to correct the incorrect manager_id's or (2) clear the incorrect manager_id's. A suggestion beforehand: Make a SQL dump before running the SQL updates below on your (production) data. OPTION 1 CORRECT In the more exceptional case that your records contain a numeric manager_id which actually is a USERID (read: user code) and NOT a borrowernumber, you may want to run this sql statement: UPDATE accountlines LEFT JOIN borrowers ON CAST(borrowers.userid AS INT) = accountlines.manager_id SET manager_id = borrowers.borrowernumber WHERE manager_id IS NOT NULL AND userid RLIKE "^[0-9]+$" AND borrowers.borrowernumber IS NOT NULL AND credit_type_code = 'CANCELLATION' OPTION 2 CLEAR Use this SQL statement to correct records with a wrong wrong manager_id, setting them to NULL: UPDATE accountlines SET manager_id = NULL WHERE manager_id IS NOT NULL AND credit_type_code = 'CANCELLATION' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128030|0 |1 is obsolete| | Attachment #128031|0 |1 is obsolete| | Attachment #128032|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128207&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128208&action=edit Bug 29457: (QA follow-up) Report about checked manager_id's We print the number of missing or incorrect manager_id's now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- In order to prevent running the dbrev twice and cause confusion, we could not push the second patch on master and only backport it. Since the second run might mark valid manager_id's as incorrect although they were added in a fixed system. Could someone come theoretically from a version where the error already exists, missed the backport fix and dbrev, and now upgrade to 22.05 (and miss the warn)? Yes, could be. If someone still wants to address this, please go ahead :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #34)
In order to prevent running the dbrev twice and cause confusion, we could not push the second patch on master and only backport it.
I don't think that will work, because people jump versions/come from an older version without the fix directly to a new version released from master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- I change to in dicussion to remember why I dont push to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #36)
I change to in dicussion to remember why I dont push to master.
Please explain what you are doing here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128649&action=edit Bug 29457: Generic warning at upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, how about that.. a super super generic note at upgrade telling people to come and read about the bug here.. no link (in case we ever switch from bugzilla), no counts (as they may well be incorrect if the update has already been run at some point) and a small note to say you might just want to ignore it entirely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128207|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128650&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128649|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128651&action=edit Bug 29457: Generic warning at upgrade Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: Adding exec flag and two dots. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is where we ended up discussing it for 23th time ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prior to this patch |Prior to this patch release notes|inadvertently the field |inadvertently the field |borrowers.userid was used |borrowers.userid was used |to fill |to fill |accountslines.manager_id. |accountslines.manager_id. |This should have been |This should have been |borrowernumber. |borrowernumber. | | |This |This |report fixes that. The |report fixes that and |dbrev will count the number |prints a generic warning. |of missing or bad | |manager_id's in | |cancellation records and | |report them. It refers to | |this report for optional | |sql updates to fix or clear | |the records. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #31)
NOTE: This comment is referred to from the db revision of this report !
NOTE: This is no longer the case :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #44 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle@bywatersolutions.com --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | --- Comment #46 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02,21.05.08 |22.05.00,21.11.02,21.05.08, released in| |20.11.15 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #47 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #48 from wainuiwitikapark@catalyst.net.nz --- Do I need to backport this to 19.11.x? I probably won't unless there is a need for it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #49 from wainuiwitikapark@catalyst.net.nz --- Not backported to 19.11.x. Please request it if you need it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org