https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457 [Bug 30457] Convert holds page tabs to Bootstrap -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134643|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134644&action=edit Bug 30693: Javascript broken on request.pl The holds page in the staff interface has some JavaScript relating to Bootstrap tabs, but the tabs are not always present on the page. This leads to a JS error after you have selected the patron for the hold. This patch adds a check for the tabs container element before executing the code. To test, apply the patch and locate a bibliographic record on which to place a hold. - On the initial holds screen should see tabs for "Patrons" and "Clubs." Both should work correctly. - Select a patron to place the hold for. - On the page where you enter hold details (pickup library, hold expiration, etc.) there should be no JavaScript error in the console. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134644|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134651&action=edit Bug 30693: Javascript broken on request.pl The holds page in the staff interface has some JavaScript relating to Bootstrap tabs, but the tabs are not always present on the page. This leads to a JS error after you have selected the patron for the hold. This patch adds a check for the tabs container element before executing the code. To test, apply the patch and locate a bibliographic record on which to place a hold. - On the initial holds screen should see tabs for "Patrons" and "Clubs." Both should work correctly. - Select a patron to place the hold for. - On the page where you enter hold details (pickup library, hold expiration, etc.) there should be no JavaScript error in the console. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed for 22.05, thanks to everyone involved :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Bug 30693 depends on bug 30457, which changed state. Bug 30457 Summary: Convert holds page tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.