[Bug 9077] New: OPAC Social media links broken by fix for Bug 8973
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 Priority: P5 - low Change sponsored?: --- Bug ID: 9077 Assignee: oleonard@myacpl.org Summary: OPAC Social media links broken by fix for Bug 8973 Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: 3.8 Component: OPAC Product: Koha The patch for Bug 8973 included changes to the social media links on the OPAC detail page, but the changes were based on master which includes the use of CSS sprites for the images. 3.8.x doesn't have the CSS sprites, so the images don't work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13452&action=edit Bug 9077 [3.8.x] OPAC Social media links broken by fix for Bug 8973 This patch returns the structure of the social media icons markup to the state it was in before the application of the patch for Bug 8973 and adds the missing filters which would have been added by that patch. To test, view any OPAC detail page in origin/3.8.x. After applying this patch the social media icons should appear normally. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 --- Comment #2 from Srikanth Dhondi <srikanth@catalyst.net.nz> --- Created attachment 13505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13505&action=edit [SIGNED-OFF] Bug 9077 [3.8.x] OPAC Social media links broken by fix for Bug 8973 This patch returns the structure of the social media icons markup to the state it was in before the application of the patch for Bug 8973 and adds the missing filters which would have been added by that patch. To test, view any OPAC detail page in origin/3.8.x. After applying this patch the social media icons should appear normally. Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 Srikanth Dhondi <srikanth@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srikanth@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13452|0 |1 is obsolete| | --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 13452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13452 Bug 9077 [3.8.x] OPAC Social media links broken by fix for Bug 8973 patch obsoleted by the signed-off one -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * small patch, html only * for 3.8 only passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9077 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org